From: Bozhidar Batsov <bozhidar@batsov.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] trunk r114939: * lisp/progmodes/ruby-mode.el (ruby-mode): Clean up docstring.
Date: Mon, 4 Nov 2013 19:05:40 +0200 [thread overview]
Message-ID: <CAM9Zgm392Fh_FBDsCYt0eLTX+HsuZN22zVJ_Bx7=g2OgkXhouw@mail.gmail.com> (raw)
In-Reply-To: <CAM9Zgm0nU-v5rKninLjoMVpA+6HsuFRMZPqT1PYz7g2xWL7BjQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
This text should probably be removed from the description of other major
modes as well, right?
On 4 November 2013 19:04, Bozhidar Batsov <bozhidar@batsov.com> wrote:
> I didn't like this as well, but I added it since that exact text appears
> in the docstrings of many major modes. I though it was something like an
> unwritten convention, but I guess many people have simply been copy-pasting
> the same code over the years. I'll have it removed.
>
>
> On 4 November 2013 18:43, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> > +Entry to this mode calls the value of `ruby-mode-hook'
>> > +if that value is non-nil."
>>
>> That's problematic:
>> - it's redundant since define-derived-mode already adds "In addition to
>> any hooks its parent mode `prog-mode' might have run,\nthis mode runs
>> the hook `ruby-mode-hook', as the final step\nduring initialization."
>> - hooks aren't "called" but are "run".
>> - it's not just "the value of `ruby-mode-hook'", but the *values*, since
>> hooks use both the buffer-local and the global value of the symbol.
>> - the hook is run even if it is nil (or unbound): running it will simply
>> not do anything.
>>
>>
>> Stefan
>>
>
>
[-- Attachment #2: Type: text/html, Size: 2012 bytes --]
next prev parent reply other threads:[~2013-11-04 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VdL1r-0000Yy-3H@vcs.savannah.gnu.org>
2013-11-04 16:43 ` [Emacs-diffs] trunk r114939: * lisp/progmodes/ruby-mode.el (ruby-mode): Clean up docstring Stefan Monnier
2013-11-04 17:04 ` Bozhidar Batsov
2013-11-04 17:05 ` Bozhidar Batsov [this message]
2013-11-04 18:50 ` Stefan Monnier
2013-11-05 10:22 ` Bozhidar Batsov
2013-11-05 17:01 ` Stefan Monnier
2013-11-05 17:14 ` Bozhidar Batsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9Zgm392Fh_FBDsCYt0eLTX+HsuZN22zVJ_Bx7=g2OgkXhouw@mail.gmail.com' \
--to=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.