From: Bozhidar Batsov <bozhidar@batsov.com>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template):
Date: Sat, 23 Nov 2013 15:23:02 +0200 [thread overview]
Message-ID: <CAM9Zgm22v8A6GyvaF=rQdNzWa5hZ7ZGO8tHg7JOEHf=Sw6_F9A@mail.gmail.com> (raw)
In-Reply-To: <iyr4a7hmhz.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
On 23 November 2013 04:37, Glenn Morris <rgm@gnu.org> wrote:
>
> Thanks for adding a test/ChangeLog entry.
> Do please list the names of the tests in the entry.
>
Will do.
> ChangeLog entries should name every function, variable that they touch.
> I notice this did not happen eg in
> http://lists.gnu.org/archive/html/emacs-diffs/2013-11/msg00216.html
> which changed an option, added several new functions, and modified
> another, but only mentioned the last in the ChangeLog.
>
Since the new functions were extracted from the modified function I wasn't
sure if they needed mentioning.
Basically in a situation like this I should list all symbols like this
(sym1, sym2...): and write a unified summary regarding
all of them, right?
>
> Similarly
> http://lists.gnu.org/archive/html/emacs-diffs/2013-11/msg00150.html
> does not list the two new options as entities in their own right.
>
> Please could you review all your past changes with an eye to that,
> and improve the ChangeLogs where necessary?
>
Sure.
>
> Also, maybe you want to add a NEWS entry about those new options.
> This need be nothing more than:
>
> ** New Ruby mode options: foo, bar.
>
Will do.
>
> in the "Changes in Specialized Modes and Packages in Emacs 24.4" section.
>
[-- Attachment #2: Type: text/html, Size: 2444 bytes --]
next prev parent reply other threads:[~2013-11-23 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Vj5RK-0003OM-4J@vcs.savannah.gnu.org>
2013-11-21 15:41 ` trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template): Glenn Morris
2013-11-21 22:51 ` Bozhidar Batsov
2013-11-21 23:07 ` Glenn Morris
2013-11-21 23:17 ` Glenn Morris
2013-11-22 12:38 ` Bozhidar Batsov
2013-11-23 2:37 ` Glenn Morris
2013-11-23 13:23 ` Bozhidar Batsov [this message]
2013-11-25 19:40 ` Glenn Morris
2013-11-26 6:47 ` Bozhidar Batsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9Zgm22v8A6GyvaF=rQdNzWa5hZ7ZGO8tHg7JOEHf=Sw6_F9A@mail.gmail.com' \
--to=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.