From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default. Date: Wed, 13 Nov 2013 16:36:43 +0200 Message-ID: References: <61BBE6C8D4D349B6963A0F429237A3A8@gmail.com> <87txfvad0a.fsf@yandex.ru> <52755D62.1070700@yandex.ru> <87wqkpalgl.fsf@yandex.ru> <527AB880.4040207@yandex.ru> <527B7433.1070101@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e015376b6e3d49e04eb0fe44d X-Trace: ger.gmane.org 1384353415 19087 80.91.229.3 (13 Nov 2013 14:36:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Nov 2013 14:36:55 +0000 (UTC) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 13 15:37:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VgbYw-00048q-M5 for ged-emacs-devel@m.gmane.org; Wed, 13 Nov 2013 15:36:58 +0100 Original-Received: from localhost ([::1]:49057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgbYw-0005ct-6z for ged-emacs-devel@m.gmane.org; Wed, 13 Nov 2013 09:36:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgbYn-0005VS-Ss for emacs-devel@gnu.org; Wed, 13 Nov 2013 09:36:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgbYj-0007Pf-5V for emacs-devel@gnu.org; Wed, 13 Nov 2013 09:36:49 -0500 Original-Received: from mail-oa0-x22b.google.com ([2607:f8b0:4003:c02::22b]:39182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgbYi-0007PX-U0 for emacs-devel@gnu.org; Wed, 13 Nov 2013 09:36:45 -0500 Original-Received: by mail-oa0-f43.google.com with SMTP id g12so526372oah.16 for ; Wed, 13 Nov 2013 06:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=4BeXnZXyeSGTPdVTDP0qkRTB6WWx8Cw6uWRIMdkoP54=; b=oI1mcsi3rAUZw/sctVGClVLKZnLBlVcNgHHSTHv2XqpcHBfpMmG69LQ0leCIHVmq1I G/oVhOIyHX9h+ZqYp+Gu+rzmsYzHJCSLtt6FIyjEdrx6sI5c81I1tZC1qXmxFB9cdF8m LgPhWKys8duf6eWwUjn9SHUUMmUQInZXPOrBmbXv4/9pWsTJL8fITvtIef/ZrzY0mCzZ /PDH1ksp0UKMp6Hn+V1xrcjyhHkwU6/1Q0LvKTqtVCT8F8dEM+5N68zjyxERq2kiutl1 5bEyFe63Qn3JRZBDym9IOE0y5rTydNNmAsjfm9Yk/4znaWMWmWZzkyVg6XBnAXxoUbmx XIwg== X-Received: by 10.60.59.5 with SMTP id v5mr29752451oeq.30.1384353403947; Wed, 13 Nov 2013 06:36:43 -0800 (PST) Original-Received: by 10.76.21.173 with HTTP; Wed, 13 Nov 2013 06:36:43 -0800 (PST) In-Reply-To: <527B7433.1070101@yandex.ru> X-Google-Sender-Auth: TGmsrxWFq_Wo-OZiGjJ9npi14BM X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165234 Archived-At: --089e015376b6e3d49e04eb0fe44d Content-Type: multipart/alternative; boundary=089e015376b6e3d49904eb0fe44b --089e015376b6e3d49904eb0fe44b Content-Type: text/plain; charset=UTF-8 I've attached here a second patch that adds support for always inserting a utf-8 encoding comment. I've also simplified a bit the code of `ruby-mode-set-encoding' (by breaking it into several functions) as it was quite convoluted. On 7 November 2013 13:06, Dmitry Gutov wrote: > On 07.11.2013 12:23, Bozhidar Batsov wrote: > >> Btw, Dimitry - please add some info the ruby-mode.el about running the >> tests. I tried evaluating and running them manually, but this crashed my >> Emacs (the tests hogged my CPU completely and I had to kill Emacs). >> Maybe there is something wrong with them right now, or perhaps they >> should invoked in some manner I'm not aware of. >> > > I'm not aware of any problems running the tests, looks like a bug. Weren't > you able to stop the freezing with C-g, at least? > > I just open ruby-mode-tests.el, M-x eval-buffer, M-x ert RET. > They run fine. > --089e015376b6e3d49904eb0fe44b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've attached here a second patch that adds support fo= r always inserting a utf-8 encoding comment. I've also simplified a bit= the code of `ruby-mode-set-encoding' (by breaking it into several func= tions) as it was quite convoluted.=C2=A0


On 7 November= 2013 13:06, Dmitry Gutov <dgutov@yandex.ru> wrote:
On 07.11.2013 12:23, Bozhidar Batsov wrote:
Btw, Dimitry - please add some info the ruby-mode.el about running the
tests. I tried evaluating and running them manually, but this crashed my Emacs (the tests hogged my CPU completely and I had to kill Emacs).
Maybe there is something wrong with them right now, or perhaps they
should invoked in some manner I'm not aware of.

I'm not aware of any problems running the tests, looks like a bug. Were= n't you able to stop the freezing with C-g, at least?

I just open ruby-mode-tests.el, M-x eval-buffer, M-x ert RET.
They run fine.

--089e015376b6e3d49904eb0fe44b-- --089e015376b6e3d49e04eb0fe44d Content-Type: application/octet-stream; name="0001-lisp-progmodes-ruby-mode.el-ruby-mode-set-encoding.patch" Content-Disposition: attachment; filename="0001-lisp-progmodes-ruby-mode.el-ruby-mode-set-encoding.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnyo8xnf0 RnJvbSAxNzY4MzA1OTI2YmY2MDA4NGE0MmZmZWNhOTEzYmUzMmY2ZWUyODhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCb3poaWRhciBCYXRzb3YgPGJvemhpZGFyQGJhdHNvdi5jb20+ CkRhdGU6IFdlZCwgMTMgTm92IDIwMTMgMTY6MzE6NTkgKzAyMDAKU3ViamVjdDogW1BBVENIXSAq IGxpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCAocnVieS1tb2RlLXNldC1lbmNvZGluZyk6CgpB ZGQgc3VwcG9ydCBmb3IgYWx3YXlzIGluc2VydGluZyBhbiB1dGYtOCBlbmNvZGluZyBjb21tZW50 LgotLS0KIGxpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCB8IDY4ICsrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQyIGluc2VydGlv bnMoKyksIDI2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1Ynkt bW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbAppbmRleCA4NzQ1NGNkLi4xZThm YWYwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvcnVieS1tb2RlLmVsCkBAIC0yNTYsNyArMjU2LDEyIEBAIGV4cGxpY2l0bHkgZGVj bGFyZWQgaW4gbWFnaWMgY29tbWVudC4iCiAgIDpncm91cCAncnVieSkKIAogKGRlZmN1c3RvbSBy dWJ5LWluc2VydC1lbmNvZGluZy1tYWdpYy1jb21tZW50IHQKLSAgIkluc2VydCBhIG1hZ2ljIEVt YWNzICdjb2RpbmcnIGNvbW1lbnQgdXBvbiBzYXZlIGlmIHRoaXMgaXMgbm9uLW5pbC4iCisgICJJ bnNlcnQgYSBtYWdpYyBFbWFjcyAnY29kaW5nJyBjb21tZW50IHVwb24gc2F2ZSBpZiB0aGlzIGlz IG5vbi1uaWwuCitUaGUgZW5jb2Rpbmcgd2lsbCBiZSBhdXRvLWRldGVjdGVkLiAgVGhlIGZvcm1h dCBvZiB0aGUgZW5jb2RpbmcgY29tbWVudAoraXMgY3VzdG9taXphYmxlIHZpYSBgcnVieS1lbmNv ZGluZy1tYWdpYy1jb21tZW50LXN0eWxlJy4KKworV2hlbiBzZXQgdG8gYGFsd2F5cy11dGY4JyBh biB1dGYtOCBjb21tZW50IHdpbGwgYWx3YXlzIGJlIGFkZGVkLCBldmVuIGlmIGl0J3Mgbm90City ZXF1aXJlZC4iCiAgIDp0eXBlICdib29sZWFuIDpncm91cCAncnVieSkKIAogKGRlZmN1c3RvbSBy dWJ5LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQtc3R5bGUgJ3J1YnkKQEAgLTYzMywyOCArNjM4LDQ3 IEBAIGV4cGxpY2l0bHkgZGVjbGFyZWQgaW4gbWFnaWMgY29tbWVudC4iCiAgIChzZXRxLWxvY2Fs IHBhcmFncmFwaC1zZXBhcmF0ZSBwYXJhZ3JhcGgtc3RhcnQpCiAgIChzZXRxLWxvY2FsIHBhcmFn cmFwaC1pZ25vcmUtZmlsbC1wcmVmaXggdCkpCiAKKyhkZWZ1biBydWJ5LS1pbnNlcnQtY29kaW5n LWNvbW1lbnQgKGVuY29kaW5nKQorICAobGV0ICgoZW5jb2RpbmctbWFnaWMtY29tbWVudC10ZW1w bGF0ZQorICAgICAgICAgKHBjYXNlIHJ1YnktZW5jb2RpbmctbWFnaWMtY29tbWVudC1zdHlsZQor ICAgICAgICAgICAoYHJ1YnkgIiMgY29kaW5nOiAlcyIpCisgICAgICAgICAgIChgZW1hY3MgIiMg LSotIGNvZGluZzogJXMgLSotIikKKyAgICAgICAgICAgKGBjdXN0b20KKyAgICAgICAgICAgIHJ1 YnktY3VzdG9tLWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQtdGVtcGxhdGUpKSkpCisgICAgKGluc2Vy dAorICAgICAoZm9ybWF0IGVuY29kaW5nLW1hZ2ljLWNvbW1lbnQtdGVtcGxhdGUgZW5jb2Rpbmcp CisgICAgICJcbiIpKSkKKworKGRlZnVuIHJ1YnktLWRldGVjdC1lbmNvZGluZyAoKQorICAoaWYg KGVxIHJ1YnktaW5zZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQgJ2Fsd2F5cy11dGY4KQorICAg ICAgInV0Zi04IgorICAgIChsZXQgKChjb2Rpbmctc3lzdGVtCisgICAgICAgICAgIChvciBzYXZl LWJ1ZmZlci1jb2Rpbmctc3lzdGVtCisgICAgICAgICAgICAgICBidWZmZXItZmlsZS1jb2Rpbmct c3lzdGVtKSkpCisgICAgICAoaWYgY29kaW5nLXN5c3RlbQorICAgICAgICAgIChzZXRxIGNvZGlu Zy1zeXN0ZW0KKyAgICAgICAgICAgICAgICAob3IgKGNvZGluZy1zeXN0ZW0tZ2V0IGNvZGluZy1z eXN0ZW0gJ21pbWUtY2hhcnNldCkKKyAgICAgICAgICAgICAgICAgICAgKGNvZGluZy1zeXN0ZW0t Y2hhbmdlLWVvbC1jb252ZXJzaW9uIGNvZGluZy1zeXN0ZW0gbmlsKSkpKQorICAgICAgKGlmIGNv ZGluZy1zeXN0ZW0KKyAgICAgICAgICAoc3ltYm9sLW5hbWUKKyAgICAgICAgICAgKGlmIHJ1Ynkt dXNlLWVuY29kaW5nLW1hcAorICAgICAgICAgICAgICAgKGxldCAoKGVsdCAoYXNzcSBjb2Rpbmct c3lzdGVtIHJ1YnktZW5jb2RpbmctbWFwKSkpCisgICAgICAgICAgICAgICAgIChpZiBlbHQgKGNk ciBlbHQpIGNvZGluZy1zeXN0ZW0pKQorICAgICAgICAgICAgIGNvZGluZy1zeXN0ZW0pKQorICAg ICAgICAiYXNjaWktOGJpdCIpKSkpCisKKyhkZWZ1biBydWJ5LS1lbmNvZGluZy1jb21tZW50LXJl cXVpcmVkLXAgKCkKKyAgKG9yIChyZS1zZWFyY2gtZm9yd2FyZCAiW15cMC1cMTc3XSIgbmlsIHQp CisgICAgICAoZXEgcnVieS1pbnNlcnQtZW5jb2RpbmctbWFnaWMtY29tbWVudCAnYWx3YXlzLXV0 ZjgpKSkKKwogKGRlZnVuIHJ1YnktbW9kZS1zZXQtZW5jb2RpbmcgKCkKICAgIkluc2VydCBhIG1h Z2ljIGNvbW1lbnQgaGVhZGVyIHdpdGggdGhlIHByb3BlciBlbmNvZGluZyBpZiBuZWNlc3Nhcnku IgogICAoc2F2ZS1leGN1cnNpb24KICAgICAod2lkZW4pCiAgICAgKGdvdG8tY2hhciAocG9pbnQt bWluKSkKLSAgICAod2hlbiAocmUtc2VhcmNoLWZvcndhcmQgIlteXDAtXDE3N10iIG5pbCB0KQor ICAgICh3aGVuIChydWJ5LS1lbmNvZGluZy1jb21tZW50LXJlcXVpcmVkLXApCiAgICAgICAoZ290 by1jaGFyIChwb2ludC1taW4pKQotICAgICAgKGxldCAoKGNvZGluZy1zeXN0ZW0KLSAgICAgICAg ICAgICAob3Igc2F2ZS1idWZmZXItY29kaW5nLXN5c3RlbQotICAgICAgICAgICAgICAgICBidWZm ZXItZmlsZS1jb2Rpbmctc3lzdGVtKSkpCi0gICAgICAgIChpZiBjb2Rpbmctc3lzdGVtCi0gICAg ICAgICAgICAoc2V0cSBjb2Rpbmctc3lzdGVtCi0gICAgICAgICAgICAgICAgICAob3IgKGNvZGlu Zy1zeXN0ZW0tZ2V0IGNvZGluZy1zeXN0ZW0gJ21pbWUtY2hhcnNldCkKLSAgICAgICAgICAgICAg ICAgICAgICAoY29kaW5nLXN5c3RlbS1jaGFuZ2UtZW9sLWNvbnZlcnNpb24gY29kaW5nLXN5c3Rl bSBuaWwpKSkpCi0gICAgICAgIChzZXRxIGNvZGluZy1zeXN0ZW0KLSAgICAgICAgICAgICAgKGlm IGNvZGluZy1zeXN0ZW0KLSAgICAgICAgICAgICAgICAgIChzeW1ib2wtbmFtZQotICAgICAgICAg ICAgICAgICAgIChpZiBydWJ5LXVzZS1lbmNvZGluZy1tYXAKLSAgICAgICAgICAgICAgICAgICAg ICAgKGxldCAoKGVsdCAoYXNzcSBjb2Rpbmctc3lzdGVtIHJ1YnktZW5jb2RpbmctbWFwKSkpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgKGlmIGVsdCAoY2RyIGVsdCkgY29kaW5nLXN5c3RlbSkp Ci0gICAgICAgICAgICAgICAgICAgICBjb2Rpbmctc3lzdGVtKSkKLSAgICAgICAgICAgICAgICAi YXNjaWktOGJpdCIpKQorICAgICAgKGxldCAoKGNvZGluZy1zeXN0ZW0gKHJ1YnktLWRldGVjdC1l bmNvZGluZykpKQogICAgICAgICAod2hlbiBjb2Rpbmctc3lzdGVtCiAgICAgICAgICAgKGlmIChs b29raW5nLWF0ICJeIyEiKSAoYmVnaW5uaW5nLW9mLWxpbmUgMikpCiAgICAgICAgICAgKGNvbmQg KChsb29raW5nLWF0ICJcXHMgKiMuKi1cKi1cXHMgKlxcKGVuXFwpP2NvZGluZ1xccyAqOlxccyAq XFwoWy1hLXowLTlfXSpcXClcXHMgKlxcKDtcXHwtXCotXFwpIikKQEAgLTY2OSwxNSArNjkzLDcg QEAgZXhwbGljaXRseSBkZWNsYXJlZCBpbiBtYWdpYyBjb21tZW50LiIKICAgICAgICAgICAgICAg ICAgICAoaW5zZXJ0IGNvZGluZy1zeXN0ZW0pKSkKICAgICAgICAgICAgICAgICAoKGxvb2tpbmct YXQgIlxccyAqIy4qY29kaW5nXFxzICpbOj1dIikpCiAgICAgICAgICAgICAgICAgKHQgKHdoZW4g cnVieS1pbnNlcnQtZW5jb2RpbmctbWFnaWMtY29tbWVudAotICAgICAgICAgICAgICAgICAgICAg KGxldCAoKGVuY29kaW5nLW1hZ2ljLWNvbW1lbnQtdGVtcGxhdGUKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAocGNhc2UgcnVieS1lbmNvZGluZy1tYWdpYy1jb21tZW50LXN0eWxlCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoYHJ1YnkgIiMgY29kaW5nOiAlcyIpCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoYGVtYWNzICIjIC0qLSBjb2Rpbmc6ICVzIC0qLSIpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYGN1c3RvbQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJ1YnktY3VzdG9tLWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQtdGVtcGxhdGUp KSkpCi0gICAgICAgICAgICAgICAgICAgICAgIChpbnNlcnQKLSAgICAgICAgICAgICAgICAgICAg ICAgIChmb3JtYXQgZW5jb2RpbmctbWFnaWMtY29tbWVudC10ZW1wbGF0ZSBjb2Rpbmctc3lzdGVt KQotICAgICAgICAgICAgICAgICAgICAgICAgIlxuIikpKSkpCisgICAgICAgICAgICAgICAgICAg ICAocnVieS0taW5zZXJ0LWNvZGluZy1jb21tZW50IGNvZGluZy1zeXN0ZW0pKSkpCiAgICAgICAg ICAgKHdoZW4gKGJ1ZmZlci1tb2RpZmllZC1wKQogICAgICAgICAgICAgKGJhc2ljLXNhdmUtYnVm ZmVyLTEpKSkpKSkpCiAKLS0gCjEuOC40Cgo= --089e015376b6e3d49e04eb0fe44d--