From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template): Date: Fri, 22 Nov 2013 14:38:17 +0200 Message-ID: References: <6vfvqpl5gh.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b3a9a7ce5a0db04ebc34992 X-Trace: ger.gmane.org 1385123900 10705 80.91.229.3 (22 Nov 2013 12:38:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Nov 2013 12:38:20 +0000 (UTC) Cc: emacs-devel To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 22 13:38:25 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vjq09-0004W7-Fq for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 13:38:25 +0100 Original-Received: from localhost ([::1]:38343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjq08-0000zz-Ot for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 07:38:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjq05-0000z3-JQ for emacs-devel@gnu.org; Fri, 22 Nov 2013 07:38:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjq04-0000TJ-FI for emacs-devel@gnu.org; Fri, 22 Nov 2013 07:38:21 -0500 Original-Received: from mail-oa0-x234.google.com ([2607:f8b0:4003:c02::234]:56492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjq02-0000T1-Jh; Fri, 22 Nov 2013 07:38:18 -0500 Original-Received: by mail-oa0-f52.google.com with SMTP id h16so1280295oag.11 for ; Fri, 22 Nov 2013 04:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=M/UW7J9LwywnSAYzctBroLR0dF1zaUORh8ikgtifMwQ=; b=FwGFUXo4shbaDMRhrW9cWWyTAqSgb9cMSqCEMKy51pEvm2/ItGVx9sxGhjWCKFTBFC YrMJY0CXZMS3Jxx5RU/fYl6+8Bil1n+/qzRn7ifk8EyxCUgedIllIA5B+QP/TzEbrMqc cfzZEAfbp8h1f6K/AQOv0MXlLdlX2QuJbp+6Bn9WEoAtRbPqhDBzNA7/3wlM5roDYfHQ 9SmSJUDJWK8Mbgt498IfJX9phoTUeAsa8TiSEbZqGNABBjyx2+ZK00F+p8o+sq+vLhlW fuc8xrSvZ3zd5ERTWQcUN3WpD4jDSCdpxcLPyKi9dzLdiRwLF5d5OhGlrzQPuGmVes1F Eprg== X-Received: by 10.60.117.225 with SMTP id kh1mr10455119oeb.15.1385123897775; Fri, 22 Nov 2013 04:38:17 -0800 (PST) Original-Received: by 10.76.21.207 with HTTP; Fri, 22 Nov 2013 04:38:17 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: lzCRWPBHUa6XNrClodW45cvzGMc X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165553 Archived-At: --047d7b3a9a7ce5a0db04ebc34992 Content-Type: text/plain; charset=UTF-8 Done. I saw you had already fixed the test expectation. Thanks for the feedback! On 22 November 2013 01:17, Glenn Morris wrote: > Glenn Morris wrote: > > > Then it should definitely have a :version tag. :) > > And to further the pedantry, the first line of the doc-string should be > a complete sentence. :) > --047d7b3a9a7ce5a0db04ebc34992 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Done. I saw you had already fixed the test expectation. Th= anks for the feedback!


On 22 November 2013 01:17, Glenn Morris = <rgm@gnu.org> wrote:
Glenn Morris wrote:

> Then it should definitely have a :version tag. :)

And to further the pedantry, the first line of the doc-string should = be
a complete sentence. :)

--047d7b3a9a7ce5a0db04ebc34992--