Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default.

[Bozhidar Batsov <bozhidar@batsov.com>]

[-- Attachment #1: Type: text/plain, Size: 2123 bytes --]

On 13 November 2013 21:19, Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 13.11.2013 16:36, Bozhidar Batsov wrote:
>
>> I've attached here a second patch that adds support for always inserting
>> a utf-8 encoding comment. I've also simplified a bit the code of
>> `ruby-mode-set-encoding' (by breaking it into several functions) as it
>> was quite convoluted.
>>
>
> Looks good to me, with a couple of notes.
>
> 1. ruby-insert-encoding-magic-comment docstring width exceeds the default
> value of emacs-lisp-docstring-fill-column. Maybe you'd like to refill it.
>

Sure.


>
> 2. I'd swap the `or' clauses in ruby--encoding-comment-required-p. The
> second one, though rare, should be much faster.
>

Good point.


>
> That aside, have you managed to run the test suite?
>

Yeah, the tests started working after I updated my Emacs. I guess I had
installed a bad build. One test is failing, though:

f ruby-interpolation-inside-percent-literal-with-paren
    (ert-test-failed
     ((should
       (eq face
           (get-text-property pos 'face)))
      :form
      (eq font-lock-string-face nil)
      :value nil))


Btw, there also seems to be some bug in the output of ert - the "f" was
printed in the same colour as the passing tests. Pretty sure it shouldn't
be this way. Maybe I should report this.


>
>  On 7 November 2013 13:06, Dmitry Gutov <dgutov@yandex.ru
>> <mailto:dgutov@yandex.ru>> wrote:
>>
>>     On 07.11.2013 12:23, Bozhidar Batsov wrote:
>>
>>         Btw, Dimitry - please add some info the ruby-mode.el about
>>         running the
>>         tests. I tried evaluating and running them manually, but this
>>         crashed my
>>         Emacs (the tests hogged my CPU completely and I had to kill
>> Emacs).
>>         Maybe there is something wrong with them right now, or perhaps
>> they
>>         should invoked in some manner I'm not aware of.
>>
>>
>>     I'm not aware of any problems running the tests, looks like a bug.
>>     Weren't you able to stop the freezing with C-g, at least?
>>
>>     I just open ruby-mode-tests.el, M-x eval-buffer, M-x ert RET.
>>     They run fine.
>>
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 4016 bytes --]