From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Supporting multiline Package-Requires header Date: Wed, 12 Aug 2015 08:34:00 +0300 Message-ID: References: <87si7rjqmp.fsf@newcastle.ac.uk> <87fv3rjogj.fsf@newcastle.ac.uk> <87fv3po7ss.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0115e79edf2944051d1690b0 X-Trace: ger.gmane.org 1439357661 8073 80.91.229.3 (12 Aug 2015 05:34:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Aug 2015 05:34:21 +0000 (UTC) Cc: Kaushal , Emacs developers , Phillip Lord To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 12 07:34:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPOg8-0004A5-1N for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 07:34:20 +0200 Original-Received: from localhost ([::1]:36971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPOg6-000881-R3 for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 01:34:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPOfq-00087t-QG for emacs-devel@gnu.org; Wed, 12 Aug 2015 01:34:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPOfp-000740-QI for emacs-devel@gnu.org; Wed, 12 Aug 2015 01:34:02 -0400 Original-Received: from mail-ig0-x234.google.com ([2607:f8b0:4001:c05::234]:38018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPOfp-00073p-Kg for emacs-devel@gnu.org; Wed, 12 Aug 2015 01:34:01 -0400 Original-Received: by igfj19 with SMTP id j19so6755915igf.1 for ; Tue, 11 Aug 2015 22:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=4kD5ZMF3DJN+adGTPaD3kqI1kjF4fkv22ohUogn9xd4=; b=LkRXDR2RGv9sINJ52lZPpy60W3g56DufwyaUPF2lHubOZtO2W2InUZhV1EjNJpoKn7 7jYEs0nz09E9V1Fezo6fYj1htL8YMKM/TqbiUAAWxIDx03aUHuVVV0pljlL+vTiRBFLt R2AhelqnJyLGediW5DGcsCjYNpHECcKZKBzkV6pmWjCUd9hxSuqxlgsjWK6/A9EEowe7 G7yCvsUaSwAgUnkv9mSr2Dc+NyBKYzIj73ulrnO2erVzDQNF5pmliU02Um4fQ4VZYvmx 8wiuHEwWhIydriAVLBoCXc1BG6qIFEvRu7Zg3ZhtGfgAHYglzFp/onFepBf7CvlYUF0w bAGg== X-Received: by 10.50.78.68 with SMTP id z4mr21007691igw.51.1439357640581; Tue, 11 Aug 2015 22:34:00 -0700 (PDT) Original-Received: by 10.107.41.205 with HTTP; Tue, 11 Aug 2015 22:34:00 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: odeqzpEauxhKDiDbHVyMWBLKFLY X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c05::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188744 Archived-At: --089e0115e79edf2944051d1690b0 Content-Type: text/plain; charset=UTF-8 I agree with Artur on both points. On 12 August 2015 at 00:48, Artur Malabarba wrote: > >>> What is the failure behaviour of package.el for this at the moment? > >> > >> Package.el will signal an error during installation if it's not a > >> valid sexp. The error itself will depend on what the problem is. > >> Here's what you get if you miss a closing paren for instance: > >> package-read-from-string: End of file during parsing > > > > My issue with this is that, iff I see this error, my first port of call > > is going to be check-parens, and generally look for unbalanced parens in > > the relevant file. And there are not going to be any, because in the > > file, there is no invalid sexp. There is a commented out, pseudo sexp. > > [...] > > Just my thoughts, I will leave the issue in your hands from there. > > Thanks for the thoughts. I do think package.el could do better error > reporting in these situations (and I might take that up too). > That said, I don't think the proposed patch makes this situation any worse. > > --089e0115e79edf2944051d1690b0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I agree with Artur on both points.

On 12 August 2015 at 00:48, Artur M= alabarba <bruce.connor.am@gmail.com> wrote:
>>> What is the failure= behaviour of package.el for this at the moment?
>>
>> Package.el will signal an error during installation if it's no= t a
>> valid sexp. The error itself will depend on what the problem is. >> Here's what you get if you miss a closing paren for instance:<= br> >>=C2=A0 =C2=A0 =C2=A0package-read-from-string: End of file during pa= rsing
>
> My issue with this is that, iff I see this error, my first port of cal= l
> is going to be check-parens, and generally look for unbalanced parens = in
> the relevant file. And there are not going to be any, because in the > file, there is no invalid sexp. There is a commented out, pseudo sexp.=
> [...]
> Just my thoughts, I will leave the issue in your hand= s from there.

Thanks for the thoughts. I do think package.el could do better error=
reporting in these situations (and I might take that up too).
That said, I don't think the proposed patch makes this situation any wo= rse.


--089e0115e79edf2944051d1690b0--