all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bozhidar Batsov <bozhidar@batsov.com>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: Kaushal <kaushal.modi@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>,
	Phillip Lord <phillip.lord@russet.org.uk>
Subject: Re: Supporting multiline Package-Requires header
Date: Wed, 12 Aug 2015 08:34:00 +0300	[thread overview]
Message-ID: <CAM9Zgm0_tTn1v1k_vw1scS9Am9grM9x_7J8rUgC_Po+35O09Tg@mail.gmail.com> (raw)
In-Reply-To: <CAAdUY-JQ8cc=TPpD6PA7jXvgUieBF3WN0Vn2hQmcdnOaTHkoWQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

I agree with Artur on both points.

On 12 August 2015 at 00:48, Artur Malabarba <bruce.connor.am@gmail.com>
wrote:

> >>> What is the failure behaviour of package.el for this at the moment?
> >>
> >> Package.el will signal an error during installation if it's not a
> >> valid sexp. The error itself will depend on what the problem is.
> >> Here's what you get if you miss a closing paren for instance:
> >>     package-read-from-string: End of file during parsing
> >
> > My issue with this is that, iff I see this error, my first port of call
> > is going to be check-parens, and generally look for unbalanced parens in
> > the relevant file. And there are not going to be any, because in the
> > file, there is no invalid sexp. There is a commented out, pseudo sexp.
> > [...]
> > Just my thoughts, I will leave the issue in your hands from there.
>
> Thanks for the thoughts. I do think package.el could do better error
> reporting in these situations (and I might take that up too).
> That said, I don't think the proposed patch makes this situation any worse.
>
>

[-- Attachment #2: Type: text/html, Size: 1543 bytes --]

  reply	other threads:[~2015-08-12  5:34 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 11:12 Supporting multiline Package-Requires header Artur Malabarba
2015-08-10 11:42 ` Kaushal
2015-08-10 11:59   ` Artur Malabarba
2015-08-10 12:05   ` Phillip Lord
2015-08-10 12:28     ` Artur Malabarba
2015-08-10 12:51       ` Phillip Lord
2015-08-10 13:08         ` Artur Malabarba
2015-08-10 13:54           ` Bozhidar Batsov
2015-08-10 15:22             ` Artur Malabarba
2015-08-11 21:05           ` Phillip Lord
2015-08-11 21:48             ` Artur Malabarba
2015-08-12  5:34               ` Bozhidar Batsov [this message]
2015-08-12 14:09               ` Stefan Monnier
2015-08-12 14:23                 ` Artur Malabarba
2015-08-12 17:18                   ` Stefan Monnier
2015-08-12 20:10                     ` Artur Malabarba
2015-08-13 18:13                     ` Artur Malabarba
2015-08-13 20:44                       ` Stefan Monnier
2015-08-13 22:37                         ` Rasmus
2015-08-13 23:01                           ` Artur Malabarba
2015-08-14  0:12                             ` Rasmus
2015-08-14  1:42                           ` Stefan Monnier
2015-08-17 18:45                             ` Achim Gratz
2015-08-18 15:56                               ` Stefan Monnier
2015-08-18 18:00                                 ` Achim Gratz
2015-08-19 17:14                                   ` Stefan Monnier
2015-08-23  6:33                         ` Achim Gratz
2015-08-23  9:17                           ` Artur Malabarba
2015-08-23  9:37                             ` Achim Gratz
2015-08-23 12:03                               ` Artur Malabarba
2015-08-23 22:17                               ` Stefan Monnier
2015-08-23 22:12                             ` Stefan Monnier
2015-08-23 23:32                               ` Artur Malabarba
2015-08-23 22:16                           ` Stefan Monnier
2015-08-24  6:56                             ` Achim Gratz
2015-08-24 19:17                               ` Stefan Monnier
2015-08-24 19:32                                 ` Achim Gratz
2015-08-24 22:51                                   ` Artur Malabarba
2015-08-25  5:44                                     ` Achim Gratz
2015-08-10 14:26 ` Thierry Volpiatto
2015-08-10 15:18   ` Artur Malabarba
2015-08-10 15:38     ` Thierry Volpiatto
2015-08-10 15:53       ` Artur Malabarba
2015-08-10 16:33         ` Thierry Volpiatto
2015-08-10 15:40     ` Nicolas Richard
2015-08-10 15:49       ` Artur Malabarba
2015-08-11  8:44         ` Nicolas Richard
2015-08-11  9:28           ` Artur Malabarba
2015-08-11  9:33             ` Nicolas Richard
2015-08-10 16:34       ` Thierry Volpiatto
2015-08-10 21:49   ` Phillip Lord
2015-08-11  9:24     ` Artur Malabarba
2015-08-10 22:05   ` Stefan Monnier
2015-08-11  8:56     ` Thierry Volpiatto
2015-08-11 15:55       ` Stefan Monnier
2015-08-10 22:01 ` Stefan Monnier
2015-08-11  9:29   ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM9Zgm0_tTn1v1k_vw1scS9Am9grM9x_7J8rUgC_Po+35O09Tg@mail.gmail.com \
    --to=bozhidar@batsov.com \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.