From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gustavo Barros Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sun, 20 Nov 2022 22:45:35 -0300 Message-ID: References: <66176.1668992898@alto> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23891"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 58721@debbugs.gnu.org To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 02:46:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owvt3-000625-IR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 02:46:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owvsq-00058l-5d; Sun, 20 Nov 2022 20:46:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owvsp-00057o-2V for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 20:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owvso-0007fU-Qh for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 20:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owvso-0002jE-95 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 20:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gustavo Barros Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 01:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166899515910478 (code B ref 58721); Mon, 21 Nov 2022 01:46:02 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 21 Nov 2022 01:45:59 +0000 Original-Received: from localhost ([127.0.0.1]:44957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owvsk-0002iv-M6 for submit@debbugs.gnu.org; Sun, 20 Nov 2022 20:45:59 -0500 Original-Received: from mail-pf1-f171.google.com ([209.85.210.171]:34457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owvsf-0002ie-5r for 58721@debbugs.gnu.org; Sun, 20 Nov 2022 20:45:57 -0500 Original-Received: by mail-pf1-f171.google.com with SMTP id z26so10026621pff.1 for <58721@debbugs.gnu.org>; Sun, 20 Nov 2022 17:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4shNOVNK9lpRBxxiGpP5WGi7PuNLxQY95+f++BqnYag=; b=Xy5O7ZKcghtyrT5NNcpeP/TaAJ4TW8Hde7zYkBscLT0uJy28KoH11L9JWMYnQGdyPb KXo3bMtyhSEko5Pja9boZdEilFi+VtBW4UwGlJPFMaycKl3nSKz4hzAvHqnfMCo6YV8T KZxfvYELSGYx4LLL37GOodHNtLfzP93xj90o0apvWMoUOFrkAjb7ES2X/sdnIWaV90nM TX6GzDmITqVUXkxYzfo2FhXi4pn5ZEyW7SiTSr9pgpjTlcE7mZ82coVxJ0cv9mGj74Qk rsl295102f3xV8UeFagDw8l/OlyT/8V+tjEM/j34liJEWBUv26Rs6nLmEYEdhPCYnz88 I5cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4shNOVNK9lpRBxxiGpP5WGi7PuNLxQY95+f++BqnYag=; b=0Xy8+quf0LzzsaFJi2Ho4g1eNmLHbCt81Qd5k5uHDOOauXPVd+fkgcoLm2lakKc6Y7 rV/FHE4IcJ22H74UBflmz7PXd1v0QRuMez5PxfMot3Z+7x1p3PJMLlAysAqFFD0qTw4a 6epFjVkRUPH1NvcbVppJTn9o0FG8JCOrIsSbUWImcZ6ZQQ+NHMpBHxzw7INWaCdlDrBU itLiGWvhF8TGdigvKWC/L88eoDD1Dmf54gzwGAYUublR7Ae7UYOM/gnsgsFmZxmx/iQJ mQ0WfQmd2nX11fmLkfOQMY2A7obVmxmKCsyJ/rWyy8HHQInBe+0sGYv7RdxfCjERBdbl xsCA== X-Gm-Message-State: ANoB5pndr8jGtWZO9eQgjWZgyawIS8ECt7mboOi7G9HrociZUIMxB7IG kUfM1P6ubCC7xrLUTgYFCAqZKzdeW9joVOJhVMJriUN0 X-Google-Smtp-Source: AA0mqf56uCf+fQM3HaazdH2UoVJAWyWxZNJS2haPDC91R8M7O2Qdp+TEiKvY/4ghB14TLh3lpvMd+QE60lno6lkkRF0= X-Received: by 2002:a63:d403:0:b0:470:1a94:4c0 with SMTP id a3-20020a63d403000000b004701a9404c0mr2767600pgh.555.1668995147190; Sun, 20 Nov 2022 17:45:47 -0800 (PST) In-Reply-To: <66176.1668992898@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248495 Archived-At: Hi Mike, On Sun, 20 Nov 2022 at 22:08, Mike Kupfer wrote: > Yes, I tried a few graphical file browsers (Thunar, Caja, and Dolphin), > and they all move the symlink, not the target, to Trash. > > After getting my test setup straightened out, I think I have a fix for > the symlink issue and for the issue that Gustavo originally reported > (cross-filesystem trashing fails when there's already a directory with > the same name in Trash). > > I've committed these fixes separately; see attached. Gustavo, can you > try these out and make sure they handle your use case(s)? Thank you for seeing to this. I've tested the patches, and I'm glad to report `move-file-to-trash` works as expected across file systems. I've also tested symlinks, which work as expected as well. LGTM. (Tests made with 28.2, which is what I have here, and also the version from which the bug was initially filed). Cheers! Gustavo.