all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Gauthier Östervall" <gauthier@ostervall.se>
To: Alan Mackenzie <acm@muc.de>
Cc: 15207@debbugs.gnu.org
Subject: bug#15207: 24.2; C Highlight colors around CV-modifiers
Date: Wed, 25 Sep 2013 17:42:21 +0200	[thread overview]
Message-ID: <CAM8gEgiiRNFb79wKUX_83TE=7brynpWp_63hRcZAsnTD20nk5w@mail.gmail.com> (raw)
In-Reply-To: <20130901091027.GA2959@acm.acm>

Hi, sorry for the very late reply.

On Sun, Sep 1, 2013 at 11:10 AM, Alan Mackenzie <acm@muc.de> wrote:
> Bug #15211 seems to be a duplicate of this bug.  It's amazing how a bug
> like this can remain undetected for over a decade, then suddenly two
> people report it within a few hours of eachother.

It is indeed amazing! I am happy to be the first of two :)

> Would you please try out the patch from #15211, and let me know whether
> it fixes the bug, doesn't quite fix it, or there are unwanted side
> effects.  Here it is again:
>
>
> diff -r 45df171f9859 cc-engine.el
> --- a/cc-engine.el      Sat Aug 31 11:09:30 2013 +0000
> +++ b/cc-engine.el      Sat Aug 31 20:32:22 2013 +0000
> @@ -7440,7 +7440,8 @@
>         ;; interactive refontification.
>         (c-put-c-type-property (point) 'c-decl-arg-start))
>
> -      (when (and c-record-type-identifiers at-type (not (eq at-type t)))
> +      (when (and c-record-type-identifiers at-type ;; (not (eq at-type t))
> +                )
>         (let ((c-promote-possible-types t))
>           (save-excursion
>             (goto-char type-start)

This is working, thank you. However (and sorry for telling you after
you closed the bug), this still is not:

    uint8_t *a = (uint8_t *) b;
    uint8_t *c = (const uint8_t *) d;
    uint8_t *e = (uint8_t const *) f;

The erroneous behavior is still present in casts.

I applied your change to the part that handles the cast, which solved
the problem.
I am sure you know where the cast handling is, otherwise search for
"Handle the cast". The code is identical, located 20 lines earlier in
version 24.3.





       reply	other threads:[~2013-09-25 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130901091027.GA2959@acm.acm>
2013-09-25 15:42 ` Gauthier Östervall [this message]
2013-08-29  8:50 bug#15207: 24.2; C Highlight colors around CV-modifiers Gauthier Östervall
2013-09-01  9:10 ` Alan Mackenzie
2013-09-18 20:59 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM8gEgiiRNFb79wKUX_83TE=7brynpWp_63hRcZAsnTD20nk5w@mail.gmail.com' \
    --to=gauthier@ostervall.se \
    --cc=15207@debbugs.gnu.org \
    --cc=acm@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.