Re: sending function arguments to recursive function calls

["Gauthier Östervall" <gauthier@ostervall.se>]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Wed, May 8, 2013 at 2:21 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> When lexical-binding is t, they're very good roomates already.
> Hopefully with time, the "lexical-binding = nil" case can be dropped.

Does this imply that if I want to give for example window.el
lexical-binding (I do have an ulterior motive), no one would mind
having it that way?

> [...]  But converting existing dynamically scoped code to lexical scoping
> is usually pretty easy: set lexical-binding to t at the top of the file,
> then byte-compile it, then fix the warnings, and you should be good to go.
>
> Sometimes there's some extra tricks undetected by the simple checks
> performed by the byte-compiler, so it doesn't always work as smoothly,
> but in most cases it's really a straightforward process.

I have tried to do just that to window.el. It seemed indeed
straightforward to me, but I would greatly appreciate feedback on the
change. I really just added the lexical-binding at the top, and
removed seemingly unused variables. I don't know why these variables
were left (were they really unused?), but byte-compiling gives no
warning, at least.

See attached bundle.

[-- Attachment #2: make-window-lexical.txt --]
[-- Type: text/plain, Size: 4466 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: gauthier@ostervall.se-20130512130720-hpthrwn048nrj4ao
# target_branch: file:///media/sf_prog/emacs/trunk/
# testament_sha1: 288aa595c17d0d7923aa72d1cbe25a3a3b081380
# timestamp: 2013-05-12 15:09:54 +0200
# base_revision_id: rgm@gnu.org-20130430101735-ccy06l3ndx4vrj18
# 
# Begin patch
=== modified file 'lisp/window.el' (properties changed: -x to +x)
--- lisp/window.el	2013-04-13 14:37:20 +0000
+++ lisp/window.el	2013-05-12 13:07:20 +0000
@@ -1,4 +1,4 @@
-;;; window.el --- GNU Emacs window commands aside from those written in C
+;;; window.el --- GNU Emacs window commands aside from those written in C  -*- lexical-binding: t -*-
 
 ;; Copyright (C) 1985, 1989, 1992-1994, 2000-2013 Free Software
 ;; Foundation, Inc.
@@ -685,11 +685,9 @@
 This function may be called only if no window on SIDE exists yet.
 The new window automatically becomes the \"major\" side window on
 SIDE.  Return the new window, nil if its creation window failed."
-  (let* ((root (frame-root-window))
-	 (left-or-right (memq side '(left right)))
+  (let* ((left-or-right (memq side '(left right)))
 	 (major (window--major-side-window side))
-	 (selected-window (selected-window))
-	 (on-side (cond
+         (on-side (cond
 		   ((eq side 'top) 'above)
 		   ((eq side 'bottom) 'below)
 		   (t side)))
@@ -698,8 +696,7 @@
 	 ;; parent window unless needed.
 	 (window-combination-resize 'side)
 	 (window-combination-limit nil)
-	 (new (split-window major nil on-side))
-	 fun)
+         (new (split-window major nil on-side)))
     (when new
       ;; Initialize `window-side' parameter of new window to SIDE.
       (set-window-parameter new 'window-side side)
@@ -749,8 +746,7 @@
   A positive value means use a slot following (that is, below or
   on the right of) the middle slot.  The default is zero."
   (let ((side (or (cdr (assq 'side alist)) 'bottom))
-	(slot (or (cdr (assq 'slot alist)) 0))
-	new)
+        (slot (or (cdr (assq 'slot alist)) 0)))
     (cond
      ((not (memq side '(top bottom left right)))
       (error "Invalid side %s specified" side))
@@ -776,9 +772,8 @@
 		  ((eq side 'right) 2)
 		  ((eq side 'bottom) 3))
 		 window-sides-slots))
-	   (selected-window (selected-window))
-	   window this-window this-slot prev-window next-window
-	   best-window best-slot abs-slot new-window)
+           window this-window this-slot prev-window next-window
+           best-window best-slot abs-slot)
 
       (cond
        ((and (numberp max-slots) (<= max-slots 0))
@@ -5713,7 +5708,7 @@
 		   0)
 		  (display-buffer-reuse-frames 0)
 		  (t (last-nonminibuffer-frame))))
-	 entry best-window second-best-window window)
+         best-window second-best-window window)
     ;; Scan windows whether they have shown the buffer recently.
     (catch 'best
       (dolist (window (window-list-1 (frame-first-window) 'nomini frames))

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWedecm4AAeVfgAaQUPP//1qB
kgC////wUAQ+e2A7zVroA0DQpB6jTEHqZPUBppkHlAAAAjSJpqep5TyIyAAAAAAADRT0TRgiahmk
YTE2hGATTJkxCKfqmSPU2SB6mJk00ABgIDTQ0CSIRqbSMIEwmFPRqPUZGkekyYaiIvrvtah8WXqt
OO3Qj96nDbPuxEtdU906bq4tuhKEs4gdL3ef37/wQnX+TOz7O/0Qafx9gM89hRR0vAfQOQg7wAyg
4JxuiNaisWWRddptKfJkoQEuAygQPDyORisUUT0DoF05YXlz1NgQyLIRNcgaDacUxRzIAgfsIwTm
ah2/WBLepi/eRjuqOyiLZP9eKflzkQ3jL+M7WPkJaUe2ZVJYysv3/OS97MyL3f4JNz5wBkRcQyqi
O0QirBOKxMKwu7MtcyDZE8XhRBWygx3yPHq6jgWfG/BWKMtwp5bhxGIvWM1l/SjguNPlVdRenH2W
UL8xmz3mirRS1LomYRirBMEyemsm2rUZj6YZrQz2HdE34ZIYXJ1kEGcZYHsY5FSVe6VIKXz2qWqL
6mJ5FPJLfBR0aiupRoq4LJlkQFhBoKZTYK8q9rTNo5rRnWYhSYKzadOUUt4riqllFEz1PlC2xxkp
oUYc8KOARMoyYoFeSJSy2qBI6ehPM0eJguCEggJmlMjHL9nrpkpbFA+eHqpAw4uqBIYroQmRI6JV
XAgvrgGKKzPU1YkNr3yW6XrLHJOmrknkphXNvQ/s1t20U66yDN0/x49F0SnUAY/XIYy9JF9VTxYQ
1a0BgVj08KsfptNrN1QCsZMm4gXUqrbci9vDMidnrWtXNL38+eGo8LPz9verze164INs2GyHpYJ8
nC2txyPW5RtC0A9D7r8lFyxq1FQCYgsyJ0nAkIMzS8rlBcdJ5NgSdxQtI06niPx5vfHrbZSzX1ZK
VcCiZatqSvKIOY+SCi2fFIReuZyF99h1fKD7JJG4LJlDhw3Qglr5cogeumq2oGhpohusE81LgZeW
/6+C8NUR1G4/fO7Mx1bIPDBN9T4DRnmRYVr+B1NgaJ7NSR5CYXYxQOYUOybGv/laD8gJ7Ssr2KyR
rX3DgdgC6w89miN4XHQOaw1yhBBu2GoM5Lc6koJOHBTCEAkYteO2gv4Wb2QY/O1FvargvWmfQyvt
uugcaqGNdQ9Kx2knbaJqmo7khIf6KHlbVUubzXyFYiTKi0QXPKLIsHbcSttdQO0iX3n0C9UWuC5e
KW1Gnu6AG98drMnJa5drdc52iqydVSlG7mcQwc4Its5WlSgpV9NNXDwWUVWRadWTLKTAYidX749+
LPZof+T2pS1pymOSJM5uIonFA7avZlGmEGRIBN/QAQCqIetAnNkpmqUfBqMTlExi97swFDvkA67h
Ty8riYUCDK03J1pupXHbQDD0oBX5rNNVBUoOyS1lTB9mddvNoWC4qV69zKwGYJK5Tuzkv/F3JFOF
CQ515ybg