bug#17912: inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

bug#17912: inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

[Damian Nadales]

Hello,

Whenever I start octave-mode from emacs I got the following error message:
   inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

Running it for a second time makes the error disappear.

Furthermore, the following error appears randomly (to me at least)
when using the Octave buffer:
   comint-send-input: Wrong type argument: number-or-marker-p, "100000000000"

The constant 100000000000 is the same I use to set the history size of
octave in my pam_environment:
   OCTAVE_HISTSIZE DEFAULT=100000000000

But I don't know how is this related to the error I got.

What could be happening?

bug#17912: inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

[Damian Nadales]

I forgot to add the system info:

Emacs  : GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.7)
 of 2014-03-07 on lamiak, modified by Debian
Package: Emacs version 24.3.1

current state:
==============
(setq
 octave-blink-matching-block t
 octave-block-offset 2
 octave-comment-char 35
 octave-continuation-offset 4
 octave-continuation-string "\\"
 octave-send-echo-input t
 octave-send-line-auto-forward t
 octave-send-show-buffer t
 )

On Thu, Jul 3, 2014 at 11:53 AM, Damian Nadales
<damian.nadales@gmail.com> wrote:
> Hello,
>
> Whenever I start octave-mode from emacs I got the following error message:
>    inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"
>
> Running it for a second time makes the error disappear.
>
> Furthermore, the following error appears randomly (to me at least)
> when using the Octave buffer:
>    comint-send-input: Wrong type argument: number-or-marker-p, "100000000000"
>
> The constant 100000000000 is the same I use to set the history size of
> octave in my pam_environment:
>    OCTAVE_HISTSIZE DEFAULT=100000000000
>
> But I don't know how is this related to the error I got.
>
> What could be happening?

bug#17912: inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

[Stefan Monnier]

Version:24.4

>> Whenever I start octave-mode from emacs I got the following error message:
>> inferior-octave-mode: Wrong type argument: number-or-marker-p, "100000000000"

Apparently you're the only use who sets OCTAVE_HISTSIZE ;-)

I installed the patch below which should hopefully fix this problem,


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2014-07-03 23:48:24 +0000
+++ lisp/ChangeLog	2014-07-04 01:34:57 +0000
@@ -1,3 +1,8 @@
+2014-07-04  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+	* progmodes/octave.el (inferior-octave-mode):
+	Set comint-input-ring-size to a number (bug#17912).
+
 2014-07-03  Juri Linkov  <juri@jurta.org>
 
 	* desktop.el (desktop-minor-mode-table): Add `defining-kbd-macro'

=== modified file 'lisp/progmodes/octave.el'
--- lisp/progmodes/octave.el	2014-04-12 04:07:53 +0000
+++ lisp/progmodes/octave.el	2014-07-04 01:34:11 +0000
@@ -747,9 +747,10 @@
   (setq-local info-lookup-mode 'octave-mode)
   (setq-local eldoc-documentation-function 'octave-eldoc-function)
 
-  (setq comint-input-ring-file-name
-        (or (getenv "OCTAVE_HISTFILE") "~/.octave_hist")
-        comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024))
+  (setq-local comint-input-ring-file-name
+              (or (getenv "OCTAVE_HISTFILE") "~/.octave_hist"))
+  (setq-local comint-input-ring-size
+              (string-to-number (or (getenv "OCTAVE_HISTSIZE") "1024")))
   (comint-read-input-ring t)
   (setq-local comint-dynamic-complete-functions
               inferior-octave-dynamic-complete-functions)