From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Risto Mononen Newsgroups: gmane.emacs.bugs Subject: bug#10515: 23.3; vc-rcs-create-tag Date: Sun, 15 Jan 2012 19:24:31 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec51d2a3acb4b8404b69460e1 X-Trace: dough.gmane.org 1326654410 3797 80.91.229.12 (15 Jan 2012 19:06:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 15 Jan 2012 19:06:50 +0000 (UTC) To: 10515@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 15 20:06:45 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RmVPg-0006NX-Hf for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jan 2012 20:06:45 +0100 Original-Received: from localhost ([::1]:45169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmVPf-0000eo-Ps for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jan 2012 14:06:43 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:56490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmVPD-0000Xa-D3 for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 14:06:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmVPB-00016Z-Dr for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 14:06:15 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmVPB-00016V-At for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 14:06:13 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RmVPz-0005jV-3c for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 14:07:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Risto Mononen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jan 2012 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10515 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.132665441221994 (code B ref -1); Sun, 15 Jan 2012 19:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2012 19:06:52 +0000 Original-Received: from localhost ([127.0.0.1]:58882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmVPn-0005ig-Jz for submit@debbugs.gnu.org; Sun, 15 Jan 2012 14:06:52 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:50537) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmTqA-0003Ay-RE for submit@debbugs.gnu.org; Sun, 15 Jan 2012 12:26:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmTpL-0005I0-ML for submit@debbugs.gnu.org; Sun, 15 Jan 2012 12:25:09 -0500 Original-Received: from lists.gnu.org ([140.186.70.17]:56401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmTpL-0005Hw-KN for submit@debbugs.gnu.org; Sun, 15 Jan 2012 12:25:07 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:60664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmTpJ-00088x-R7 for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 12:25:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmTpH-0005E8-4k for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 12:25:05 -0500 Original-Received: from mail-vx0-f169.google.com ([209.85.220.169]:54575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmTpH-0005E2-0f for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 12:25:03 -0500 Original-Received: by vcbf1 with SMTP id f1so1558048vcb.0 for ; Sun, 15 Jan 2012 09:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type; bh=mT4hvShtgmz5pwjNZnYqnAxYeyqgrup9/2CyO+bTISY=; b=MotVBr4GWDqUpqHIOxEld3kJAR+k9SHHRuu3V23Ng9d0GXEZDBiQ1LHYQ7XpcfOd/9 yOUMV/NZIMUkRDBFthWLr8liKB+p/F/47uBFi9AOyxGvL6Hs+TB8KXkVIDTs680O+bZK nuLxbpYx9VqOHcrxg/OFnX9rTbDeAK89FCg5I= Original-Received: by 10.52.38.66 with SMTP id e2mr4271032vdk.25.1326648302193; Sun, 15 Jan 2012 09:25:02 -0800 (PST) Original-Received: by 10.52.96.37 with HTTP; Sun, 15 Jan 2012 09:24:31 -0800 (PST) X-Google-Sender-Auth: EnYC0kTsMeJauO0_wmFW6ZZzOa0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Mailman-Approved-At: Sun, 15 Jan 2012 14:06:50 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sun, 15 Jan 2012 14:06:41 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55770 Archived-At: --bcaec51d2a3acb4b8404b69460e1 Content-Type: text/plain; charset=ISO-8859-1 Hi, Creating tag with *C-v s* fails since vc-rcs-create-tag gets the forbidden branchp parameter. My quick fix was to be liberal on what is received and just give the notification message rather than error. Please see the diff below. BR, Risto Mononen *** vc-rcs.el 2012/01/15 16:56:35 1.1 --- vc-rcs.el 2012/01/15 17:05:08 1.2 *************** *** 813,819 **** (defun vc-rcs-create-tag (backend dir name branchp) (when branchp ! (error "RCS backend %s does not support module branches" backend)) (let ((result (vc-tag-precondition dir))) (if (stringp result) (error "File %s is not up-to-date" result) --- 813,819 ---- (defun vc-rcs-create-tag (backend dir name branchp) (when branchp ! (message "RCS backend %s does not support module branches" backend)) (let ((result (vc-tag-precondition dir))) (if (stringp result) (error "File %s is not up-to-date" result) In GNU Emacs 23.3.1 (i686-pc-linux-gnu, GTK+ Version 2.24.5) of 2011-08-14 on rothera, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.11004000 configured using `configure '--build' 'i686-linux-gnu' '--build' 'i686-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.3/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.3/leim' '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i686-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: en_US.UTF-8 value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: en_US.UTF-8 value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t show-paren-mode: t recentf-mode: t dynamic-completion-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: C-x C-v C-k C-x 1 s n n n n Z y f y e s C-x v = C-x h M-w C-x o C-x o C-s m e s C-w C-w C-w C-w C-x o C-s C-s C-s C-p C-x o M-b M-b C-s C-w C-w C-w C-x o C-s C-s C-x v l n f C-s C-s C-x k RET p f C-s C-s C-x o C-x v + C-x v = C-u C-x v = C-x h M-w C-x 0 Recent messages: Checking out /usr/share/emacs/23.3/lisp/vc-rcs.el.~1.2~...done Mark saved where search started (No files need saving) Checking out /usr/share/emacs/23.3/lisp/vc-rcs.el...done Finding changes in /usr/share/emacs/23.3/lisp/vc-rcs.el... No changes between working revision and workfile Finding changes in /usr/share/emacs/23.3/lisp/vc-rcs.el...done Mark set [2 times] Saved text until "ror "File %s is not up-to-date" result) " Load-path shadows: /usr/share/emacs/23.3/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs23/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/23.3/lisp/textmodes/flyspell /usr/share/emacs23/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/23.3/lisp/textmodes/ispell Features: (shadow sort mail-extr message sendmail ecomplete rfc822 mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils mailheader canlock sha1 hex-util hashcash mail-utils emacsbug log-view pcvs-util multi-isearch diff-mode easy-mmode vc dired-aux dired regexp-opt vc-dispatcher vc-rcs advice help-fns advice-preload saveplace paren recentf tree-widget wid-edit easymenu completion cus-start cus-load tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs) --bcaec51d2a3acb4b8404b69460e1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi,
C= reating tag with C-v s fails since vc-rcs-create-tag gets the
<= div> forbid= den branchp parameter. My quick fix was to be liberal on
what = is received and just give the notification message rather
than error. Pleas= e see the diff below.

BR, Risto Mononen


*** vc= -rcs.el 201= 2/01/15 16:56:35 <= /span>1.1
--- vc-rcs.el= 2012/01/15 17:05:08 1.2
***************
*** 813,819 ****
=A0=A0
=A0 (defun vc-rcs-create-tag (backend dir name branch= p)
=A0 =A0 (when branchp
! =A0 =A0 (error "RCS bac= kend %s does not support module branches" backend))
=A0 =A0 = (let ((result (vc-tag-precondition dir)))
=A0 =A0 =A0 (if (stringp result)
=A0 (error "File %s is not up-to= -date" result)
--- 813,819 ----
=A0=A0
= =A0 (defun vc-rcs-create-tag (backend dir name branchp)
=A0 =A0 (when branchp
! =A0 =A0 (message "RCS backend %= s does not support module branches" backend))
=A0 =A0 (let (= (result (vc-tag-precondition dir)))
=A0 =A0 =A0 (if (stringp resu= lt)
=A0 (error= "File %s is not up-to-date" result)


In GNU Emacs 23.3.1 (i686-pc-linux-gnu, GTK+ Ver= sion 2.24.5)
=A0of 2011-08-14 on rothera, modified by Debian
Windowing sy= stem distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure =A0'--build' 'i686-linux-gnu'= '--build' 'i686-linux-gnu' '--prefix=3D/usr' '= --sharedstatedir=3D/var/lib' '--libexecdir=3D/usr/lib' '--l= ocalstatedir=3D/var/lib' '--infodir=3D/usr/share/info' '--m= andir=3D/usr/share/man' '--with-pop=3Dyes' '--enable-locall= isppath=3D/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.3/site-lisp:/us= r/local/share/emacs/site-lisp:/usr/share/emacs/23.3/site-lisp:/usr/share/em= acs/site-lisp:/usr/share/emacs/23.3/leim' '--with-crt-dir=3D/usr/li= b/i386-linux-gnu' '--with-x=3Dyes' '--with-x-toolkit=3Dgtk&= #39; '--with-toolkit-scroll-bars' 'build_alias=3Di686-linux-gnu= ' 'CFLAGS=3D-DDEBIAN -g -O2' 'LDFLAGS=3D-g' 'CPPFLA= GS=3D''

Important settings:
=A0 value of $LC_ALL: nil=
=A0 value of $LC_COLLATE: en_US.UTF-8
=A0 value of $LC= _CTYPE: en_US.UTF-8
=A0 value of $LC_MESSAGES: en_US.UTF-8
<= div> =A0 value of $LC_MONETARY: nil
=A0 value of $LC_NUMERIC: nil
=A0 value of $LC_TIME: nil
=A0 value of $LANG: en_US.UTF-8<= /div>
=A0 value of $XMODIFIERS: nil
=A0 locale-coding-system:= utf-8-unix
=A0 default enable-multibyte-characters: t

Ma= jor mode: Emacs-Lisp

Minor modes in effect:
<= div>=A0 diff-auto-refine-mode: t
=A0 show-paren-mode: t
=A0 recentf-mode: t
=A0 dynamic-completion-mode: t
=A0 tooltip-mode: t
=A0 mouse-wheel-mode: t
=A0 tool-bar-mode: t
=A0 menu-= bar-mode: t
=A0 file-name-shadow-mode: t
=A0 global-fon= t-lock-mode: t
=A0 font-lock-mode: t
=A0 blink-cursor-mode: t
=A0= auto-encryption-mode: t
=A0 auto-compression-mode: t
= =A0 line-number-mode: t
=A0 transient-mark-mode: t
=A0 = abbrev-mode: t

Recent input:
C-x C-v C-k <return> C-x = 1 s <C-home> n n n n Z y f=A0
y e s <return> C-x v = =3D C-x h M-w C-x o C-x o C-s m=A0
e s C-w C-w C-w C-w C-x o C-s = C-s C-s C-p C-x o M-b=A0
M-b C-s C-w C-w C-w C-x o C-s C-s C-x v l n f C-s C-s=A0
C-x= k RET p f C-s C-s C-x o C-x v + C-x v =3D C-u C-x=A0
v =3D <r= eturn> <return> C-x h M-w C-x 0 <help-echo> <help-echo>= ;=A0
<help-echo> <help-echo> <help-echo> <help-echo>= ; <help-echo>=A0
<help-echo> <help-echo> <he= lp-echo> <help-echo> <help-echo>=A0
<help-echo&= gt; <help-echo> <help-echo> <help-echo> <help-echo>= =A0
<help-echo> <help-echo> <help-echo> <help-echo>= ; <help-echo>=A0
<help-echo> <help-echo> <me= nu-bar> <help-menu> <se
nd-emacs-bug-report>

Recent messages:
Checking out /usr/share/emac= s/23.3/lisp/vc-rcs.el.~1.2~...done
Mark saved where search starte= d
(No files need saving)
Checking out /usr/share/emacs/= 23.3/lisp/vc-rcs.el...done
Finding changes in /usr/share/emacs/23.3/lisp/vc-rcs.el...
N= o changes between working revision and workfile
Finding changes i= n /usr/share/emacs/23.3/lisp/vc-rcs.el...done
Mark set [2 times]<= /div>
Saved text until "ror "File %s is not up-to-date" resul= t)
"

Load-path shadows:
/= usr/share/emacs/23.3/site-lisp/debian-startup hides /usr/share/emacs/site-l= isp/debian-startup
/usr/share/emacs23/site-lisp/dictionaries-common/flyspell hides /usr/s= hare/emacs/23.3/lisp/textmodes/flyspell
/usr/share/emacs23/site-l= isp/dictionaries-common/ispell hides /usr/share/emacs/23.3/lisp/textmodes/i= spell

Features:
(shadow sort mail-extr message send= mail ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bod= ies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-= drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils mailheader canlock sha1 hex-uti= l
hashcash mail-utils emacsbug log-view pcvs-util multi-isearch d= iff-mode
easy-mmode vc dired-aux dired regexp-opt vc-dispatcher v= c-rcs advice
help-fns advice-preload saveplace paren recentf tree-widget wid-edit
easymenu completion cus-start cus-load tooltip ediff-hook vc-hooks=
lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fon= tset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select=
scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-= core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan = thai
tai-viet lao korean japanese hebrew greek romanian slovak czech europe= an
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-= hook help
simple abbrev loaddefs button minibuffer faces cus-face= files
text-properties overlay md5 base64 format env code-pages mule custom
widget hashtable-print-readable backquote make-network-process dbu= sbind
system-font-setting font-render-setting gtk x-toolkit x mul= ti-tty emacs)

=A0 --bcaec51d2a3acb4b8404b69460e1--