From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121) Date: Thu, 4 Apr 2019 07:06:38 -0400 Message-ID: References: <20190403234630.29105.2058@vcs0.savannah.gnu.org> <20190403234633.4CB4C2030E@vcs0.savannah.gnu.org> <878swqjlhy.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="155314"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 04 13:22:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC0Ra-000eCd-7N for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 13:22:06 +0200 Original-Received: from localhost ([127.0.0.1]:50273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC0RZ-00055w-8m for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 07:22:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC0QC-0003La-Dp for emacs-devel@gnu.org; Thu, 04 Apr 2019 07:20:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hC0Ct-0003tj-H8 for emacs-devel@gnu.org; Thu, 04 Apr 2019 07:06:56 -0400 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]:43959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hC0Cs-0003i1-QW for emacs-devel@gnu.org; Thu, 04 Apr 2019 07:06:55 -0400 Original-Received: by mail-oi1-f176.google.com with SMTP id t81so1500489oig.10 for ; Thu, 04 Apr 2019 04:06:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O2ZZ8K5kZg0tNacieYIAfNJxSdXyVoJMdRNo4k4A6i8=; b=sdVc0GMyARMB/1i3QHdCJYL3r4okmf4mw87XiyuJmGZ+jGPdpQ4ED5lgefTAj9oasD +U3X4Zqo1Fa2xE96sdRg+bWUbsb4pP8UJSHOvtpSedywkTsZiSdrOwXSaYgmJjNQAaV6 bpQ4wH93bNXPzINgIY2CATr8gCUqfGMp4K2CR9eJNN4UiMNtPsucvaEIQKroG3ZKS0UT yc9O8khgtDQb2Eg5MeAExTyU6cWgsGUKwzqyj8RxTuGsq35wtmcOfju43s3+DKmEIpID PvJyerUiWi6imH7PFWDXUzYgqNbstnDyhoE7gyGVfBKSxasby16veNcxUf1X+zm3V2hv sXSw== X-Gm-Message-State: APjAAAWnqFjDzbFh08OS4bNPdgm6eFnfcvQ0lcK3Ttg/gx59vCmNGuAI XOPI83Jm2YJo3PnrMBewOCMXycsUUqmd6IncbR0= X-Google-Smtp-Source: APXvYqzt/VlPyoA9WuP5nO0LjbGqX1U5Cm327dpOIrNimoAZOCLvFWSVZIsYM3m8HI5e+rN6xSGWHrZVzbYH0CLjgPY= X-Received: by 2002:aca:bf08:: with SMTP id p8mr2749512oif.173.1554376009242; Thu, 04 Apr 2019 04:06:49 -0700 (PDT) In-Reply-To: <878swqjlhy.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.167.176 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234946 Archived-At: On Thu, 4 Apr 2019 at 03:08, Michael Albinus wrote: > > - (let* ((status (debbugs-gnu-current-status)) > > + (let* ((status (or (debbugs-gnu-current-status) > > + (gethash bugid debbugs-cache-data) > > + (debbugs-get-status bugid))) > Yesterday evening I was a little bit tired, so I didn't check precisely. > > `debbugs-get-status' consults the cache first, so there is no reason to > call `gethash' explicitly. Furthermore, `debbugs-get-status' checks > whether cache entries have been expired, and refuses them. Hmm, I had somehow thought it wasn't, but it must have been me not realizing that a bug status wasn't cached or something. And I was missing the call to 'car' on the result of debbugs-get-status (I think I had even noticed that while testing, but somehow I didn't fix it in the pushed version). Anyway, should all be fixed now. [1: 3355f3b2f]: 2019-04-04 07:01:41 -0400 Fix previous change https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3355f3b2f0fd5f988b5b1127392e7d999c094b0e