From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121)
Date: Thu, 4 Apr 2019 07:06:38 -0400 [thread overview]
Message-ID: <CAM-tV-_zr03zDj9fD6LH7EANwg52d7iJ8hj-pp75khnD7MT+mQ@mail.gmail.com> (raw)
In-Reply-To: <878swqjlhy.fsf@gmx.de>
On Thu, 4 Apr 2019 at 03:08, Michael Albinus <michael.albinus@gmx.de> wrote:
> > - (let* ((status (debbugs-gnu-current-status))
> > + (let* ((status (or (debbugs-gnu-current-status)
> > + (gethash bugid debbugs-cache-data)
> > + (debbugs-get-status bugid)))
> Yesterday evening I was a little bit tired, so I didn't check precisely.
>
> `debbugs-get-status' consults the cache first, so there is no reason to
> call `gethash' explicitly. Furthermore, `debbugs-get-status' checks
> whether cache entries have been expired, and refuses them.
Hmm, I had somehow thought it wasn't, but it must have been me not
realizing that a bug status wasn't cached or something. And I was
missing the call to 'car' on the result of debbugs-get-status (I think
I had even noticed that while testing, but somehow I didn't fix it in
the pushed version). Anyway, should all be fixed now.
[1: 3355f3b2f]: 2019-04-04 07:01:41 -0400
Fix previous change
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3355f3b2f0fd5f988b5b1127392e7d999c094b0e
prev parent reply other threads:[~2019-04-04 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190403234630.29105.2058@vcs0.savannah.gnu.org>
[not found] ` <20190403234633.4CB4C2030E@vcs0.savannah.gnu.org>
2019-04-04 7:08 ` [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121) Michael Albinus
2019-04-04 11:06 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-_zr03zDj9fD6LH7EANwg52d7iJ8hj-pp75khnD7MT+mQ@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.