From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline invisible Date: Tue, 2 Aug 2016 10:27:58 -0400 Message-ID: References: <1469520753.418402.676896009.00AAC0DE@webmail.messagingengine.com> <1469679952.1866840.678960241.470C9887@webmail.messagingengine.com> <1470044267.1052174.682381049.26455152@webmail.messagingengine.com> <87fuqoa82i.fsf@users.sourceforge.net> <1470108437.2199166.683287713.52EC58A4@webmail.messagingengine.com> <1470111727.2442030.683311433.12321E0F@webmail.messagingengine.com> NNTP-Posting-Host: blaine Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1470148393 19622 195.159.176.226 (2 Aug 2016 14:33:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Aug 2016 14:33:13 +0000 (UTC) Cc: 24073@debbugs.gnu.org To: Paul Rankin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 02 16:33:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUakn-0004kG-4i for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Aug 2016 16:33:09 +0200 Original-Received: from localhost ([::1]:57050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUakj-0000lQ-Pl for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Aug 2016 10:33:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUagt-0006Gk-5O for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 10:29:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUago-00023Y-VG for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 10:29:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUago-00023M-Rj for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 10:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bUago-0002vF-HU for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2016 10:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2016 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24073 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24073-submit@debbugs.gnu.org id=B24073.147014809611179 (code B ref 24073); Tue, 02 Aug 2016 14:29:02 +0000 Original-Received: (at 24073) by debbugs.gnu.org; 2 Aug 2016 14:28:16 +0000 Original-Received: from localhost ([127.0.0.1]:53726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUafz-0002uB-Dz for submit@debbugs.gnu.org; Tue, 02 Aug 2016 10:28:16 -0400 Original-Received: from mail-oi0-f50.google.com ([209.85.218.50]:34023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUaft-0002tY-79 for 24073@debbugs.gnu.org; Tue, 02 Aug 2016 10:28:09 -0400 Original-Received: by mail-oi0-f50.google.com with SMTP id l65so238544007oib.1 for <24073@debbugs.gnu.org>; Tue, 02 Aug 2016 07:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zfijcLtlctRx/dZv/UtkpPKVlwbAIL5at2Y7/Bnv/KM=; b=YAuu0C4QHypZZ+P51xU9/wPTJycgE6jeMKhSBsex6oH36hjwo45zDOWvTvs2OOGmlO Vekm5KRn4rYX0IpZhP09r6F3wrsbAEOoDfBaya4o+H6JTmw19zTxyoVujGA8uh15GfDR S162s5/F4WGM2rjWaPtfJpt6pB12wE5RILkSB0TEuSBg2d1K8AGikUat6FkqmFLRQJTb eBDXPD9Snjz3Fy4Amjo8vp/oP0h5WZU4truxQJdap/zgufNjKqJI/mJ4g+IAJfGasxqx 5WFadfrSpam4niH9qMwyflJh7rojzQFvrmcXCB7txxVvM2gRhyt+2XxTqfaBF6jP/IPd PWgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zfijcLtlctRx/dZv/UtkpPKVlwbAIL5at2Y7/Bnv/KM=; b=hQ/zLfSyRbjd/WMtpChwKMZ5KqZWja9noY4ihed5NzM+vST6Kuc7Xw8ysi63tIHN6M wp4ZkK1o1xlMDavO7JZXjEQ7xPiURpN3AaVy3OdK1XIZ8uNZU8D6SQe9LLa2BVI6/+qi 6jyq4I9kmm8fiIcL3x3lO6KuSHn34510ogebPBpXljOAlo7KRmkdk95FgzCK1+SW+R8b k1KmTONbZT7GGrMfz9tDVh/+BaS4oENv4ThmEdOv1i6+7IQgke//13Xm4qw38mRAaFjn QnRS57U5Jm1WXDeGK7xkNBjrsn8LuA56FSO1ven9LhOgWbbuboQTnjO2S7AQpDodxUtf /WLQ== X-Gm-Message-State: AEkoouvtYhBKuS+gMECXuAI/7swgJc4J2BOHXhczF4uV6aoc5+UompRn09USD/ls2+MGrMidwa842MxMOnCDsg== X-Received: by 10.202.102.75 with SMTP id a72mr37799211oic.40.1470148079544; Tue, 02 Aug 2016 07:27:59 -0700 (PDT) Original-Received: by 10.157.7.161 with HTTP; Tue, 2 Aug 2016 07:27:58 -0700 (PDT) In-Reply-To: <1470111727.2442030.683311433.12321E0F@webmail.messagingengine.com> X-Google-Sender-Auth: sDhwRLUCyJYlmyNcMMNkQkx4Nbs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121779 Archived-At: On Tue, Aug 2, 2016 at 12:22 AM, Paul Rankin wrote: > It appears that > (find-function-noselect 'missingfunction) will just hang Emacs anyway. That's a bug, but it seems to be fixed in Emacs-25, it signals void-function. > >> >> By the way, shouldn't that be >> >> >> >> (lambda (return) (or (eq return 'outline) return)) >> > >> > I think this will fail when outline-invisible-p returns foo in the >> > initial example. We want to only return t when outline-invisible-p >> > returns outline, not foo or otherwise. >> >> Oh, then your original was okay, it just had a bit of dead code. >> Simply (lambda (return) (eq return 'outline)) should suffice. > > Then this will fail if/when outline-invisible-p is fixed to return t > when I wanna future-proof this, so users don't notice the transition. > Sorry my previous reply neglected to mention returning t. Oh, then you need (lambda (return) (or (eq return 'outline) (eq return t))) Alternatively maybe I can tempt you into learning pcase ;) (lambda (return) (pcase return ((or `outline `t) t)))