From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106) Date: Tue, 28 Mar 2017 10:19:18 -0400 Message-ID: References: <20170328002231.12647.93735@vcs0.savannah.gnu.org> <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1490710812 317 195.159.176.226 (28 Mar 2017 14:20:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 14:20:12 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 16:20:08 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csryb-0007A4-LV for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 16:20:01 +0200 Original-Received: from localhost ([::1]:53599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csryg-00019L-33 for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 10:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csrxw-000189-Pn for emacs-devel@gnu.org; Tue, 28 Mar 2017 10:19:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csrxv-0004q8-Oa for emacs-devel@gnu.org; Tue, 28 Mar 2017 10:19:20 -0400 Original-Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:32942) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csrxv-0004px-KS for emacs-devel@gnu.org; Tue, 28 Mar 2017 10:19:19 -0400 Original-Received: by mail-oi0-x231.google.com with SMTP id b187so5905307oif.0 for ; Tue, 28 Mar 2017 07:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BgsuXb/aKMY4AfFJcyJF+E2+nLUPF76BEGx0LYJKKnk=; b=lA0+VwzHfX7y23+zHfLo3L1g02nzfAIHi6bYWidJ63/zltdIYAtyuE98XBTjMqKfqk 8xWeFkSUscbq+G7hTQMNNZOerjH1Lj273Zkm9HQS3UHGSP2q6KMxQfAiGsyE3kpLDawh j/4BMSLKD01bDIMvaxl1qJ1WVhKEZP8pfnmaS4D4antHVu53mds7SyqvGTR3lw6A++Nr 1qGDnduEi9avtniKANdNbLCEdkOfglZS8dOoLHFqW66Z4nK2Owz7PtY0hLROsIBNifY0 fOri/eeq0hLHlNPmC7c9I7zrFGWvBaloUJkrVdFSNJl4urYstA3CUB8/6NaLLaljZHY1 OiFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BgsuXb/aKMY4AfFJcyJF+E2+nLUPF76BEGx0LYJKKnk=; b=UDEZpcnjdsZoExZBwvVmGm0g/QhYzcjKCBVplXKz+7VAe/WbgB8FtZaHmWjCaDgnq+ 0Z/29xKUYUNuj2oLEhmnNJ7wB5iXgE3j/OWlbJGduT+RPAvpUC70XPM13aGTSbh5m4Ip Gutl+nBUnFwj8dbN4DsMLOzFItnDr5qWUgAsRWkQ9Rw0AHdJE3S2zE7ckCqDunZnA9JV keCtr+kEF+ADXEp6oG94/uYjz0vLzfsba031K6OzvPMMQxGyjVAiDvB2MKtD1849/ERB mSU/QzVz9tJ+raW66DJYCukZ7egikQUtxCzFilaymkrj64fYXlvbQThjHnjoblRsFvdA FWvw== X-Gm-Message-State: AFeK/H1AHxwQFsGPoU3rmkJXn4ZzPSrpVUlN+g7zv8s4iFMimEmE7Tw02JrA6xRMVsf7FOgfeIRjxp6TU0lPVw== X-Received: by 10.202.89.3 with SMTP id n3mr15718036oib.26.1490710758961; Tue, 28 Mar 2017 07:19:18 -0700 (PDT) Original-Received: by 10.157.80.172 with HTTP; Tue, 28 Mar 2017 07:19:18 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213449 Archived-At: On Tue, Mar 28, 2017 at 9:55 AM, Stefan Monnier wrote: > >> - (signal 'search-failed (list "\n\^_")))) >> + (user-error "Search failed: `\n\^_'"))) > > This one doesn't look like a user-error: the \n\^_ sequence is internal > to Info files and mostly invisible to the user, so either we change the > text so as to report the message in user-understandable terms, or we > keep this as a (signal 'search-failed' ...). Right. While I'm taking a second look at this, do you think the search for "\n* Menu: " in Info-complete-menu-item should be a user error? --- i/lisp/info.el +++ w/lisp/info.el @@ -2699,7 +2699,8 @@ Info-complete-menu-item (orignode Info-current-node) nextnode) (goto-char (point-min)) - (search-forward "\n* Menu:") + (unless (search-forward "\n* Menu:" nil t) + (user-error "No menu in this node")) (cond ((eq (car-safe action) 'boundaries) nil) ((eq action 'lambda)