From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)
Date: Tue, 28 Mar 2017 10:19:18 -0400 [thread overview]
Message-ID: <CAM-tV-_w_Y5Ws36-UGJdwx3wmnrdGTdOUMmBudxzAPoZZxznfA@mail.gmail.com> (raw)
In-Reply-To: <jwv7f3933uz.fsf-monnier+emacsdiffs@gnu.org>
On Tue, Mar 28, 2017 at 9:55 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>
>> - (signal 'search-failed (list "\n\^_"))))
>> + (user-error "Search failed: `\n\^_'")))
>
> This one doesn't look like a user-error: the \n\^_ sequence is internal
> to Info files and mostly invisible to the user, so either we change the
> text so as to report the message in user-understandable terms, or we
> keep this as a (signal 'search-failed' ...).
Right. While I'm taking a second look at this, do you think the search
for "\n* Menu: " in Info-complete-menu-item should be a user error?
--- i/lisp/info.el
+++ w/lisp/info.el
@@ -2699,7 +2699,8 @@ Info-complete-menu-item
(orignode Info-current-node)
nextnode)
(goto-char (point-min))
- (search-forward "\n* Menu:")
+ (unless (search-forward "\n* Menu:" nil t)
+ (user-error "No menu in this node"))
(cond
((eq (car-safe action) 'boundaries) nil)
((eq action 'lambda)
next prev parent reply other threads:[~2017-03-28 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170328002231.12647.93735@vcs0.savannah.gnu.org>
[not found] ` <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org>
2017-03-28 13:55 ` [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106) Stefan Monnier
2017-03-28 14:19 ` Noam Postavsky [this message]
2017-03-28 14:54 ` Stefan Monnier
2017-03-29 1:26 ` Noam Postavsky
2017-03-31 4:06 ` Mark Oteiza
2017-03-31 14:17 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-_w_Y5Ws36-UGJdwx3wmnrdGTdOUMmBudxzAPoZZxznfA@mail.gmail.com \
--to=npostavs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.