From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: make-network-process: Breaks after recent update from GitHub Date: Thu, 12 Jul 2018 19:51:06 -0400 Message-ID: References: <20180712202418.878F61A0C60@retriever.mtv.corp.google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1531439352 17438 195.159.176.226 (12 Jul 2018 23:49:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jul 2018 23:49:12 +0000 (UTC) Cc: Emacs developers To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 13 01:49:08 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdlKd-0004RG-Tr for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2018 01:49:08 +0200 Original-Received: from localhost ([::1]:34528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdlMl-0005eC-1Q for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 19:51:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdlMa-0005e5-87 for emacs-devel@gnu.org; Thu, 12 Jul 2018 19:51:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdlMZ-0006rm-Dn for emacs-devel@gnu.org; Thu, 12 Jul 2018 19:51:08 -0400 Original-Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:46426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdlMZ-0006rL-8n for emacs-devel@gnu.org; Thu, 12 Jul 2018 19:51:07 -0400 Original-Received: by mail-oi0-x230.google.com with SMTP id y207-v6so59057308oie.13 for ; Thu, 12 Jul 2018 16:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CRqf/DIls45tBTbPSRcHx893j4cbVPLOX/S9x9++MIA=; b=VpMiuNDj87FWvCbMhLNh3ERKJhPuyl4CNpJoGnkt1bwOKG0s/5ew3hMpkCkdnwwy85 O8n27Mu2di1vI3dLUT2b81nEc4I+O2f6lnNZddBDWOaOv/YOtaX+Ne45lolH1fDVAtNo 6ewqeIznK4VjtiM/iKeCFYt9ch4Ey7xOgGXjowR78inCA6F3XtCPxwr+HHUXn3XxNf/g fRH62LNJedOeAt+PwOB2vt4uxTz+1toktasH2CnjQObst0ajPTWfzVsJBz7Dzn/BttZj Xk2YjLK2DzJ/UdaHGIwPziWnQvrsvbtJZmDsk+YuCDTf+702CUsOVNlRcYlAwE9WDJMZ 635A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CRqf/DIls45tBTbPSRcHx893j4cbVPLOX/S9x9++MIA=; b=VYfaOsjp2+z7odO2T4diKcN9jWD9s2E9ksUL9LLBa4q/2W+wv78CyZgFWXS6nhfmsy vJj+m1e1IyLVZ0fPpYjEekRyeZ5YKqJ4Y0fTPkF6nz9VEazf8/HpS3XQt1zr/gl4tVaB cK6jXaQxK/+LisYT1pBGxLEHvKrqWZ3kFgOMGcdXK5DPFgJov2tR5qW1hUjY8H5Nxfa4 GE30YtriE7SkMRS4kTD+Q6cWiNXYwGUh/L75bTPj/uYv2CtSJgSfPOkBp7A6KnWPZGwe +XHAQmL6EB40tQ3oPpNQJisY9l2rXlMNkYtQWUmV3DKIyIw1bQbalnUqDOz7jOzSbdbZ gtGA== X-Gm-Message-State: AOUpUlG/jj35riLKSEpZ+P72rjz6b1OVhZRxKA6N0KNScBz3Yzd0AUDe TrJbye0HYOAncoMYE+R4Z+nRgYsHjnVb5rt68Tc= X-Google-Smtp-Source: AAOMgpdRrs/q6idmmSiqZIO5dHS2t6KSdRQJgOx1fe04fR/Grurx/z9ABmdj52lMLUoT8De0KXKqbOTM3ba35CAwkCA= X-Received: by 2002:aca:c00b:: with SMTP id q11-v6mr4336529oif.330.1531439466422; Thu, 12 Jul 2018 16:51:06 -0700 (PDT) Original-Received: by 2002:a4a:3b8d:0:0:0:0:0 with HTTP; Thu, 12 Jul 2018 16:51:06 -0700 (PDT) In-Reply-To: <20180712202418.878F61A0C60@retriever.mtv.corp.google.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227309 Archived-At: On 12 July 2018 at 16:24, T.V Raman wrote: > Looks like that function went through some changes last week -- (july > 9 etc) and a fresh build from GitHub results in the following call > failing: > (git blame shows both Stephane and Noam working around that area of > the code) > > (make-network-process :name "nc-connect" > :family 'local > :remote "/tmp/foo) > where /tmp/foo is a socket in /tmp. Yes, thanks for reporting that, I added an extra "!". Should be fixed as of [1: 5cc7c4b48a]. [1: 5cc7c4b48a]: 2018-07-12 19:43:00 -0400 Fix previous make-network-process change https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5cc7c4b48a2d6eca5d14d12b1cd258bf9cabde74