From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32051: 26.1; grep-regexp-alist on windows Date: Wed, 4 Jul 2018 15:57:53 -0400 Message-ID: References: <65653506844b4308957893b429dea091@chihq-post2.XRTRADING.LOCAL> <83in5vnf0s.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1530734193 28482 195.159.176.226 (4 Jul 2018 19:56:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jul 2018 19:56:33 +0000 (UTC) Cc: 32051@debbugs.gnu.org, Dan Harms To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 04 21:56:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fant6-0007Gs-8F for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2018 21:56:28 +0200 Original-Received: from localhost ([::1]:49031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fanvD-0004jn-HO for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2018 15:58:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fanuf-0004T6-UW for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 15:58:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fanuc-0001LD-Tr for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 15:58:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fanuc-0001Kg-Pm for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 15:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fanuc-00005d-FP for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 15:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jul 2018 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32051-submit@debbugs.gnu.org id=B32051.1530734281338 (code B ref 32051); Wed, 04 Jul 2018 19:58:02 +0000 Original-Received: (at 32051) by debbugs.gnu.org; 4 Jul 2018 19:58:01 +0000 Original-Received: from localhost ([127.0.0.1]:47013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fanub-00005O-JZ for submit@debbugs.gnu.org; Wed, 04 Jul 2018 15:58:01 -0400 Original-Received: from mail-oi0-f41.google.com ([209.85.218.41]:33443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fanua-00005C-0q for 32051@debbugs.gnu.org; Wed, 04 Jul 2018 15:58:00 -0400 Original-Received: by mail-oi0-f41.google.com with SMTP id c6-v6so12670322oiy.0 for <32051@debbugs.gnu.org>; Wed, 04 Jul 2018 12:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+3a1Dhto2iPwJuN1vkLW0CvjtYmzQ9qTcfXWJa8bvOs=; b=SS4f1aslPKBzIfBUCqZ86b9LIcPOFOPnh3h3PMFQt/5K8pGRXGjH2LlV6r1Z/mjSs1 yfdOcObeaCORgoFvOrfyGwnT2mrED9IimNElvE3CwZJiNb/23Waq2LBEl+nm3ZdqyCEd jtme6XSjWofdNGgZkJEo2C17DSysPMYTpoN2atfMF5OMyA2ebs2+W0+cbR5YoY9GvV4T blT1wilVr36btOTQaON0WGx4lP6e+vh0gtd6Eu/a5z/GtrS50aYQz294rNBVg9Q0CqiW NyMf1xisBJmTBwbod7nAkbeNwzpiQ2jNWZvXyRl1T8VS79yiZ9K6YC0Ti0UKVoYtCpvk 1P/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+3a1Dhto2iPwJuN1vkLW0CvjtYmzQ9qTcfXWJa8bvOs=; b=POFnF9829zXOLJ9CAkBih8zBrVAXlKgOhZai+EDybfXgvI5JhPemiL34NowFwHLt1q OGmzZ/+kgjnptiV3JiLW1YzviI3JC4pJVUZwG6VAq+YCYuzuiFwoaty66kOZMvCZA5uC hC4fg599RJidh1SEx8gqxEqXtEqYc0I9m/mSytwkMFUXcFvI8qr9uZe0t/rNXyNaPOby vUwqAVm8Gxz13wQd9B5iDEBD7XOwWe8/+Wm08GeJqFAnx5ZrHAbpBPghiPjfhAAXIL/b f6QBHO/rgn5vx/WEHmJJpeSLAv6GKM8XoBuGyvXc5npBexty+5qVx5zAH7p3v098LSha +pEg== X-Gm-Message-State: APt69E3z+PZxbe6KqhPyyWG5bB67adkV+RVLXm8+gzrkq8uDxDSp20Hn 5fOfK3Y8k9ki1xFREhl6oo1rEEPTUJCaz+fmxi8= X-Google-Smtp-Source: AAOMgpdozuiVzfRyLF6C6m7hDCz5oeIGz2zveW3EdtscqVBn17k1SChc9O39nlDi6l8tYPWrJ87LEVW52W242hpkP/g= X-Received: by 2002:aca:be42:: with SMTP id o63-v6mr3891248oif.22.1530734274148; Wed, 04 Jul 2018 12:57:54 -0700 (PDT) Original-Received: by 2002:a4a:3b8d:0:0:0:0:0 with HTTP; Wed, 4 Jul 2018 12:57:53 -0700 (PDT) In-Reply-To: <83in5vnf0s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148204 Archived-At: On 4 July 2018 at 12:26, Eli Zaretskii wrote: > I don't think I can reproduce this. I've just ran a Grep command > whose hits look like this: > > d:/gnu/emacs/branch/src/callproc.c:214:#ifdef DOS_NT > > and they seem to exhibit all the traits of a Grep hit. Looking at the grep-regexp-alist, it is the case that a filename with a colon will not be matched when grep doesn't support --null. In the case where grep does support --null, the NUL byte is displayed like a colon, so the difference might not leap out at you. I think the patch below would fix it: --- i/lisp/progmodes/grep.el +++ w/lisp/progmodes/grep.el @@ -381,3 +381,5 @@ grep-regexp-alist ;; [0-9]+ so as to accept ":034:" in file names. - "\\(?1:[^\n:]+?[^\n/:]\\):[\t ]*\\(?2:[1-9][0-9]*\\)[\t ]*:" + "\\(?1:" + "\\(?:[a-zA-Z]:\\)?" ; Allow "C:..." for w32. + "[^\n:]+?[^\n/:]\\):[\t ]*\\(?2:[1-9][0-9]*\\)[\t ]*:" "\\)")