From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: 1) (elisp) `Advising Named Functions', 2) search filtering example
Date: Mon, 17 Oct 2016 10:37:41 -0400 [thread overview]
Message-ID: <CAM-tV-_gAj7hq90aWtPL+7+j=fAJsEEjsJzjhYF=Sygpu9sCQA@mail.gmail.com> (raw)
In-Reply-To: <1807679d-1125-4afe-81b7-b8d8e78aa2c6@default>
On Mon, Oct 17, 2016 at 10:02 AM, Drew Adams <drew.adams@oracle.com> wrote:
>> `advice-add' puts advice on a function, `add-function'
>> does not.
>
> I don't think so. AFAICS, `add-function' certainly does
> "put advice on a function".
You're right. I did have the impression that add-function was
considered to be okay, just like add-hook is. But the manual doesn't
say this (and also, I didn't realize that (add-function
...(symbol-function 'FUN)...) has almost the same effect as
advice-add). So I was wrong to look at add-function vs advice-add; the
important distinction is between the thing being added to, not the
function used to do the adding.
>
> Do you think that that information does not apply also
> to this code, from dired-aux.el? If so, why?
>
> (add-function :before-while (local 'isearch-filter-predicate)
> #'dired-isearch-filter-filenames
> '((isearch-message-prefix . "filename ")))
I think it falls under this case in `(elisp) Hooks' (which should be
updated to mention `-predicate' as a possible suffix)
If the variable’s name ends in ‘-function’, then its value is just a
single function, not a list of functions. ‘add-hook’ cannot be used to
modify such a _single function hook_, and you have to use ‘add-function’
instead (*note Advising Functions::).
next prev parent reply other threads:[~2016-10-17 14:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 5:25 1) (elisp) `Advising Named Functions', 2) search filtering example Drew Adams
2016-10-17 12:20 ` Noam Postavsky
2016-10-17 14:02 ` Drew Adams
2016-10-17 14:37 ` Noam Postavsky [this message]
2016-10-17 14:52 ` Stefan Monnier
2016-10-17 15:40 ` Drew Adams
2016-10-17 15:51 ` Stefan Monnier
2016-10-17 17:05 ` Drew Adams
2016-10-17 17:47 ` Stefan Monnier
2016-10-17 15:40 ` Drew Adams
2016-10-17 16:16 ` Noam Postavsky
2016-10-17 17:05 ` Drew Adams
2016-10-17 17:53 ` Stefan Monnier
2016-10-17 18:41 ` Drew Adams
2016-10-17 19:25 ` Stefan Monnier
2016-10-18 19:47 ` Richard Stallman
2016-10-19 6:15 ` Eli Zaretskii
2016-10-19 20:00 ` Richard Stallman
2016-10-19 20:18 ` Stefan Monnier
2016-10-20 7:17 ` Eli Zaretskii
2016-10-20 7:06 ` Eli Zaretskii
2016-10-20 18:06 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-_gAj7hq90aWtPL+7+j=fAJsEEjsJzjhYF=Sygpu9sCQA@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.