From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Richard Stallman <rms@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Emacs 26 MacOS bugs
Date: Tue, 6 Feb 2018 12:30:06 -0500 [thread overview]
Message-ID: <CAM-tV-_f72uczrJ-+f3e2Zhw3KDF05Uy4WUFwNS7fw6fK1_KEg@mail.gmail.com> (raw)
In-Reply-To: <E1ej4Ye-0007Px-Q0@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
On Tue, Feb 6, 2018 at 9:49 AM, Richard Stallman <rms@gnu.org> wrote:
> - - (p 510) - "--no-build-details" returns:
> Wrong type argument: stringp, nil
Not sure about macOS, but on w32 I get an assertion failure, patch attached.
[-- Attachment #2: v1-0001-Handle-nil-system-name-e.g.-when-using-no-build-d.patch --]
[-- Type: application/octet-stream, Size: 1390 bytes --]
From cbf51e0f71906f78e6ff81ed10491e68eb34f882 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Tue, 6 Feb 2018 12:20:37 -0500
Subject: [PATCH v1] Handle nil system-name (e.g., when using
--no-build-details)
* src/w32term.c (w32_initialize_display_info): Handle nil system-name.
---
src/w32term.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/w32term.c b/src/w32term.c
index db4ccf5..ac29bbb 100644
--- a/src/w32term.c
+++ b/src/w32term.c
@@ -6922,10 +6922,15 @@ w32_initialize_display_info (Lisp_Object display_name)
memset (dpyinfo, 0, sizeof (*dpyinfo));
dpyinfo->name_list_element = Fcons (display_name, Qnil);
- dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name)
- + SCHARS (Vsystem_name) + 2);
- sprintf (dpyinfo->w32_id_name, "%s@%s",
- SDATA (Vinvocation_name), SDATA (Vsystem_name));
+ if (STRINGP (Vsystem_name))
+ {
+ dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name)
+ + SCHARS (Vsystem_name) + 2);
+ sprintf (dpyinfo->w32_id_name, "%s@%s",
+ SDATA (Vinvocation_name), SDATA (Vsystem_name));
+ }
+ else
+ dpyinfo->w32_id_name = xlispstrdup (Vinvocation_name);
/* Default Console mode values - overridden when running in GUI mode
with values obtained from system metrics. */
--
2.6.2.windows.1
next prev parent reply other threads:[~2018-02-06 17:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 14:49 Emacs 26 MacOS bugs Richard Stallman
2018-02-06 17:30 ` Noam Postavsky [this message]
2018-02-06 23:28 ` Paul Eggert
2018-02-07 3:37 ` Eli Zaretskii
2018-02-10 14:55 ` Uwe Brauer
2018-02-10 15:18 ` Noam Postavsky
2018-02-07 3:52 ` Eli Zaretskii
2018-02-06 19:05 ` Ben McGinnes
2018-02-06 20:30 ` Noam Postavsky
2018-02-06 22:27 ` Ben McGinnes
2018-02-06 22:30 ` Ben McGinnes
2018-02-06 22:50 ` Noam Postavsky
2018-02-07 0:43 ` Ben McGinnes
2018-02-07 1:33 ` Noam Postavsky
2018-02-07 2:13 ` Ben McGinnes
2018-02-07 22:55 ` Alan Third
2018-02-09 16:35 ` Ben McGinnes
2018-02-09 16:57 ` Noam Postavsky
2018-02-09 17:22 ` Ben McGinnes
2018-02-09 18:13 ` Noam Postavsky
2018-02-10 1:46 ` Ben McGinnes
2018-02-10 1:47 ` Alan Third
2018-02-11 13:53 ` Philipp Stephani
2018-02-11 21:06 ` Alan Third
2018-02-07 20:01 ` Alan Third
2018-02-10 15:01 ` Alan Third
2018-02-10 22:45 ` Alan Third
2018-02-11 11:47 ` Alan Third
2018-02-11 15:52 ` Eli Zaretskii
2018-02-11 20:57 ` Alan Third
2018-02-13 19:41 ` Ben McGinnes
2018-02-13 19:46 ` Noam Postavsky
2018-02-11 20:43 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-_f72uczrJ-+f3e2Zhw3KDF05Uy4WUFwNS7fw6fK1_KEg@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.