Re: Emacs 26 MacOS bugs

[Noam Postavsky <npostavs@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

On Tue, Feb 6, 2018 at 9:49 AM, Richard Stallman <rms@gnu.org> wrote:

> - - (p 510) - "--no-build-details" returns:
>        Wrong type argument: stringp, nil

Not sure about macOS, but on w32 I get an assertion failure, patch attached.

[-- Attachment #2: v1-0001-Handle-nil-system-name-e.g.-when-using-no-build-d.patch --]
[-- Type: application/octet-stream, Size: 1390 bytes --]

From cbf51e0f71906f78e6ff81ed10491e68eb34f882 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Tue, 6 Feb 2018 12:20:37 -0500
Subject: [PATCH v1] Handle nil system-name (e.g., when using
 --no-build-details)

* src/w32term.c (w32_initialize_display_info): Handle nil system-name.
---
 src/w32term.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/w32term.c b/src/w32term.c
index db4ccf5..ac29bbb 100644
--- a/src/w32term.c
+++ b/src/w32term.c
@@ -6922,10 +6922,15 @@ w32_initialize_display_info (Lisp_Object display_name)
   memset (dpyinfo, 0, sizeof (*dpyinfo));
 
   dpyinfo->name_list_element = Fcons (display_name, Qnil);
-  dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name)
-				  + SCHARS (Vsystem_name) + 2);
-  sprintf (dpyinfo->w32_id_name, "%s@%s",
-	   SDATA (Vinvocation_name), SDATA (Vsystem_name));
+  if (STRINGP (Vsystem_name))
+    {
+      dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name)
+                                      + SCHARS (Vsystem_name) + 2);
+      sprintf (dpyinfo->w32_id_name, "%s@%s",
+               SDATA (Vinvocation_name), SDATA (Vsystem_name));
+    }
+  else
+    dpyinfo->w32_id_name = xlispstrdup (Vinvocation_name);
 
   /* Default Console mode values - overridden when running in GUI mode
      with values obtained from system metrics.  */
-- 
2.6.2.windows.1