* Ignoring test error
@ 2017-06-12 14:33 Philipp Stephani
2017-06-12 17:04 ` Noam Postavsky
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Stephani @ 2017-06-12 14:33 UTC (permalink / raw)
To: Emacs developers
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
Hi,
after commit 94306c8b0d61a53b19dcee18475ea8692b001f5d 'make foo.log' in the
test directory exits successfully even if the test fails. I don't think
that is the best behavior, because the exit status is often used to
determine whether any test has failed. Rather, 'make check' should use
'make -k' for the tests.
Philipp
[-- Attachment #2: Type: text/html, Size: 425 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ignoring test error
2017-06-12 14:33 Ignoring test error Philipp Stephani
@ 2017-06-12 17:04 ` Noam Postavsky
2017-06-16 17:12 ` Philipp Stephani
0 siblings, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2017-06-12 17:04 UTC (permalink / raw)
To: Philipp Stephani; +Cc: Emacs developers
On Mon, Jun 12, 2017 at 10:33 AM, Philipp Stephani
<p.stephani2@gmail.com> wrote:
> after commit 94306c8b0d61a53b19dcee18475ea8692b001f5d 'make foo.log' in the
> test directory exits successfully even if the test fails. I don't think that
> is the best behavior, because the exit status is often used to determine
> whether any test has failed. Rather, 'make check' should use 'make -k' for
> the tests.
How about this? (my initial attempt of just making the 'check' recipe
do '@${MAKE} -k check-doit ...' ran into the problem that the summary
was skipped on test failure)
--- i/test/Makefile.in
+++ w/test/Makefile.in
@@ -124,10 +124,9 @@ testloadfile =
testloadfile = $*
endif
-## Ignore any test errors so we can continue to test other files.
%.log: %.elc
$(AM_V_at)${MKDIR_P} $(dir $@)
- -$(AM_V_GEN)HOME=/nonexistent $(emacs) -l ert -l $(testloadfile) \
+ $(AM_V_GEN)HOME=/nonexistent $(emacs) -l ert -l $(testloadfile) \
--eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG}
ifeq (@HAVE_MODULES@, yes)
@@ -211,8 +210,9 @@ check-maybe:
## Run the tests.
.PHONY: check-doit
-check-doit: ${LOGFILES}
- @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit $^
+check-doit:
+ -@${MAKE} -k ${LOGFILES}
+ @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES}
.PHONY: mostlyclean clean bootstrap-clean distclean maintainer-clean
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ignoring test error
2017-06-12 17:04 ` Noam Postavsky
@ 2017-06-16 17:12 ` Philipp Stephani
2017-06-17 21:44 ` Noam Postavsky
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Stephani @ 2017-06-16 17:12 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Emacs developers
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
Noam Postavsky <npostavs@users.sourceforge.net> schrieb am Mo., 12. Juni
2017 um 19:04 Uhr:
> On Mon, Jun 12, 2017 at 10:33 AM, Philipp Stephani
> <p.stephani2@gmail.com> wrote:
> > after commit 94306c8b0d61a53b19dcee18475ea8692b001f5d 'make foo.log' in
> the
> > test directory exits successfully even if the test fails. I don't think
> that
> > is the best behavior, because the exit status is often used to determine
> > whether any test has failed. Rather, 'make check' should use 'make -k'
> for
> > the tests.
>
> How about this? (my initial attempt of just making the 'check' recipe
> do '@${MAKE} -k check-doit ...' ran into the problem that the summary
> was skipped on test failure)
>
>
Yes, this patch works, thanks.
[-- Attachment #2: Type: text/html, Size: 1167 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ignoring test error
2017-06-16 17:12 ` Philipp Stephani
@ 2017-06-17 21:44 ` Noam Postavsky
0 siblings, 0 replies; 4+ messages in thread
From: Noam Postavsky @ 2017-06-17 21:44 UTC (permalink / raw)
To: Philipp Stephani; +Cc: Emacs developers
On Fri, Jun 16, 2017 at 1:12 PM, Philipp Stephani <p.stephani2@gmail.com> wrote:
>> How about this? (my initial attempt of just making the 'check' recipe
>> do '@${MAKE} -k check-doit ...' ran into the problem that the summary
>> was skipped on test failure)
>>
>
> Yes, this patch works, thanks.
Pushed to mater [1: 4caa8d4de4].
[1: 4caa8d4de4]: 2017-06-17 17:45:17 -0400
* test/Makefile.in: Don't suppress test failure for single tests.
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4caa8d4de4cc9c84b2d49a75f24c1626aa3c3f73
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-17 21:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12 14:33 Ignoring test error Philipp Stephani
2017-06-12 17:04 ` Noam Postavsky
2017-06-16 17:12 ` Philipp Stephani
2017-06-17 21:44 ` Noam Postavsky
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.