From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el Date: Tue, 7 May 2019 19:03:41 -0400 Message-ID: References: <87woj1anpx.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244220"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Stefan Kangas , Emacs developers To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 01:04:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO983-0011Qc-Vy for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 01:04:08 +0200 Original-Received: from localhost ([127.0.0.1]:55897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO982-0001xT-S5 for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 19:04:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO97t-0001xM-N8 for emacs-devel@gnu.org; Tue, 07 May 2019 19:03:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO97s-00053D-QQ for emacs-devel@gnu.org; Tue, 07 May 2019 19:03:57 -0400 Original-Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]:41638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hO97s-0004tE-Km for emacs-devel@gnu.org; Tue, 07 May 2019 19:03:56 -0400 Original-Received: by mail-oi1-x232.google.com with SMTP id b17so6474657oie.8 for ; Tue, 07 May 2019 16:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WbmxaeH0hnRRkGHIllZ07gSwLChjT4iCvjUJhNXPUEk=; b=Wthh2Ebpd8m4s4oach2JTYC+bmJW9zJHu9hGEV+kThUCjNcTo4zFmfks17W7bAyxuK vieIutGeYBaT2CLeSlGad26ZAO/7Wz8OowmQelyWELs5s0zquGQ4DRLtHkXI6/Q0AYxi 6UVig+JJMgg18uiN41sBzpyLCHc83FSnO7r+V6KKkVKkR8fOpyJl1VIoX5m1CMCHxsFB OCZhDQaDZVFJxkQLMytnsqAVTkgpkv7+JfqSaZoffghsHZZtAr9AizF91rzSKo/doZvy Mv1i3syvOgYYb95oIMUrpaCcHQ/yap232eEW60mHa4PD2DPeUqMkH7AVG4GhsM2CrXHe rv1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WbmxaeH0hnRRkGHIllZ07gSwLChjT4iCvjUJhNXPUEk=; b=F0zILHxotBdmNtabnbmNh1+9pFC2TrluM7JyOL5g8DhVcIxQHTA1UTcLeVYlgA9OVS Jz8CdRsYdrnKPHmI6ghGVnpT5cxp7tIxohr+Z4Grw6TrX87UCh0ebvigoITfzFNbsOSe RSwtyxDWjmlzscxr+KnNKMCWfhAxca6fm0OXpTFJAmryYmt3YNV/Q2XcEYwNYAxHmmYP 7L77BT38/H8/40j1FS1O9JwtEQ9mOowtUK8rWUBX5umD5D46CI4KUv74R2g5zOJMOiTY a40fPYN4Kn9Np5JGABdJL2+KqDU8TFxUn40Ax+ZvQMX/myvyEZ2I7JtmynNoW+oD5G9X TESw== X-Gm-Message-State: APjAAAUaT6PHR02yEKjSdPV9PzYDKRv0KK63xP+7uqFGtEGY6yiqJUu9 uH2PbMN662vaBf3CkokQv8I/uZnNJNDC1G86eL6koaKD X-Google-Smtp-Source: APXvYqxS9/LQTz2biq8g/za2icBZ4aVHcA+jUOk3BpOKMds61mEsyvvjp/VIdj0Z5PT0RELI0EJDW2mWCU32q2s7GqY= X-Received: by 2002:aca:bbc3:: with SMTP id l186mr64206oif.23.1557270232184; Tue, 07 May 2019 16:03:52 -0700 (PDT) In-Reply-To: <87woj1anpx.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236267 Archived-At: On Tue, 7 May 2019 at 18:45, Basil L. Contovounesios wrote: > You said you were disinclined to adapt delim-col.el itself, but how > about bundling the following minor cleanups as well? > -(defmacro delimit-columns-str (str) > - `(if (stringp ,str) ,str "")) > +(defsubst delimit-columns-str (str) > + (if (stringp str) str "")) I think you may as well go with defun here, delimit-columns-str isn't being used in some performance-critical spot, as far as I can tell.