From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g Date: Tue, 28 Mar 2017 09:48:35 -0400 Message-ID: References: <86poh1iwbh.fsf@molnjunk.nocrew.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1490708933 28142 195.159.176.226 (28 Mar 2017 13:48:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 13:48:53 +0000 (UTC) Cc: Emacs developers To: Lars Brinkhoff Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 15:48:49 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csrUJ-0006Si-QS for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 15:48:43 +0200 Original-Received: from localhost ([::1]:53431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csrUP-0001xX-Nf for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 09:48:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csrUE-0001wQ-6X for emacs-devel@gnu.org; Tue, 28 Mar 2017 09:48:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csrUD-0001Wc-Au for emacs-devel@gnu.org; Tue, 28 Mar 2017 09:48:38 -0400 Original-Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:35782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csrUD-0001WX-4l for emacs-devel@gnu.org; Tue, 28 Mar 2017 09:48:37 -0400 Original-Received: by mail-oi0-x232.google.com with SMTP id f193so39760279oib.2 for ; Tue, 28 Mar 2017 06:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=WAyw/oEz0dPhYysb1oIyAl9CjDWhmPNEhs8TeWTl+bs=; b=ikA/dCFfUZWHT8oGsykOFSuZvpYICzu7WVriUc+/PGlE1Xxl7/hiKoTbTNlFlXJI4M fqctOw/FJNmnho8v/St8XpBJoulvEh/HSQIG4pU/TelsOchqhLzX+bPdforybeXVAaFb /3ycVFXBvnCE9hZCaTQIp2a+3OJMgGiQ6cUibyGkflOqvjatrWVAItwUFbpB8EoZZp+q G8+0XnyNaM2naWFOTCa4wBbHNhkN6n8nqMy5piXnre4daOq454ppT3ts9UzNLTznmyus I8w/jNNmLE9In77JUyMxzN3WNTBsCTCl3qRq2mUXDrpQCt7iOK6URB4KUUrKV2rQSO91 0APA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=WAyw/oEz0dPhYysb1oIyAl9CjDWhmPNEhs8TeWTl+bs=; b=Kp7II+e4XRm0IbN42ErHYhNxOkS5NF45oiV9T8LoOxP5ngUbrhxVUgXrj4rxbo3rI1 P2w6lgu0JA0fBc1RGqEeVRQbKq7H2VE0OZdgxL8nndBCQcTn8DA1BibWbkUQ6MaoZsHW p66z7BucFnPEY5vHbMzVhY/ah9lJX1SI43gG4OaZF00OF5/i4gp71hWs88N4eYPb2KD4 qNAx4fHxxBQ6iSbYGoo7wKM2xaAPY5uM4rapsphFVLb1XGO6DAz0h6ePaF1hiKRmAXMn fxeAw21c8JvIOWbF914P1Zx+AzcCxsA2R1z9kdjSf+SCpGmv1++0/FNfaXZYaAIpCgdI jviQ== X-Gm-Message-State: AFeK/H0G+yNgmwGF6OMjWmXnBsZ/qWFfsEfMe94sIJS0irVFnR1UG6pHfOqaIGGn7ovoAEDAj/EUbQ6eUOgLhA== X-Received: by 10.202.74.193 with SMTP id x184mr6685154oia.167.1490708916338; Tue, 28 Mar 2017 06:48:36 -0700 (PDT) Original-Received: by 10.157.80.172 with HTTP; Tue, 28 Mar 2017 06:48:35 -0700 (PDT) In-Reply-To: <86poh1iwbh.fsf@molnjunk.nocrew.org> X-Google-Sender-Auth: bzrqDK0Q0Yr0IGPFDawP4w84Kj8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213447 Archived-At: On Tue, Mar 28, 2017 at 5:29 AM, Lars Brinkhoff wrote: > Noam Postavsky wrote: >> Make it easier to abort a series of tests with C-g >> >> * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If >> interactively is true and a test was aborted then ask if the remaining >> tests should be aborted too. >> (ert-run-tests-batch, ert-run-tests-interactively): Pass in >> interactively arg. > > This commit adds a testsuite failure when I run: > git clean -xfd && ./autogen.sh && make bootstrap && make check > > If I revert this commit, the failure goes away. It seems there's a call > to ert-run-tests that hasn't been updated with a third argument. Oops, right. I've made that argument &optional in [1: 7d27f5d8f4]. 1: 2017-03-28 09:44:24 -0400 7d27f5d8f48b8f184eb93f64461e01c1481c8fb4 * lisp/emacs-lisp/ert.el (ert-run-tests): Make INTERACTIVE arg optional.