From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Lars Brinkhoff <lars@nocrew.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g
Date: Tue, 28 Mar 2017 09:48:35 -0400 [thread overview]
Message-ID: <CAM-tV-_aePiE0vUr3oc04uE9Q93fZUzxNZtNcDDY4gOqNsaK3w@mail.gmail.com> (raw)
In-Reply-To: <86poh1iwbh.fsf@molnjunk.nocrew.org>
On Tue, Mar 28, 2017 at 5:29 AM, Lars Brinkhoff <lars@nocrew.org> wrote:
> Noam Postavsky wrote:
>> Make it easier to abort a series of tests with C-g
>>
>> * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If
>> interactively is true and a test was aborted then ask if the remaining
>> tests should be aborted too.
>> (ert-run-tests-batch, ert-run-tests-interactively): Pass in
>> interactively arg.
>
> This commit adds a testsuite failure when I run:
> git clean -xfd && ./autogen.sh && make bootstrap && make check
>
> If I revert this commit, the failure goes away. It seems there's a call
> to ert-run-tests that hasn't been updated with a third argument.
Oops, right. I've made that argument &optional in [1: 7d27f5d8f4].
1: 2017-03-28 09:44:24 -0400 7d27f5d8f48b8f184eb93f64461e01c1481c8fb4
* lisp/emacs-lisp/ert.el (ert-run-tests): Make INTERACTIVE arg optional.
next prev parent reply other threads:[~2017-03-28 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:29 master ef44346 2/2: Make it easier to abort a series of tests with C-g Lars Brinkhoff
2017-03-28 13:48 ` Noam Postavsky [this message]
2017-03-28 17:57 ` Lars Brinkhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-_aePiE0vUr3oc04uE9Q93fZUzxNZtNcDDY4gOqNsaK3w@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=lars@nocrew.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.