From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Emacs Calc Bug: calc-cplx.el:math-imaginary-i Date: Tue, 14 Aug 2018 23:24:44 -0400 Message-ID: References: <5609bcdab92948b082877be552ce52c5@kit-msx-24.kit.edu> <20180809223951.GA26689@belanger-home> <617a497c51d8458a877d6a8ba0781820@kit-msx-24.kit.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1534303651 22383 195.159.176.226 (15 Aug 2018 03:27:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2018 03:27:31 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: =?UTF-8?B?RXJkbsO8w58sIEJhc3RpYW4gKElQRik=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 15 05:27:27 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpmT0-0005hc-Pm for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 05:27:26 +0200 Original-Received: from localhost ([::1]:47158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpmV7-00061u-Cv for ged-emacs-devel@m.gmane.org; Tue, 14 Aug 2018 23:29:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpmQR-0007K4-9R for emacs-devel@gnu.org; Tue, 14 Aug 2018 23:24:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpmQP-0007Rp-Fw for emacs-devel@gnu.org; Tue, 14 Aug 2018 23:24:47 -0400 Original-Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]:46450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpmQP-0007RZ-7U for emacs-devel@gnu.org; Tue, 14 Aug 2018 23:24:45 -0400 Original-Received: by mail-oi0-x22e.google.com with SMTP id y207-v6so37422933oie.13 for ; Tue, 14 Aug 2018 20:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=uwB/K8mOl1v0j04UgvaANnuTSQd4Xx0fECTGJ9C4jts=; b=a3WOPft4bzuxAuPfgExHIlOKzVx+eVm7piFzVl6emNcxs6VdjQZlDjo8u+Z+qEr3y/ J7QBPFJCwekwdlPcmz1IW7THnNZTyBCbVq8OUwYMJmE1hC24nDl6ODOlf8bZBaDGFtDX GfD2qRfjq0hXFqsTT7wK8DGHZ0gzWa4pb/OrkuOveqLxE19h9tW8eFkFTiRJUpnxX6/L fnMFq7lEs19xtjhExjqBKsBeax/DAzXOY30L8012wq0pvvHajCy20rMBfEJh+cmdimk6 S4GAxI9ECEuEWVoVaAvtXFBLwEIb9P5cRjGFfNHkijltduKog9Y3uogVK1pAVLgQYS06 6yug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uwB/K8mOl1v0j04UgvaANnuTSQd4Xx0fECTGJ9C4jts=; b=Sc0aIs1x8152yZ9eT44ZtvNtTQSdkEIqe/rB8wyqjkQwV6IS6sIfuEh/yoOwMzfsfn 04lVG0Kn2SrnYTc0AMeaqCa6habpu8ByL3VQospCh3+T0SoCVp6QDHmqXwswp//ArYb7 h2Wd6eQr3HpwzpWF6wgHk4vWyQxklu46WTrqeRmwrgGrOTwMiklCiDg+1qChi3yZ99Ck ROj7IxQQD7h/nvZ70/ak1P0CBw+pbaEeeBoIyfUF+m/TnytnHhgNZPK2rB01rL5ga5dX oIvRRV6MwcjC/N0x5yvxIugHZENUWBw9eVKs6DL3P0s3eKMOyU5HPUssKfUwbSGnCklt rCdA== X-Gm-Message-State: AOUpUlFO1Xe54gLPvL2vHuP+KrOw3belugE2ZCpBLInoXlkDSZyTg97w STv0scFrPGW2tO7rQzfvq0F+IlepIyFBEp0PrA0= X-Google-Smtp-Source: AA+uWPwpe7JeEprVonX9dT3lbzq2pej1vMCo1GSpgFkQR28flue9AT98EkPLpD2AejquzXaqKlML2mgSTp//jGZeei0= X-Received: by 2002:aca:100f:: with SMTP id 15-v6mr26493888oiq.110.1534303484678; Tue, 14 Aug 2018 20:24:44 -0700 (PDT) Original-Received: by 2002:a9d:268d:0:0:0:0:0 with HTTP; Tue, 14 Aug 2018 20:24:44 -0700 (PDT) In-Reply-To: <617a497c51d8458a877d6a8ba0781820@kit-msx-24.kit.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228544 Archived-At: On 10 August 2018 at 06:51, Erdn=C3=BC=C3=9F, Bastian (IPF) wrote: > During code review I think I spotted a bug in the function > math-imaginary-i at calc-cplx.el:271. > > Line 276 reads "(eq (nth 1 val) 0)" but I think it should read > "(eq (nth 0 val) 1)", i.e. the length of the complex number in > polar form should be one, instead of that the angle to the real > axis should be zero. The angle to the real axis will be taken > care of in the following line. (nth 0 val) would be the symbol `polar', so I think (eq (nth 1 val) 1) is what was intended. And the Math-equal on the next line should be checking (nth 2 val). (defun math-imaginary-i () (let ((val (calc-var-value 'var-i))) (or (eq (car-safe val) 'special-const) (equal val '(cplx 0 1)) (and (eq (car-safe val) 'polar) (eq (nth 1 val) 0) ;;;;;;; line 276 (Math-equal (nth 1 val) (math-quarter-circle nil))))))