From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) Date: Tue, 18 Jul 2017 12:23:51 -0400 Message-ID: References: <20170718103950.22436.83344@vcs0.savannah.gnu.org> <20170718103952.4E6F720E35@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1500395122 15642 195.159.176.226 (18 Jul 2017 16:25:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2017 16:25:22 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 18 18:25:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXVJC-0003bT-5m for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 18:25:14 +0200 Original-Received: from localhost ([::1]:57708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXVJH-0006KE-Lr for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 12:25:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXVHt-0004y7-Vz for emacs-devel@gnu.org; Tue, 18 Jul 2017 12:23:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXVHt-0007NX-92 for emacs-devel@gnu.org; Tue, 18 Jul 2017 12:23:53 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:36051) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXVHt-0007NQ-2A for emacs-devel@gnu.org; Tue, 18 Jul 2017 12:23:53 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id x187so21355354oig.3 for ; Tue, 18 Jul 2017 09:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=kF1cjq4t0jPKC7s23Iv6iJzLCuKrfb6jr1UqLXH6HhA=; b=oCkR6LAAdxBxaqO6S4XhlmWbltscWQoloBGuw2QysYd/KjMd5KJ2l6oYIHzBAobdhc sRFSLPSIopjAl7XMNLqeg2wZrNC9Qh/j/9dTiQ5pjzeO2OkHzURUn7HzIbpm3GsGYDzS ZRQPRbW2Zze4oqpCS4ek4uey2P1dtibZLC9H+3B5vgQuQ6X5Q621L8iG7uyRNTLcBXuB fKJxUDxTo11oMXkdXbl5OAvgAx63kE8P8gJNE9vOQzm/50galO8ZVeyDIEaPXhw82Ew2 S5yD6qU8+DoyBcpn5xR/8fzCjwJE6tDC8F179KHlUybYjoB01ngrQbFpkKDbmWrwWrBs kvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=kF1cjq4t0jPKC7s23Iv6iJzLCuKrfb6jr1UqLXH6HhA=; b=p25MTGxlLuqfb29tfqYXbKf9iHjuvbabwoEiXoX+VqidmjiGNJ2TY8IDxgd3iqhGuY fkTHCRAmw9yEjA2tioHLDzvwT1sV4hBeQQPYGxsfCuF3PhjBaJDSnULWSD069bIlNJo4 ygJyosk5mModSvPPW2ua6ylU1EkERWgQ52nWjAUxxdAaZcqwPGwZtzCbWDl78R/VjO7O BcuYAN5NZwy4U83LnvuUGmqqUuWOoiwGUNcpLex/7bX/y1R67z6aRRn7W+Tozxej/AAl 8f+agrQTjAUSLWT92TGSUwVBl9aJpkWEbQ5wG2HHXmlkkEjXubDigLVDOxMA03je8/TN WGFA== X-Gm-Message-State: AIVw1111j+XoIk1PHaImasG8eckAM6M+mW12Lxli4FaitnaMYgpwDmGX mBguxfzsYIag5jCwKsQNgK4W6UWj3A== X-Received: by 10.202.1.80 with SMTP id 77mr1406204oib.180.1500395032165; Tue, 18 Jul 2017 09:23:52 -0700 (PDT) Original-Received: by 10.74.113.91 with HTTP; Tue, 18 Jul 2017 09:23:51 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: OqxP8vy-yqqZz-ZAi8bZkvRq6w4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216846 Archived-At: On Tue, Jul 18, 2017 at 9:41 AM, Stefan Monnier wrote: >> + ;; Update `this-command' and run `pre-command-hook' so that >> + ;; things like `delete-selection-pre-hook' will work correctly. >> + (setq this-command cmd) >> + (run-hooks 'pre-command-hook) >> ;; mouse-major-mode-menu was using `command-execute' instead. >> (call-interactively cmd)))) > > Hmm... shouldn't it then also run post-command-hook, and set > last-command (and probably a few more of the things done in the usual > command loop, such as handling undo-boundaries)? I'm not sure, won't we end up with 1 1/2 of the command stuff done in that case? (the half being the popup-menu we began executing to get here).