From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 b3e2073 4/4: Fix subproc listening when setting filter to non-t (Bug#36591) Date: Thu, 22 Aug 2019 20:54:07 -0400 Message-ID: References: <20190725223622.30077.68533@vcs0.savannah.gnu.org> <20190725223624.B5F4920C06@vcs0.savannah.gnu.org> <87o90hypyo.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000004b3ca60590be3fe5" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="113978"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 23 02:55:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xrH-000TXY-IC for ged-emacs-devel@m.gmane.org; Fri, 23 Aug 2019 02:55:15 +0200 Original-Received: from localhost ([::1]:50712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xrE-0007KH-Qy for ged-emacs-devel@m.gmane.org; Thu, 22 Aug 2019 20:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45672) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xqU-0007K7-LW for emacs-devel@gnu.org; Thu, 22 Aug 2019 20:54:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0xqT-00041y-CW for emacs-devel@gnu.org; Thu, 22 Aug 2019 20:54:26 -0400 Original-Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:34949) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0xqS-00041c-Uv for emacs-devel@gnu.org; Thu, 22 Aug 2019 20:54:25 -0400 Original-Received: by mail-oi1-x22d.google.com with SMTP id a127so5824303oii.2 for ; Thu, 22 Aug 2019 17:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S1Vz0llNAW4lQzo/sjC5WTsbsTDpmbs4G0/y2atStwI=; b=S7hFaEcko5oZMeBaH//DVc6YhVQrUXklDxFxVBKhP6qD2nGqg/qJ8UJEr8Fm0WiaQ4 sBvQYzkNu1BLTO1vmV/UEJOluMq6p2TPtPlVnXS12Qaxc2nVXcMCqA1WXCkhBSPDklzt N9uUbAEt8BqrSV25ae2zvUOGmgRE816E0fHfJ0H/wy4haNtzJ2XsSjTW0ovenDJrRWaF BVL7oqwSW8bdr+yMYn6/oDqprY9uIm4t29QNfWWVUf1O18dOih9rpaBVQ+tjxi0ca+FH YxD+nJHtWBSMZPL/mTj6bSMAY8EF85l00N9O0lm/g/c+8sJpbi5i6a68Gq6HFLAlqPTG xF0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S1Vz0llNAW4lQzo/sjC5WTsbsTDpmbs4G0/y2atStwI=; b=lLx/lZm1IZBB7RsArfMKYahVkt4O1vcuo4pAfdu6SV9z4ZaRAe0saBvMFz5vNeClZb aI0s6SDVTjiD2TjNa+DykWObZwQ1M202zrjvBO9focSjK4gvZ42sEOG8riUJ61zYf4Yy 1mSMAO0jFh6wDAAZqNhxKqGBfeTpnsKsNqg86E9e+2dLT9YCkKM+dfzsGOfJDcnoE6/j yCde1d3L8lYNsuosEEGw2ao9aW8S73ub8qAkNdvh7kMCvyOOb7YJL++qm0dEAnQfDPwC kG7DrbQSF87PZXr4vju7oqkGikRprcQbXyCqluEcczCMhZUbdTa1G5woqIsy3wV/fBZG R3Rg== X-Gm-Message-State: APjAAAU9nleIWSYHRTfjUyUVWmRbgwkj9ylzCHbicgOBqIp+xUCb+s6v Y/AiQjfWgPDcoujQzpZhPTMlJl6PF7qOsvQX7NU= X-Google-Smtp-Source: APXvYqw21gmWNQzqxv2I3fHPor8rvPGwjPVqtoEqBX5xgZ1/eUQ+hCwKgkETX7Vyzhzn8s5To5UKaMRg/w0P0/PfWs8= X-Received: by 2002:aca:4d4b:: with SMTP id a72mr1328511oib.87.1566521663625; Thu, 22 Aug 2019 17:54:23 -0700 (PDT) In-Reply-To: <87o90hypyo.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239496 Archived-At: --0000000000004b3ca60590be3fe5 Content-Type: text/plain; charset="UTF-8" On Thu, 22 Aug 2019 at 15:12, Michael Albinus wrote: > > + (should > > + (accept-process-output proc 1)) ; Read "one". > > + (should (equal (buffer-string) "$ one\n$ ")) > This fails on emba occasionally, see for example > . Ah right, I wrongly assumed all the output would come in a single chunk. Attached patch should fix it, should I push to emacs-26 since tests are not included in the tarball release anyway? Or...? --0000000000004b3ca60590be3fe5 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-non-deterministic-process-test.patch" Content-Disposition: attachment; filename="0001-Fix-non-deterministic-process-test.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzneint90 RnJvbSAxYzFkZWYzNWU5ZDQ2ZGQ4ZTBlMzg1ODliNzY4NDc3ZjkxN2Q5YmVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBUaHUsIDIyIEF1ZyAyMDE5IDIwOjQ4OjE5IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IG5vbi1kZXRlcm1pbmlzdGljIHByb2Nlc3MgdGVzdAoKKiB0ZXN0L3NyYy9wcm9jZXNzLXRlc3Rz LmVsIChzZXQtcHJvY2Vzcy1maWx0ZXItdCk6IERvbid0IGFzc3VtZQpzdWJwcm9jZXNzIG91dHB1 dCB3aWxsIGNvbWUgaW4gYSBzaW5nbGUgY2h1bmssIGtlZXAgd2FpdGluZyBmb3IgbW9yZQpkYXRh IHVudGlsIG5leHQgInByb21wdCIgaXMgcmVhZCBmcm9tIHN1YnByb2Nlc3MuCi0tLQogdGVzdC9z cmMvcHJvY2Vzcy10ZXN0cy5lbCB8IDI2ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvdGVzdC9zcmMvcHJvY2Vzcy10ZXN0cy5lbCBiL3Rlc3Qvc3JjL3Byb2Nlc3MtdGVzdHMuZWwK aW5kZXggN2E2NzYyYTkyMi4uZWYwNTdhZjZiNyAxMDA2NDQKLS0tIGEvdGVzdC9zcmMvcHJvY2Vz cy10ZXN0cy5lbAorKysgYi90ZXN0L3NyYy9wcm9jZXNzLXRlc3RzLmVsCkBAIC0xNTQsMjQgKzE1 NCwzMCBAQCBzZXQtcHJvY2Vzcy1maWx0ZXItdAogICAgICAgICAgICAgICAgICAgKGNvbmNhdCBp bnZvY2F0aW9uLWRpcmVjdG9yeSBpbnZvY2F0aW9uLW5hbWUpCiAgICAgICAgICAgICAgICAgICAi LVEiICItLWJhdGNoIiAiLS1ldmFsIgogICAgICAgICAgICAgICAgICAgKHByaW4xLXRvLXN0cmlu ZwotICAgICAgICAgICAgICAgICAgICcobGV0IChzKQotICAgICAgICAgICAgICAgICAgICAgICh3 aGlsZSAoc2V0cSBzIChyZWFkLWZyb20tbWluaWJ1ZmZlciAiJCAiKSkKKyAgICAgICAgICAgICAg ICAgICAnKGxldCAoKHMgbmlsKSAoY291bnQgMCkpCisgICAgICAgICAgICAgICAgICAgICAgKHdo aWxlIChzZXRxIHMgKHJlYWQtZnJvbS1taW5pYnVmZmVyCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChmb3JtYXQgIiVkPiAiIGNvdW50KSkpCiAgICAgICAgICAgICAgICAg ICAgICAgICAocHJpbmMgcykKLSAgICAgICAgICAgICAgICAgICAgICAgIChwcmluYyAiXG4iKSkp KSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgKHByaW5jICJcbiIpCisgICAgICAgICAgICAg ICAgICAgICAgICAoc2V0cSBjb3VudCAoMSsgY291bnQpKSkpKSkpKQogICAgICAgKHNldC1wcm9j ZXNzLXF1ZXJ5LW9uLWV4aXQtZmxhZyBwcm9jIG5pbCkKICAgICAgIChzZW5kLXN0cmluZyBwcm9j ICJvbmVcbiIpCi0gICAgICAoc2hvdWxkCi0gICAgICAgKGFjY2VwdC1wcm9jZXNzLW91dHB1dCBw cm9jIDEpKSAgOyBSZWFkICJvbmUiLgotICAgICAgKHNob3VsZCAoZXF1YWwgKGJ1ZmZlci1zdHJp bmcpICIkIG9uZVxuJCAiKSkKKyAgICAgICh3aGlsZSAobm90IChlcXVhbCAoYnVmZmVyLXN1YnN0 cmluZworICAgICAgICAgICAgICAgICAgICAgICAgICAobGluZS1iZWdpbm5pbmctcG9zaXRpb24p IChwb2ludC1tYXgpKQorICAgICAgICAgICAgICAgICAgICAgICAgICIxPiAiKSkKKyAgICAgICAg KGFjY2VwdC1wcm9jZXNzLW91dHB1dCBwcm9jKSkgICA7IFJlYWQgIm9uZSIuCisgICAgICAoc2hv dWxkIChlcXVhbCAoYnVmZmVyLXN0cmluZykgIjA+IG9uZVxuMT4gIikpCiAgICAgICAoc2V0LXBy b2Nlc3MtZmlsdGVyIHByb2MgdCkgICAgICAgOyBTdG9wIHJlYWRpbmcgZnJvbSBwcm9jLgogICAg ICAgKHNlbmQtc3RyaW5nIHByb2MgInR3b1xuIikKICAgICAgIChzaG91bGQtbm90CiAgICAgICAg KGFjY2VwdC1wcm9jZXNzLW91dHB1dCBwcm9jIDEpKSAgOyBDYW4ndCByZWFkICJ0d28iIHlldC4K LSAgICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAiJCBvbmVcbiQgIikpCisgICAg ICAoc2hvdWxkIChlcXVhbCAoYnVmZmVyLXN0cmluZykgIjA+IG9uZVxuMT4gIikpCiAgICAgICAo c2V0LXByb2Nlc3MtZmlsdGVyIHByb2MgbmlsKSAgICAgOyBSZXN1bWUgcmVhZGluZyBmcm9tIHBy b2MuCi0gICAgICAoc2hvdWxkCi0gICAgICAgKGFjY2VwdC1wcm9jZXNzLW91dHB1dCBwcm9jIDEp KSAgOyBSZWFkICJ0d28iIGZyb20gcHJvYy4KLSAgICAgIChzaG91bGQgKGVxdWFsIChidWZmZXIt c3RyaW5nKSAiJCBvbmVcbiQgdHdvXG4kICIpKSkpKQorICAgICAgKHdoaWxlIChub3QgKGVxdWFs IChidWZmZXItc3Vic3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgIChsaW5lLWJlZ2lu bmluZy1wb3NpdGlvbikgKHBvaW50LW1heCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgIjI+ ICIpKQorICAgICAgICAoYWNjZXB0LXByb2Nlc3Mtb3V0cHV0IHByb2MpKSAgIDsgUmVhZCAiVHdv Ii4KKyAgICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAiMD4gb25lXG4xPiB0d29c bjI+ICIpKSkpKQogCiAoZXJ0LWRlZnRlc3Qgc3RhcnQtcHJvY2Vzcy1zaG91bGQtbm90LW1vZGlm eS1hcmd1bWVudHMgKCkKICAgImBzdGFydC1wcm9jZXNzJyBtdXN0IG5vdCBtb2RpZnkgaXRzIGFy Z3VtZW50cyBpbi1wbGFjZS4iCi0tIAoyLjExLjAKCg== --0000000000004b3ca60590be3fe5--