all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: 23533@debbugs.gnu.org
Cc: ynyaaa@gmail.com
Subject: bug#23533: 24.5; test-completion with completion-regexp-list
Date: Fri, 17 Jun 2016 00:06:44 -0400	[thread overview]
Message-ID: <CAM-tV-_Pd8214s2--jhEC3-veh5j0ROGB5WULp5LcqPnoc746w@mail.gmail.com> (raw)
In-Reply-To: <87bn497v61.fsf@gmail.com>

found 23533 25.0.95
tag 23533 + confirmed patch
quit

Yup, test-completion doesn't handle testing an alist against
completion-regexp-list. Easy to fix:

diff --git i/src/minibuf.c w/src/minibuf.c
index d85a7a9..74be5d8 100644
--- i/src/minibuf.c
+++ w/src/minibuf.c
@@ -1665,6 +1665,8 @@ DEFUN ("test-completion", Ftest_completion,
Stest_completion, 2, 3, 0,
       tem = Fassoc_string (string, collection, completion_ignore_case
? Qt : Qnil);
       if (NILP (tem))
     return Qnil;
+      else if (CONSP (tem))
+        tem = XCDR (tem);
     }
   else if (VECTORP (collection))
     {





  reply	other threads:[~2016-06-17  4:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 16:57 bug#23533: 24.5; test-completion with completion-regexp-list ynyaaa
2016-06-17  4:06 ` Noam Postavsky [this message]
2016-06-18  1:01   ` Noam Postavsky
2016-06-18  8:08     ` Eli Zaretskii
2016-06-18 17:14       ` Noam Postavsky
2016-06-18 17:29         ` Eli Zaretskii
2016-06-18 17:40           ` Noam Postavsky
2016-06-27  1:14             ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV-_Pd8214s2--jhEC3-veh5j0ROGB5WULp5LcqPnoc746w@mail.gmail.com \
    --to=npostavs@users.sourceforge.net \
    --cc=23533@debbugs.gnu.org \
    --cc=ynyaaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.