From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: master 7b1026c: * make-dist: Don't fail if building --without-makeinfo. Date: Fri, 4 May 2018 22:15:17 -0400 Message-ID: References: <20180504121034.26106.19654@vcs0.savannah.gnu.org> <20180504121035.E624020E93@vcs0.savannah.gnu.org> <8336z7tjau.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000b44a2056b6c0214" X-Trace: blaine.gmane.org 1525486416 16242 195.159.176.226 (5 May 2018 02:13:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 May 2018 02:13:36 +0000 (UTC) Cc: Glenn Morris , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 05 04:13:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEmhX-00047m-5M for ged-emacs-devel@m.gmane.org; Sat, 05 May 2018 04:13:31 +0200 Original-Received: from localhost ([::1]:37113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEmje-0006x3-35 for ged-emacs-devel@m.gmane.org; Fri, 04 May 2018 22:15:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEmjM-0006uW-Jn for emacs-devel@gnu.org; Fri, 04 May 2018 22:15:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEmjL-00073M-F8 for emacs-devel@gnu.org; Fri, 04 May 2018 22:15:24 -0400 Original-Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:36756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEmjH-00070l-O1; Fri, 04 May 2018 22:15:19 -0400 Original-Received: by mail-oi0-x232.google.com with SMTP id v2-v6so20788378oif.3; Fri, 04 May 2018 19:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5oGjcjex8e6fi1yDlZRBLx7Rqxme56oGVSUK/Ohxik8=; b=naD3/Jz0WxfJ96NjmhIllQmHnWjFfh5VG1wF3ic/8xvkMY/tdc0Yr4atkVn9eazuIJ VR2yHhNN0Hh2VsZoWAWAI7UFLTJFnmJ7F17A/H5hZxj2cqYWdbGP54o9H9CUsacrhUK5 mOxwuSoQKu1TAx5JXOb7xJbaqy4hQv4PlcjjsywuNqdYKkXEFtMQZbn4jeP1LjfyZNXB NGJfemOHG07vVYUAsOSbo8UJo6dQrG5lMJrzN6VJbHcRMg21zZfnTdpK+jA9eX0QzGVQ YVCwwEWdT9V87qwYLqJ9M6Aes9f3uTYX8zFxZAokqPZDTzaAjjtRPUH1EQqcz6e0kQCc x3CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5oGjcjex8e6fi1yDlZRBLx7Rqxme56oGVSUK/Ohxik8=; b=q6Spd8uWYbjbWs5B0euBzfKsosk4NKTJB/zjpIpLnwIZumzGSb8jD2jyoj9OJUuxhT eMKkbGPSE1JQjaxLUampmFMV1NfCz3D0YUYnPZaDShAYHiX9smw1Hq7Ev6eWQmbJa7sy lu6vGLSx6FZVX973TrQJ4WvIEQtMGDRFTQKodDu7905rMdqS0aLSTKV0w00MyrQzg9v1 ZeuH6OvhJAJSVhSG4ODS6DjwcF19ZUmcn8TbrUPX7w3awn86fOIC0YOavHrOr1sBS/54 DSD3csSn5pb3tB43N/oWU5DEiZ+dGeWHNmreirjTGFoS2xJKLYl4kvoeVgruT32pTZ+K Q8Xg== X-Gm-Message-State: ALQs6tDSnmpDBWh2a2XlUChRDWIFCNXLcCpRi9Zf8mEmMjmtOF/zClsJ QzTOiTY30Y3hBVWnLyKvjlbVYl263z+Xwqpr4QL64A== X-Google-Smtp-Source: AB8JxZqaC2Y2n4xBChCTpdqvppRzoVbMNPptLXiRkD5DGQp4sx90CDw2GC4DKs1HqPAlE5x6b1aAYjQuTTcKhrcuw/0= X-Received: by 2002:aca:500f:: with SMTP id e15-v6mr19363675oib.304.1525486518471; Fri, 04 May 2018 19:15:18 -0700 (PDT) Original-Received: by 10.74.5.135 with HTTP; Fri, 4 May 2018 19:15:17 -0700 (PDT) In-Reply-To: <8336z7tjau.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225064 Archived-At: --0000000000000b44a2056b6c0214 Content-Type: text/plain; charset="UTF-8" On 4 May 2018 at 13:36, Eli Zaretskii wrote: >> > * make-dist: Don't fail if building --without-makeinfo. >> >> I'm not sure that make-dist should allow the creation of tarfiles >> without the info files. Almost certainly not by default, anyway. > > I tend to agree. > > Noam, what was the rationale for this change? I have the automated tests setup to on my gitlab fork relying on make-dist. Up until its recent changes [1: 83a6224d60], it succeeded even though the info files weren't built. So would adding a --no-info argument (as in the attached) be okay? [1: 83a6224d60]: 2018-04-09 13:35:15 -0700 make-dist: check exit statuses more carefully https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=83a6224d607c645cadbe371c921928166da0aef0 --0000000000000b44a2056b6c0214 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-make-dist-Add-no-info-option.patch" Content-Disposition: attachment; filename="0001-make-dist-Add-no-info-option.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jgsr9ta00 RnJvbSAzZWI3MmFmNjJlZmRmZTQ3ODU3MmUwYmJkNWY5OWNjODY4MzdkMTIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBGcmksIDQgTWF5IDIwMTggMjI6MTM6MTggLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIG1h a2UtZGlzdDogQWRkICctLW5vLWluZm8nIG9wdGlvbi4KCi0tLQogbWFrZS1kaXN0IHwgOSArKysr KysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9tYWtlLWRpc3QgYi9tYWtlLWRpc3QKaW5kZXggYWJhNWM0M2M1Mi4uMTQ2NjA2 MGEyNyAxMDA3NTUKLS0tIGEvbWFrZS1kaXN0CisrKyBiL21ha2UtZGlzdApAQCAtNTEsNiArNTEs NyBAQCBjbGVhbl91cD0KIG1ha2VfdGFyPW5vCiBkZWZhdWx0X2d6aXA9Z3ppcAogbmV3ZXI9IiIK K3dpdGhfaW5mbz15ZXMKIHdpdGhfdGVzdHM9bm8KIGNoYW5nZWxvZz15ZXMKIHZlcmJvc2U9bm8K QEAgLTc3LDYgKzc4LDExIEBAIHZlcmJvc2U9CiAgICAgIi0tbm8tY2hhbmdlbG9nIiApCiAgICAg ICBjaGFuZ2Vsb2c9bm8KICAgICA7OworICAgICMjIFRoaXMgb3B0aW9ucyB0ZWxscyBtYWtlLWRp c3QgdG8gc2tpcCB0aGUgaW5mbyBmaWxlcy4gIFRoaXMgY2FuCisgICAgIyMgYmUgdXNlZnVsIGZv ciBjcmVhdGluZyBhIHRhcmJhbGwgcHVyZWx5IGZvciB0ZXN0IHB1cnBvc2VzLgorICAgICItLW5v LWluZm8iICkKKyAgICAgIHdpdGhfaW5mbz1ubworICAgICAgOzsKICAgICAjIyBUaGlzIG9wdGlv biB0ZWxscyBtYWtlLWRpc3QgdG8gbWFrZSB0aGUgZGlzdHJpYnV0aW9uIG5vcm1hbGx5LCB0aGVu CiAgICAgIyMgcmVtb3ZlIGFsbCBmaWxlcyBvbGRlciB0aGFuIHRoZSBnaXZlbiB0aW1lc3RhbXAg ZmlsZS4gIFRoaXMgaXMgdXNlZnVsCiAgICAgIyMgZm9yIGNyZWF0aW5nIGluY3JlbWVudGFsIG9y IHBhdGNoIGRpc3RyaWJ1dGlvbnMuCkBAIC0xMjQsNiArMTMwLDcgQEAgdmVyYm9zZT0KICAgICAg IGVjaG8gIiAgLS1uby1jaGVjawlkb24ndCBjaGVjayBmb3IgYmFkIGZpbGUgbmFtZXMgZXRjLiIK ICAgICAgIGVjaG8gIiAgLS1uby11cGRhdGUJZG9uJ3QgcmVjb21waWxlIG9yIGRvIGFuYWxvZ291 cyB0aGluZ3MiCiAgICAgICBlY2hvICIgIC0tbm8tY2hhbmdlbG9nCWRvbid0IGdlbmVyYXRlIHRo ZSB0b3AtbGV2ZWwgQ2hhbmdlTG9nIgorICAgICAgZWNobyAiICAtLW5vLWluZm8JCWRvbid0IGlu Y2x1ZGUgaW5mbyBmaWxlcyIKICAgICAgIGVjaG8gIiAgLS1zbmFwc2hvdAlzYW1lIGFzIC0tY2xl YW4tdXAgLS1uby11cGRhdGUgLS10YXIgLS1uby1jaGVjayIKICAgICAgIGVjaG8gIiAgLS10YXIJ CW1ha2UgYSB0YXIgZmlsZSIKICAgICAgIGVjaG8gIiAgLS10ZXN0cwlpbmNsdWRlIHRoZSB0ZXN0 LyBkaXJlY3RvcnkiCkBAIC01OTYsNyArNjAzLDcgQEAgZmlsZXM9CiAgIGxuICRmICR0ZW1wZGly LyRmIHx8IGV4aXQKIGRvbmUKIAotaWYgWyAtZCBpbmZvIF07IHRoZW4gIyBTa2lwIGluIGNhc2Ug d2UndmUgYnVpbHQgLS13aXRob3V0LW1ha2VpbmZvLgoraWYgWyAiJHdpdGhfaW5mbyIgPSAieWVz IiBdOyB0aGVuCiAgIGVjaG8gIk1ha2luZyBsaW5rcyB0byAnaW5mbyciCiAgIGxuIGBmaW5kIGlu Zm8gLXR5cGUgZiAtcHJpbnRgICR7dGVtcGRpcn0vaW5mbyB8fCBleGl0CiBmaQotLSAKMi4xMS4w Cgo= --0000000000000b44a2056b6c0214--