From: Noam Postavsky <npostavs@users.sourceforge.net>
To: 23649@debbugs.gnu.org
Subject: bug#23649: 24.5; `customize-mode'
Date: Fri, 24 Jun 2016 23:14:08 -0400 [thread overview]
Message-ID: <CAM-tV-_+OePjNue+iQ=kpNTfXryLigOyHFDy8W4odP2CvjCFww@mail.gmail.com> (raw)
In-Reply-To: <aff6f22d-3221-4166-9dbc-747edae94c2e@default>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
tag 23649 + patch
quit
> Example mode-string, corrected:
>
> "Customize options related to a major or minor mode.
> By default the current major mode is used.
> With a prefix argument or if the current major mode has no known group,
> you are prompted for the MODE to customize."
> 3. The prompt is thus incorrect as well: the candidates are not
> necessarily major-mode names. It should just say "Mode: ".
Looks good to me, so I propose to push the attached patch with this
docstring (and removal of "Major" from the prompts) to emacs-25. Any
objections?
[-- Attachment #2: 0001-Fix-docstring-and-prompt-for-customize-mode.patch --]
[-- Type: text/x-patch, Size: 1490 bytes --]
From c8ddd4f66e8cfec42c5b443511a6d7f37a1b7029 Mon Sep 17 00:00:00 2001
From: Drew Adams <drew.adams@oracle.com>
Date: Fri, 24 Jun 2016 22:50:24 -0400
Subject: [PATCH 1/2] Fix docstring and prompt for customize-mode
* lisp/cus-edit.el (customize-mode): This function works with both major
and minor modes, make docstring and prompt reflect that (Bug #23649).
---
lisp/cus-edit.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index d7db353..7826506 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -1072,9 +1072,10 @@ customize
;;;###autoload
(defun customize-mode (mode)
- "Customize options related to the current major mode.
-If a prefix \\[universal-argument] was given (or if the current major mode has no known group),
-then prompt for the MODE to customize."
+ "Customize options related to a major or minor mode.
+By default the current major mode is used. With a prefix
+argument or if the current major mode has no known group, prompt
+for the MODE to customize."
(interactive
(list
(let ((completion-regexp-list '("-mode\\'"))
@@ -1083,8 +1084,8 @@ customize-mode
major-mode
(intern
(completing-read (if group
- (format "Major mode (default %s): " major-mode)
- "Major mode: ")
+ (format "Mode (default %s): " major-mode)
+ "Mode: ")
obarray
'custom-group-of-mode
t nil nil (if group (symbol-name major-mode))))))))
--
2.8.0
next prev parent reply other threads:[~2016-06-25 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 21:40 bug#23649: 24.5; `customize-mode' Drew Adams
2016-06-25 3:14 ` Noam Postavsky [this message]
2016-06-25 4:25 ` bug#23649: `customize-mode' Drew Adams
2016-06-25 8:03 ` bug#23649: 24.5; `customize-mode' Eli Zaretskii
2016-06-25 13:08 ` Noam Postavsky
2016-06-25 13:09 ` Eli Zaretskii
2016-06-25 17:35 ` Noam Postavsky
2016-06-25 20:44 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-_+OePjNue+iQ=kpNTfXryLigOyHFDy8W4odP2CvjCFww@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=23649@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.