From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Fix to handling of C++ digit separators, improvements in handling of single quotes. Date: Sat, 1 Jul 2017 23:35:41 -0400 Message-ID: References: <20170701161008.GB8743@acm> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a113d6a744d3d3e05534d58b4" X-Trace: blaine.gmane.org 1498966585 1694 195.159.176.226 (2 Jul 2017 03:36:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Jul 2017 03:36:25 +0000 (UTC) Cc: Emacs developers To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 02 05:36:20 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRVgJ-0008RN-Qt for ged-emacs-devel@m.gmane.org; Sun, 02 Jul 2017 05:36:19 +0200 Original-Received: from localhost ([::1]:56622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRVgL-00089T-NA for ged-emacs-devel@m.gmane.org; Sat, 01 Jul 2017 23:36:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRVfm-00089C-FR for emacs-devel@gnu.org; Sat, 01 Jul 2017 23:35:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRVfl-0003vh-F6 for emacs-devel@gnu.org; Sat, 01 Jul 2017 23:35:46 -0400 Original-Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:34576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRVfl-0003uU-9z for emacs-devel@gnu.org; Sat, 01 Jul 2017 23:35:45 -0400 Original-Received: by mail-oi0-x22c.google.com with SMTP id l130so62842787oib.1 for ; Sat, 01 Jul 2017 20:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=qq4WpuFORHI7OD2N5HB0Cp8RwtYRixwjYBrro/Fjzk0=; b=M8K2eQz10S9ixrmPr6Un49UgQPBaPSOZUZX8m3bEWlLN3cpIMg0DCLSUZvRK5GOjeQ r3ySV/29NIqwMDvcNZ/bqNjgtdR1AdPxaKNJmMeO+FdCX3deYr5DbtWr6ZsTMgJGyTDO vMkOvhOWGpNczi+0OyR4HHhS0ghClOKy/lw8jGU95deyc3QTJxUnBg8CSyKIx6JC+BBh Lux98ZiEMaFMlbiUMDSOKWSzi71mGZFqiFe16FsWc/4aUJ2irQTOAzf1FFqIVFlA+4vQ Ay6c4MnssdDwgkLI/W0u/CSAX8n9AGV/YQqiSqtxOkxTN+1g1fZlqQajB19/LIQwsAaY NpeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=qq4WpuFORHI7OD2N5HB0Cp8RwtYRixwjYBrro/Fjzk0=; b=roTjPldUZ685pi58sVzUJ4gata7kvIPgxKMQVDMHcj1JGo6FOBTDORRBN4UmcfzTGc Azs22qvzvOtWOee5OhjjjncikZ13AzPd+DhtvI66HsPLZNIN+J4bAJSnUv50W0h+iPLv 2sdYmZbQW8el80EglGpJojZ0la8s+w1UE0Y14ZcXskGsMYTAb6+R9iNlVbPojcw3+j/p eojldrtGEqIycavuEJ9BlHbkRdxp6cXkiD7HVUX0HyDrBm6g3wrGmpsjKzHFzrQmlGDe sz8OsIk9SuKYJhotHR6ZCtNBRacSG4gyAhoq2are4gSC1qg8ve7ZPgIdzKjqfcKhbmLa Wigg== X-Gm-Message-State: AKS2vOygHcv3pdz3KKF1405Q6d6XmoDSOUVTCVJnXcSMZ5EKj/RzzP/v U2kzPIejggazrYDrOg/Qb3F3CGYRovBz X-Received: by 10.202.80.66 with SMTP id e63mr18350529oib.152.1498966542589; Sat, 01 Jul 2017 20:35:42 -0700 (PDT) Original-Received: by 10.74.113.91 with HTTP; Sat, 1 Jul 2017 20:35:41 -0700 (PDT) In-Reply-To: <20170701161008.GB8743@acm> X-Google-Sender-Auth: S8n6H5MiK-QrH82V7_IkAd-lzN0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216084 Archived-At: --001a113d6a744d3d3e05534d58b4 Content-Type: text/plain; charset="UTF-8" On Sat, Jul 1, 2017 at 12:10 PM, Alan Mackenzie wrote: > The code involved is moderately involved, with special cases needed to > handle things like '\'', '\\', or char foo [] = {',',',',',',','};. So > if there are any problems with it (in particular, large areas of text > following a quotey bit getting misfontified with font-lock-string-face), > please let me know. I think this change breaks tests/lisp/electric-tests.el, here's a reduced test case (backtrace attached) (with-temp-buffer (c++-mode) (insert " (((()) ") (goto-char 4) (insert ")")) --001a113d6a744d3d3e05534d58b4 Content-Type: application/octet-stream; name="c-quotes.backtrace" Content-Disposition: attachment; filename="c-quotes.backtrace" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4m5q8v20 RGVidWdnZXIgZW50ZXJlZC0tTGlzcCBlcnJvcjogKGFyZ3Mtb3V0LW9mLXJhbmdlIDAgMCkKICBn ZXQtdGV4dC1wcm9wZXJ0eSgwIHN5bnRheC10YWJsZSkKICBjLWNsZWFyLWNoYXItcHJvcGVydHkt d2l0aC12YWx1ZS1vbi1jaGFyLWZ1bmN0aW9uKDAgNCBzeW50YXgtdGFibGUgKDEpIDM5KQogIGMt cGFyc2UtcXVvdGVzLWJlZm9yZS1jaGFuZ2UoNCA0KQogICNmKGNvbXBpbGVkLWZ1bmN0aW9uIChm bikgIzxieXRlY29kZT4pKGMtcGFyc2UtcXVvdGVzLWJlZm9yZS1jaGFuZ2UpCiAgbWFwYygjZihj b21waWxlZC1mdW5jdGlvbiAoZm4pICM8Ynl0ZWNvZGU+KSAoYy1leHRlbmQtcmVnaW9uLWZvci1D UFAgYy1iZWZvcmUtY2hhbmdlLWNoZWNrLXJhdy1zdHJpbmdzIGMtYmVmb3JlLWNoYW5nZS1jaGVj ay08Pi1vcGVyYXRvcnMgYy1kZXByb3BlcnRpemUtQ1BQIGMtaW52YWxpZGF0ZS1tYWNyby1jYWNo ZSBjLXRydW5jYXRlLWJzLWNhY2hlIGMtcGFyc2UtcXVvdGVzLWJlZm9yZS1jaGFuZ2UpKQogIGMt YmVmb3JlLWNoYW5nZSg0IDQpCiAgaW5zZXJ0KCIpIikKICAocHJvZ24gKGMrKy1tb2RlKSAoaW5z ZXJ0ICIgKCgoKCkpICIpIChnb3RvLWNoYXIgNCkgKGluc2VydCAiKSIpKQogICh1bndpbmQtcHJv dGVjdCAocHJvZ24gKGMrKy1tb2RlKSAoaW5zZXJ0ICIgKCgoKCkpICIpIChnb3RvLWNoYXIgNCkg KGluc2VydCAiKSIpKSAoYW5kIChidWZmZXItbmFtZSB0ZW1wLWJ1ZmZlcikgKGtpbGwtYnVmZmVy IHRlbXAtYnVmZmVyKSkpCiAgKHNhdmUtY3VycmVudC1idWZmZXIgKHNldC1idWZmZXIgdGVtcC1i dWZmZXIpICh1bndpbmQtcHJvdGVjdCAocHJvZ24gKGMrKy1tb2RlKSAoaW5zZXJ0ICIgKCgoKCkp ICIpIChnb3RvLWNoYXIgNCkgKGluc2VydCAiKSIpKSAoYW5kIChidWZmZXItbmFtZSB0ZW1wLWJ1 ZmZlcikgKGtpbGwtYnVmZmVyIHRlbXAtYnVmZmVyKSkpKQogIChsZXQgKCh0ZW1wLWJ1ZmZlciAo Z2VuZXJhdGUtbmV3LWJ1ZmZlciAiICp0ZW1wKiIpKSkgKHNhdmUtY3VycmVudC1idWZmZXIgKHNl dC1idWZmZXIgdGVtcC1idWZmZXIpICh1bndpbmQtcHJvdGVjdCAocHJvZ24gKGMrKy1tb2RlKSAo aW5zZXJ0ICIgKCgoKCkpICIpIChnb3RvLWNoYXIgNCkgKGluc2VydCAiKSIpKSAoYW5kIChidWZm ZXItbmFtZSB0ZW1wLWJ1ZmZlcikgKGtpbGwtYnVmZmVyIHRlbXAtYnVmZmVyKSkpKSkKICBldmFs KChsZXQgKCh0ZW1wLWJ1ZmZlciAoZ2VuZXJhdGUtbmV3LWJ1ZmZlciAiICp0ZW1wKiIpKSkgKHNh dmUtY3VycmVudC1idWZmZXIgKHNldC1idWZmZXIgdGVtcC1idWZmZXIpICh1bndpbmQtcHJvdGVj dCAocHJvZ24gKGMrKy1tb2RlKSAoaW5zZXJ0ICIgKCgoKCkpICIpIChnb3RvLWNoYXIgNCkgKGlu c2VydCAiKSIpKSAoYW5kIChidWZmZXItbmFtZSB0ZW1wLWJ1ZmZlcikgKGtpbGwtYnVmZmVyIHRl bXAtYnVmZmVyKSkpKSkgbmlsKQogIGVsaXNwLS1ldmFsLWxhc3Qtc2V4cChuaWwpCiAgZXZhbC1s YXN0LXNleHAobmlsKQogIGZ1bmNhbGwtaW50ZXJhY3RpdmVseShldmFsLWxhc3Qtc2V4cCBuaWwp CiAgY2FsbC1pbnRlcmFjdGl2ZWx5KGV2YWwtbGFzdC1zZXhwIG5pbCBuaWwpCiAgY29tbWFuZC1l eGVjdXRlKGV2YWwtbGFzdC1zZXhwKQo= --001a113d6a744d3d3e05534d58b4--