From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Submitting patches: need I do more than send them to the bug tracker? Date: Sat, 27 Oct 2018 18:24:18 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1540678962 8013 195.159.176.226 (27 Oct 2018 22:22:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2018 22:22:42 +0000 (UTC) Cc: Emacs developers To: slippycheeze@google.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 28 00:22:38 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGWyc-0001zc-3i for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2018 00:22:38 +0200 Original-Received: from localhost ([::1]:38011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGX0i-0001xB-KA for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2018 18:24:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGX0a-0001x6-3i for emacs-devel@gnu.org; Sat, 27 Oct 2018 18:24:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGX0W-0005sx-PX for emacs-devel@gnu.org; Sat, 27 Oct 2018 18:24:38 -0400 Original-Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]:35544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGX0U-0005sC-0i for emacs-devel@gnu.org; Sat, 27 Oct 2018 18:24:34 -0400 Original-Received: by mail-ot1-x331.google.com with SMTP id 14so4293341oth.2 for ; Sat, 27 Oct 2018 15:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0bo1W5JZhtKlBdBJ2bMxn8vFwD/O+7Ovqqa2PMnZTcM=; b=F4ti7witFu56THW6SI9/CUOCy48soKjQIeTe3kqhWmC1k8LPNYxOWPQMlm9YalfQeH V/bH3V7kpxYSJdMOFiA/hQiyuH6ukvAYqWnrFeFkCW09vaJtoonNZE5FSANugMoD96Y1 brazs7fCZjqvOcQ1KH0zxzE4TEKeWorTYSaok2Uu/pQueTqwrgvctVWBy6nuIOHoeV8P uNeX74g7Ddd3qH9O5u7niViI6meP2Po89Zy9Zv42yH4joTv3K6ki7pXKgGPZ/chqhMtU sCrcqR//pkqvFl/t9q6P24DtRJ6K+l5Nc+iVBzr6a2uhkl66DcIsiZrnCvZSetStDboV P3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0bo1W5JZhtKlBdBJ2bMxn8vFwD/O+7Ovqqa2PMnZTcM=; b=lTIzBDCVBjs1nRJd0mRh62NCx5iVwAdZ6IT9PWXnxvIiaUyI+ua/Pts8vC4FbBZmWf Mp0gEUfH+3YrYScQCTYSqYyxyLdIkScgQ2J6jIHiyNFDgtPyc+lBx0wqfiA4FUAwWqi2 ThY7ODTr4ILR9QQKNoEhppIPXwwMHcvlUw+AHYiheJIkjjoiWzTGpAbzsuH0DTFUDc4j DN+WJW/nNCJKlMgy+CBhKxP8xbKuDOqbVzA7NlE+s00KbOyx6+ugk0y4nopyJk0LeGiQ R58RJrbnKCKosyEXBiFIs6RHcOZv/ty7OjKXFsiGYulkQYfrtG3GhDVf9C0/yV3Y7R1v XK1Q== X-Gm-Message-State: AGRZ1gIhGXsaOEr07kCyXY3SUa/rnZ66Hed5bUAlwfnlbqfxFk+HWKzG cgevqi2PNXdt9bfcs3Av+SAyKPvSCZnt6FrBBBg= X-Google-Smtp-Source: AJdET5cyOdnb0xwHAtNkOQQDioShNL9Df/bJOhJH+YnBzWt/4d3byW1oqls1mXTNTpUyOWmbPNaa6b6RWJlpNjuibps= X-Received: by 2002:a9d:6846:: with SMTP id c6mr5499337oto.65.1540679072050; Sat, 27 Oct 2018 15:24:32 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::331 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230740 Archived-At: On Wed, 24 Oct 2018 at 10:15, Daniel Pittman wrote: > I have a couple of patches in the bug tracker at the moment, one feature, and one bug fix, which have attracted no response. In the former case it has been five days, which I had assumed would be enough time to get some sort of response. > > Now, I'm not asking for special treatment, or someone to rush and review the code, but rather, to ensure that I have done all the right things to get this into the queue for Emacs. I'd rather ask than miss something. If you don't get a response to a patch, sending a short message to make sure it hasn't gotten lost like you've done is the right thing to do. I would generally say to wait a full week. > The two tickets in question are: > > Feature added to emacsclient, five days old: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33095 > > Bug fix for `vc-hg-find-file-hook', one day old: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33129 > > Again, if getting them there is all that was needed, great, and I'm happy for them to be reviewed at whatever schedule suits you best. I see Eli has by now applied the first one; the second looks reasonable, though not being an hg user, I'd hesitate to apply it myself.