From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)) Date: Sat, 17 Dec 2016 09:59:56 -0500 Message-ID: References: <20161203014504.8507.42564@vcs.savannah.gnu.org> <20161203014505.D8E2D2201C6@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1481986811 3743 195.159.176.226 (17 Dec 2016 15:00:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Dec 2016 15:00:11 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 17 16:00:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIGSz-00086D-LW for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 16:00:05 +0100 Original-Received: from localhost ([::1]:36960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIGT4-0006MQ-2U for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 10:00:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIGSs-0006F8-SZ for emacs-devel@gnu.org; Sat, 17 Dec 2016 10:00:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIGSr-0005KD-NE for emacs-devel@gnu.org; Sat, 17 Dec 2016 09:59:58 -0500 Original-Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:36189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIGSr-0005Js-IS for emacs-devel@gnu.org; Sat, 17 Dec 2016 09:59:57 -0500 Original-Received: by mail-oi0-x229.google.com with SMTP id v84so105698717oie.3 for ; Sat, 17 Dec 2016 06:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=hhE3AhjjUz+yxYcW2IYVw+oQS5QYf3r/ORx5+5eqCo8=; b=fP1xI+z5+9e3Ajh5Gbj/LDNmjsHqsd00ThwE+qJJ0hWZD83OKeYLzagarVGCrzGtub 4UaPgvMTuHNTKg2ss0DRIos7CLAaD+K3rt5DzyqDB9Zw1n2DIMZgWmVE7flTGK6ONLcq 0JTI4Ni0GlN8d2GnIhPoWSVTTTpS2vfCKEAcfJTs9m7vRBgrRTfMkG/NBTMM1JwrfGJR ZS1LTGVK+v+0theATuqhh0RD5h66q8+lL4YCnBWxZpdFaTx0VOxHN7g9NwvRVB8RQOmT bGC4/Qrr4ubz9T1kg5MJ3+IWMuANy7DnW9rrIcL7fkbXYOha8SHvDN+BPjWwb41qphU4 yf+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=hhE3AhjjUz+yxYcW2IYVw+oQS5QYf3r/ORx5+5eqCo8=; b=m0C3RysFNG7zW1MzuK/NiGG5vFrAd+9gsDMIcP4S8qhXp4adJ49vUvhF1eS0LowiZc hfRyRJVisexzvjsb/xvO7CTfiYUYwRhbKiICLmvh/oGICeQ69q9vKltD8k6fv+xx5LA6 Vn/jpoXLgP4AJ5TRhT8mIMI0Ve7vH9CvUCgvq/pPN7wCOZx+/OF+AVRXkZFh85XVbCuZ x7CVEQk9AhNvcXXCF+1+Hx9fpFgWLGCLiEoa+WMVMbAGrlfkRfZt6jXIgsdeN7xaeLZn QC5+CHkKBHqUjTJdLrF+sZ/oo8HNRg4SmIQA2TRkZgFmBe0KKHgU3tUjmc2Od6C6kHV0 3KLw== X-Gm-Message-State: AIkVDXJCG8VbjYwSshxvQ93lZHruglqu883/6njiRnTNu5HgjITYSIgsOgWyNEZn/cirhjZqgkQPgbdkM5iN0A== X-Received: by 10.202.63.65 with SMTP id m62mr4948188oia.167.1481986796790; Sat, 17 Dec 2016 06:59:56 -0800 (PST) Original-Received: by 10.157.6.234 with HTTP; Sat, 17 Dec 2016 06:59:56 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: jp94piAGQxuvPjwwWoSVJaqgYHY X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210585 Archived-At: On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier wrote: > Ping? > > I'll take care of the patch, if we agree, > > > Stefan > > >>>>>> "Stefan" == Stefan Monnier writes: > >>> + else if (sym->redirect == SYMBOL_LOCALIZED >>> + && SYMBOL_BLV (sym)->frame_local) >>> + xsignal1 (Qtrapping_frame_local, symbol); > >> BTW, make-variable-frame-local has been declared obsolete since >> Emacs-22.2, so I think now is a good time to get rid of >> frame-local variables. > I did a web search for make-variable-frame-local, I found only perspective-el still using it. I think it's a fairly popular package; on the other hand, it's not in GNU ELPA, and it's not like they didn't have warning in advance... https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197 ;; make-variable-frame-local is obsolete according to the docs, ;; but I don't want to have to manually munge frame-parameters ;; all the time so I'm using it anyway. (make-variable-frame-local