all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Phillip Lord <phillip.lord@russet.org.uk>
Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: replacing ldefs-boot.el
Date: Sat, 26 Nov 2016 00:34:34 -0500	[thread overview]
Message-ID: <CAM-tV-9pCxzkMkL5sv+yKX1Cv1Q7=XsxfrkhbEdTqy1mz04_bQ@mail.gmail.com> (raw)
In-Reply-To: <87eg1zmdd7.fsf@russet.org.uk>

On Fri, Nov 25, 2016 at 4:57 PM, Phillip Lord
<phillip.lord@russet.org.uk> wrote:
> Noam Postavsky <npostavs@users.sourceforge.net> writes:
>>> Disadvantages:
>>>
>>>  - generating ldefs-boot-auto is a lot slower (i.e. cp loaddefs.el
>>>    ldefs-boot.el vs a complete bootstrap build of Emacs).
>>>
>>
>> Is it possible another disadvantage would be that ldefs-boot-auto
>> requires regeneration more often (because the list of autoloads used
>> is more precise)?
>
>
> No, I don't think that this is the case. ldefs-boot.el is actually
> regenerated regularly IIUC (I think Glenn does it on a cron job; or he
> gets up specially at 6am on the first of every month). And it changes
> each time since it reflects changes in any autoloads any where in Emacs
> (nearly), including things like documentation changes.

Oh, I didn't notice the frequency, I somehow had the impression it
just done as needed.

>
> I have no idea what percentage of those commits are actually necessary
> -- the unfortunate reality is that you can only test this with a full
> bootstrap build which is something that most developers do rarely.

My guess is that with the smaller ldefs-boot-auto it will be necessary
more often. But maybe not enough to matter, hard to say.

>
>
>> I notice several almost duplicated lines in ldefs-boot-auto.el, like
>>
>> (autoload 'byte-compile "bytecomp" nil nil nil)
>> (autoload 'byte-compile "bytecomp" nil nil t)
>>
>> byte-compile isn't a macro; I think you should put your addition to
>> Fautoload_do_load after the "if (EQ (macro_only, Qmacro))" check to
>> avoid falsely identifying macros.
>
> Yeah, that's a screw up, thanks for picking this up.
>
> I don't understand the semantics of the macro_only parameter, at all,
> nor what that if statement is doing, but I'll try this fix.

I think the value of FUNDEF tells you whether it's a macro, the
macro_only parameter just says to do nothing for non-macros.

>
>> And doesn't this change in Makefile.in break parallel 'make bootstrap'
>> invocations?
>>
>> -bootstrap: bootstrap-clean
>> +bootstrap: bootstrap-clean bootstrap-build
>> +
>> +bootstrap-build:
>
> Does it? bootstrap-clean and bootstrap-build cannot be run in parallel
> anyway.

Right. And I think the definitions you put would let make run them in
parallel, thus breaking things.



  reply	other threads:[~2016-11-26  5:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20 17:46 replacing ldefs-boot.el Phillip Lord
2016-11-20 19:23 ` Eli Zaretskii
2016-11-20 21:28   ` Phillip Lord
2016-11-21  3:27     ` Eli Zaretskii
2016-11-21 22:03       ` Phillip Lord
2016-11-25 11:23         ` Phillip Lord
2016-11-25 13:28           ` Eli Zaretskii
2016-11-25 18:10             ` Paul Eggert
2016-11-25 19:31               ` Eli Zaretskii
2016-11-25 20:11                 ` Stefan Monnier
2016-11-26  6:46                   ` Eli Zaretskii
2016-11-26 12:08                     ` Phillip Lord
2016-11-25 21:34                 ` Phillip Lord
2016-11-25 23:18                   ` Óscar Fuentes
2016-11-26 20:59                     ` Phillip Lord
2016-11-27 20:14               ` Nicolas Petton
2016-11-25 21:11         ` Noam Postavsky
2016-11-25 21:57           ` Phillip Lord
2016-11-26  5:34             ` Noam Postavsky [this message]
2016-11-26 12:19               ` Phillip Lord
2016-11-27 23:04                 ` Noam Postavsky
2016-11-29 14:57                   ` Phillip Lord
2016-11-27 21:19         ` Phillip Lord
2016-12-13 12:17 ` Phillip Lord
2016-12-13 14:02   ` Noam Postavsky
2016-12-14 11:53     ` Phillip Lord
2016-12-13 14:58   ` John Wiegley
2016-12-13 16:08   ` Eli Zaretskii
2016-12-14 12:00     ` Phillip Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM-tV-9pCxzkMkL5sv+yKX1Cv1Q7=XsxfrkhbEdTqy1mz04_bQ@mail.gmail.com' \
    --to=npostavs@users.sourceforge.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.