From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23574@debbugs.gnu.org, Colin Woodbury <cwoodbury@azavea.com>,
John Mastro <john.b.mastro@gmail.com>
Subject: bug#23574: 24.5; Overzealous underlining in emacs-nox
Date: Tue, 7 Jun 2016 22:52:25 -0400 [thread overview]
Message-ID: <CAM-tV-9kON0X78KEEwD5=w-nqDSceYLAfkbCDXdTF9sVrSxJdw@mail.gmail.com> (raw)
In-Reply-To: <83bn3dro1g.fsf@gnu.org>
On Tue, Jun 7, 2016 at 11:55 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Noam Postavsky <npostavs@users.sourceforge.net>
>> Date: Mon, 6 Jun 2016 20:18:06 -0400
>> Cc: Colin Woodbury <cwoodbury@azavea.com>, martin rudalics <rudalics@gmx.at>, 23574@debbugs.gnu.org,
>> John Mastro <john.b.mastro@gmail.com>
>>
>> I think it makes sense to not do the face extension by default.
>
> Not even for the background color? Or are you talking only about the
> underline?
Well, I was thinking mostly about underlining, but imagining a
scenario with paper again, if I'm highlighting text with a marker, I
wouldn't go to edge of the page there either.
For some applications, the intention is to colour a whole block, not
just the text. So I think it's better to let the code making the faces
have a way to indicate which scenario is intended rather than relying
on user customization.
>
>> For the case I mentioned earlier, magit isn't actually underlining
>> text, it just wants to make some horizontal lines. It would be nice to
>> have some way to ask the display engine to do this directly.
>
> There's a way of doing that which we use in the VC commit log buffer,
> I believe it uses the line-height property. (I thought magit was
> using that as well, no?)
Yes, and it caused some problems with cursor movement that you weren't
so happy about fixing.
next prev parent reply other threads:[~2016-06-08 2:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 17:03 bug#23574: 24.5; Overzealous underlining in emacs-nox Colin Woodbury
2016-05-30 15:04 ` Colin Woodbury
2016-06-04 7:48 ` Eli Zaretskii
[not found] ` <CAHuwsfihHJ8WHwmHvMDF7Ynns4YOJSKEEbjhpbYrw0V=5aYXEQ@mail.gmail.com>
2016-06-04 16:20 ` Eli Zaretskii
2016-06-04 21:37 ` John Mastro
2016-06-05 15:54 ` Eli Zaretskii
2016-06-05 17:05 ` Noam Postavsky
2016-06-05 17:56 ` Eli Zaretskii
2016-06-05 18:20 ` Colin Woodbury
2016-06-05 18:36 ` Eli Zaretskii
2016-06-05 19:13 ` Noam Postavsky
2016-06-06 2:27 ` Eli Zaretskii
2016-06-06 11:42 ` Noam Postavsky
2016-06-06 15:04 ` Eli Zaretskii
2016-06-06 16:54 ` martin rudalics
2016-06-06 18:25 ` Colin Woodbury
2016-06-06 19:18 ` Eli Zaretskii
2016-06-07 0:18 ` Noam Postavsky
2016-06-07 15:55 ` Eli Zaretskii
2016-06-08 2:52 ` Noam Postavsky [this message]
2016-06-06 18:55 ` Eli Zaretskii
2016-06-07 9:10 ` martin rudalics
2016-06-07 15:50 ` Eli Zaretskii
2016-06-08 6:33 ` martin rudalics
2016-06-08 17:05 ` Eli Zaretskii
2016-06-09 8:38 ` martin rudalics
2016-06-09 12:26 ` Eli Zaretskii
2016-06-10 7:16 ` martin rudalics
2016-06-10 8:10 ` Eli Zaretskii
2016-06-10 8:24 ` martin rudalics
2016-06-10 9:50 ` Eli Zaretskii
2016-06-10 13:59 ` martin rudalics
2016-06-10 14:24 ` Eli Zaretskii
2019-10-21 11:49 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08 5:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-9kON0X78KEEwD5=w-nqDSceYLAfkbCDXdTF9sVrSxJdw@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=23574@debbugs.gnu.org \
--cc=cwoodbury@azavea.com \
--cc=eliz@gnu.org \
--cc=john.b.mastro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.