From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames Date: Fri, 26 Jan 2018 17:11:17 -0500 Message-ID: References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1517004616 26602 195.159.176.226 (26 Jan 2018 22:10:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Jan 2018 22:10:16 +0000 (UTC) Cc: 30243@debbugs.gnu.org, Philipp Stephani To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 26 23:10:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efCCH-0006ZQ-OJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jan 2018 23:10:09 +0100 Original-Received: from localhost ([::1]:57740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efCEI-0001aA-7u for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jan 2018 17:12:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efCEB-0001Zs-8B for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2018 17:12:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efCE7-00052x-7r for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2018 17:12:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efCE7-00052n-1w for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2018 17:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efCE6-0006Wz-Sq for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2018 17:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2018 22:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30243-submit@debbugs.gnu.org id=B30243.151700468825050 (code B ref 30243); Fri, 26 Jan 2018 22:12:02 +0000 Original-Received: (at 30243) by debbugs.gnu.org; 26 Jan 2018 22:11:28 +0000 Original-Received: from localhost ([127.0.0.1]:44119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efCDY-0006Vx-DD for submit@debbugs.gnu.org; Fri, 26 Jan 2018 17:11:28 -0500 Original-Received: from mail-wm0-f50.google.com ([74.125.82.50]:37551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efCDT-0006VU-BU for 30243@debbugs.gnu.org; Fri, 26 Jan 2018 17:11:24 -0500 Original-Received: by mail-wm0-f50.google.com with SMTP id v71so23866979wmv.2 for <30243@debbugs.gnu.org>; Fri, 26 Jan 2018 14:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=pI+939pzQAnTG9PBkGxMQJODWsQGIadpjJ2Ab1Sd5KI=; b=OtyorzhGG+gwTx0ksZY1t+0XjIJdaBOJa76DCVAyED6BLp73IwITaLDy6Y2Kv8EiPX 3NCwAF4ZYmniLhAqrNVq60hAVjrYYON9Xqx/sBMcG9m0J89njGKn2DSHy6izH+REpEC1 sJb1+84S3LZQgAFRCmzzmrFzJOL3eiSK0nwZ8vnu3CQThjAEBZ8u07oTwTQACJlvSXxK 4WIXWBOLU9yPN+sBgVyJ07BhYHjxIkd8I/9kRI3NEoOvwGo3mJYEtyhm9/0+X2tSkG7K 6dCHh3qJRP/RcuwAgABRCOJ7QajIOn+d79Z3m9ksGiOfbpztRK1Oa834ob3tKBES7DVm XlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=pI+939pzQAnTG9PBkGxMQJODWsQGIadpjJ2Ab1Sd5KI=; b=Oyb3OSvtGS+aCvbB4H671rSGQeokO2YKLxmqjvx1QGP/DrjaaDFdOnb9W2x4MCkoi6 1DQqhwYCH+qWyYPs10wmbgRPuXZOMGj6dxKr8irjYOGXlUmuMFqaruT55CD8Em3mS3CW 6O1QFqqif7450rXLC5W+9SOKnlE1Co92KWOXS1+w7HfVZdUbwakKSq0NMdfzhQV83C56 NbJCS6gNgzo2ELUAXC1fnkdDw6WsO3LfGRLhKIJRgJrfadmbxE0mQoxF6PzMRja0kMsq NQls5BA5S1JnXVsTu3USSt60UaIJ0oZm8qbM/d70jESW/3Als7avUOv1mQi0tyFLsINg nMYQ== X-Gm-Message-State: AKwxyteY5VPZfm+k861J44XWsSFxGVSq2eYEB6nQaYUqnyO6dKKwzgy5 benRjkaI+/xUG7WMNSBRUlRyhfvu9Mv/5+3FfYc= X-Google-Smtp-Source: AH8x2249XDuY9M0BHlx90HR/G5mbVaMAom42g7UeeVdUBvgPoIWgPSAHgP18aIYiqlF+MmItmvvsYpmqkxTRZgR566U= X-Received: by 10.28.239.19 with SMTP id n19mr11594065wmh.20.1517004677474; Fri, 26 Jan 2018 14:11:17 -0800 (PST) Original-Received: by 10.223.182.77 with HTTP; Fri, 26 Jan 2018 14:11:17 -0800 (PST) In-Reply-To: <871sichok1.fsf@gmx.de> X-Google-Sender-Auth: zZBZQmp48bYFT6ISjYRZ4pqR8Kg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142561 Archived-At: On Fri, Jan 26, 2018 at 6:01 AM, Michael Albinus wrote: > Thanks! I've fixed this in filenotify.el (in fact, the underlying watch > descriptor should not use quoted file names). Patch pushed to the branch. Ah, makes sense. > (equal > ("/:/tmp/emacsqk0Dcl~") > ("/:/tmp/emacsqk0Dcl.~1~")) > I guess, it is because I have set `version-control' to t in my .emacs > (not investigated further). Hmm, couldn't reproduce here, but it looks like a bug (although not as severe as the inf loop stuff). I've tried running the tests on w32, and discovered I missed testing file-newer-than-file-p with both args quoted. There's also some apparently w32-specific trouble with dired-compress-file and insert-directory (although looking at the code, I'm not entirely sure why dired-compress-file passed on GNU/Linux). I pushed 2 more patches to fix file-newer-than-file-p and avoid the test w32 errors. I'm thinking also the massive test needs to be split up, as it's a bit unwieldy. Having one test per operation almost seems like overkill, but I think it will make it easier to check we've covered everything, so I'll probably go with that.