From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 25410@debbugs.gnu.org
Subject: bug#25410: 26.0.50; Refine an unified diff hunk only if adds lines
Date: Fri, 13 Jan 2017 11:31:10 -0500 [thread overview]
Message-ID: <CAM-tV-9dkwZ0eesSe7diuGW2-cL8VHeNTZXJ_wVc2AcHgDp_9w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701131510450.13494@calancha-pc>
On Fri, Jan 13, 2017 at 1:14 AM, Tino Calancha <tino.calancha@gmail.com> wrote:
>
>> + (while (re-search-forward "^-" end t)
>> + (let ((beg-del (progn (beginning-of-line) (point)))
>> + beg-add end-add)
>> + (when (and (diff--forward-while-leading-char ?- end)
>> + ;; Allow for "\ No newline at end of file".
>> + (progn (diff--forward-while-leading-char ?\\ end)
>> + (setq beg-add (point)))
>> + (diff--forward-while-leading-char ?+ end)
>> + (progn (diff--forward-while-leading-char ?\\ end)
>> + (setq end-add (point))))
>
> How about hide the complexity resulting for checking ?\\ inside the
> auxiliary function?
I'm okay with doing this, but I slightly prefer leaving the complexity
at the top level. I think pushing the ?\\ check inside
diff--forward-while-leading-char makes that function's purpose a bit
incoherent and the complexity reduction in the caller doesn't look
significant enough to balance that.
next prev parent reply other threads:[~2017-01-13 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 10:08 bug#25410: 26.0.50; Refine an unified diff hunk only if adds lines Tino Calancha
2017-01-10 14:22 ` npostavs
2017-01-10 15:07 ` Tino Calancha
2017-01-11 2:49 ` Tino Calancha
2017-01-11 8:13 ` Tino Calancha
[not found] ` <87wpe0zz0s.fsf@users.sourceforge.net>
2017-01-12 5:32 ` Tino Calancha
2017-01-13 4:50 ` npostavs
2017-01-13 6:14 ` Tino Calancha
2017-01-13 12:11 ` Tino Calancha
2017-01-13 16:31 ` Noam Postavsky [this message]
2017-01-14 5:38 ` Tino Calancha
2017-01-19 1:55 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-9dkwZ0eesSe7diuGW2-cL8VHeNTZXJ_wVc2AcHgDp_9w@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=25410@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.