From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#23533: 24.5; test-completion with completion-regexp-list Date: Sat, 18 Jun 2016 13:40:04 -0400 Message-ID: References: <87bn497v61.fsf@gmail.com> <83a8iic41h.fsf@gnu.org> <83r3bu9zi4.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1466271687 2042 80.91.229.3 (18 Jun 2016 17:41:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Jun 2016 17:41:27 +0000 (UTC) Cc: ynyaaa@gmail.com, 23533@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 18 19:41:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bEKFA-0001CU-IX for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Jun 2016 19:41:16 +0200 Original-Received: from localhost ([::1]:35863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEKF9-0007ba-KF for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Jun 2016 13:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEKF0-0007ZW-Q0 for bug-gnu-emacs@gnu.org; Sat, 18 Jun 2016 13:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEKEw-0007sm-J9 for bug-gnu-emacs@gnu.org; Sat, 18 Jun 2016 13:41:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEKEw-0007si-FH for bug-gnu-emacs@gnu.org; Sat, 18 Jun 2016 13:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bEKEw-0001qw-Bw for bug-gnu-emacs@gnu.org; Sat, 18 Jun 2016 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jun 2016 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 23533-submit@debbugs.gnu.org id=B23533.14662716127052 (code B ref 23533); Sat, 18 Jun 2016 17:41:02 +0000 Original-Received: (at 23533) by debbugs.gnu.org; 18 Jun 2016 17:40:12 +0000 Original-Received: from localhost ([127.0.0.1]:45364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEKE8-0001pg-1I for submit@debbugs.gnu.org; Sat, 18 Jun 2016 13:40:12 -0400 Original-Received: from mail-oi0-f43.google.com ([209.85.218.43]:34149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEKE6-0001pR-UR for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 13:40:11 -0400 Original-Received: by mail-oi0-f43.google.com with SMTP id d132so158939553oig.1 for <23533@debbugs.gnu.org>; Sat, 18 Jun 2016 10:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=cBEaNQDkTSDYzYPGOopyRrsPb0W60YicTAfF57ShMeQ=; b=NVbJ5M4hgnhb2etVvAmeQHSLDZ25dSomw5YzfFUOHU87eEGfC/gk6JE56zHaiVsFaI XG22C+Mb3f6ZrwIKuLlAHyWXcyTpEm07FMEI9Ce461IumGRB4mEeFawSZ4MxJyt/ALWp RblI23tmRuBrpjS/l9t01ZHoTSpNb1QJI8QN553Z7ho50aNqlqqjXuuxMwYcaDhqNm+R Am6DMtABkzH8MGBIvZPo4Gwa3ixESOrvM++jnUwwD/466GJBcP2Q4jdgAJPishkAmK1h X7GKTLbKsP3Z3/mGQ73sEXL3mb+JB61RLBn6U/BHT7eVIum0Fh0JxKYi+4V5u4jImZ3w t0GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=cBEaNQDkTSDYzYPGOopyRrsPb0W60YicTAfF57ShMeQ=; b=ClQKSCCQEg83iqfN1v0AhtITdearo7PS80GbKR48bN8p31c/WR6MRJyoWe8UZ9c06f iWsPbxtYJtwyB3oIlPt+IWlxBdcsY3gOd9cBqylsctw7nxoMW+5S3kJRaFFSLcPsRuFh uePGRl9iBcZIByGXQ5VzlF3Z9AteGaCnvZJbmWSGVVIsjTCEfjXlW1cllj+kKM2wODVs EErJPOlejfPcWRNZPgO1LO+r6BEFTblAM1SJTIz0d37iholYApZLHEKHf6W6l1JdBdXD zhHT1ySWjrQuEmvwTq7bkj9eXZcnZ/udUzjDkCWnE3LIL+kAvSD21hbR0xUNADVXmo+c 1Nsg== X-Gm-Message-State: ALyK8tIpa60QZoAfp0lRKZDh+PfULqHobScjWe5IjqYHs5PxIy6efrNOPf9ZXo/KiSL2LSL2XhLAcAH+l4NAQw== X-Received: by 10.157.36.227 with SMTP id z90mr5084970ota.124.1466271605395; Sat, 18 Jun 2016 10:40:05 -0700 (PDT) Original-Received: by 10.157.52.238 with HTTP; Sat, 18 Jun 2016 10:40:04 -0700 (PDT) In-Reply-To: <83r3bu9zi4.fsf@gnu.org> X-Google-Sender-Auth: yiLX-r2radOCeNfAERX0NYk4kFQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119744 Archived-At: On Sat, Jun 18, 2016 at 1:29 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Sat, 18 Jun 2016 13:14:59 -0400 >> Cc: 23533@debbugs.gnu.org, ynyaaa@gmail.com >> >> On Sat, Jun 18, 2016 at 4:08 AM, Eli Zaretskii wrote: >> > I'm not sure this is a bug. >> >> I think it's pretty clearly a bug, because the docs explain that >> test-completion takes the same arguments as all-completions and >> try-completions, which do handle an alist COLLECTION with a non-nil >> completion-regexp-list. > > When code contradicts the documentation, it's not immediately clear > that the code should be fixed. Independently of the documentation, I also think it makes no sense to have test-completion be inconsistent with all-completions and try-completion. > > Anyway, I don't consider myself an expert on completion, so I feel > uneasy about makings this change without any of the experts voicing > their opinions on the change. Okay, I will wait another week before pushing to master in case anyone has some objections/comments.