From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Date: Thu, 15 Dec 2016 11:33:36 -0500 Message-ID: References: <7cb86247-1e30-f029-0b9b-c53cc096ec4b@easy-emacs.de> <87mvggh2hu.fsf@users.sourceforge.net> <87h967cj0f.fsf@users.sourceforge.net> <87eg1bcg0y.fsf@users.sourceforge.net> <20161214215834.GB3881@acm.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1481819658 30154 195.159.176.226 (15 Dec 2016 16:34:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Dec 2016 16:34:18 +0000 (UTC) Cc: 24870@debbugs.gnu.org, Matt Armstrong To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 15 17:34:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHYz0-00071w-19 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Dec 2016 17:34:14 +0100 Original-Received: from localhost ([::1]:55642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHYz4-0007Q6-39 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Dec 2016 11:34:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHYyr-0007CD-PK for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:34:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHYyo-0008IG-Ld for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:34:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHYyo-0008Hs-J4 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cHYyo-0007La-9r for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2016 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24870-submit@debbugs.gnu.org id=B24870.148181962728212 (code B ref 24870); Thu, 15 Dec 2016 16:34:02 +0000 Original-Received: (at 24870) by debbugs.gnu.org; 15 Dec 2016 16:33:47 +0000 Original-Received: from localhost ([127.0.0.1]:43106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHYyZ-0007Ky-32 for submit@debbugs.gnu.org; Thu, 15 Dec 2016 11:33:47 -0500 Original-Received: from mail-oi0-f65.google.com ([209.85.218.65]:33405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHYyU-0007Kh-O6 for 24870@debbugs.gnu.org; Thu, 15 Dec 2016 11:33:44 -0500 Original-Received: by mail-oi0-f65.google.com with SMTP id f201so6764578oib.0 for <24870@debbugs.gnu.org>; Thu, 15 Dec 2016 08:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3rxVF/dKh6Og3z+j+3Q1WnV54CtJ9XLAKmk5/i3IFlc=; b=XoWZb6nJe0taFbSzl3fTUCcY6flPY/2B+wo+7c7Qdf8xl+T7ppmQBS5hThR7DHM4wL 1c+mI4sK02JFX/BpUHz6B8echDT5KLQgV4Hyoa+/S4T0EVoe6QT1TuHUVR7pdaLbUaBW U6t+rjtebtJfgJbJ/oLCTiSjkNxirDc7+CGDgGTroK2jCnOO9kFToLBGyD2hmklPT5qO brZSKElY4vkJFWqGBRqLRVy+LP3iOmCUbKSwgmgrv/d39oY0U8MSwsD+3RckT2bnKSyQ CPBDHhubjJcFYuMaXUyuq0Z95sJKWLwmNAyjnk0RC5nRHkSXdFiR7AhWqgYt+ysSzdt5 h9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3rxVF/dKh6Og3z+j+3Q1WnV54CtJ9XLAKmk5/i3IFlc=; b=rBe397x7vfoUbDJuivzQ/DywQQaSvOYy3quPnPRaoPKVuAOIfetKCb77k1YmiXcSa5 h45k6I7o/LKNPYfFEt1534/xJpBOyvpQxeQUVrVQTMSL9A71w+fiAiq77bvv/fsuuat4 94qgUIjC1dYfAxHBC42F8Iu3akx39LCgcvNjc8LfyouifjzqWpPDlhZhNvm0bGblnMyp HBAmIv36gIhrSjm1D1ICDycFWEAZ/+Q4smNKYkUX9cE79V4GF+exx5x8SM407OtKxVJ0 cN7B/9pkQegdiCta15PcpXV0V+C4i61EfBa+BEGAXwVjIMxNurAlO98fVOYmfnU7us2/ t3YQ== X-Gm-Message-State: AKaTC01cdLrYMn09HeO/fZ9eBsW3TZfulkKb2L8ILTEl3ua4ZcAPUJVLi5zqXBb8LRYuyTsI7hXyEA9B2eFNZg== X-Received: by 10.157.53.50 with SMTP id o47mr1676387otc.19.1481819617095; Thu, 15 Dec 2016 08:33:37 -0800 (PST) Original-Received: by 10.157.6.234 with HTTP; Thu, 15 Dec 2016 08:33:36 -0800 (PST) In-Reply-To: <20161214215834.GB3881@acm.fritz.box> X-Google-Sender-Auth: 3OXBLvef7jfIJKtyo0w_C4XLSA8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127060 Archived-At: On Wed, Dec 14, 2016 at 4:58 PM, Alan Mackenzie wrote: > > Alas, that patch won't do. I thought that might be the case. > > What is new here is characters with paren syntax also being components of > 2-char comment delimiters. I recently fixed a similar problem when > characters with word syntax were also flagged as 2-char comment delimiter > parts. I think a similar patch at case label Sopen: (Line ~3322), which > would peek ahead at the next character to check for "{-" before > recognising the "{" as an open paren would be the best fix. I don't think special casing Sopen makes sense, shouldn't the check apply to all syntax classes? (the special case for word syntax does make sense, because it has its own inner loop already) > > Do you want to make this fix, or should I do it? If you want to do it, > I'm willing (indeed, eager) to review it for you. I'll have a patch ready in a day or two.