From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: =?UTF-8?Q?Re=3A_=5BEmacs=2Ddiffs=5D_master_c66aaa6=3A_Recomplexify_=E2=80=98de?= =?UTF-8?Q?lete=2Dtrailing=2Dwhitespace=E2=80=99_by_treating_=5Cn_as_whitespace_aga?= =?UTF-8?Q?in?= Date: Wed, 15 Mar 2017 13:05:59 -0400 Message-ID: References: <20170315023157.29463.36647@vcs0.savannah.gnu.org> <20170315023159.30AA520CAB@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1489597604 19118 195.159.176.226 (15 Mar 2017 17:06:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Mar 2017 17:06:44 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 15 18:06:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coCNZ-0003X3-Pi for ged-emacs-devel@m.gmane.org; Wed, 15 Mar 2017 18:06:29 +0100 Original-Received: from localhost ([::1]:38542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coCNf-0006p0-KQ for ged-emacs-devel@m.gmane.org; Wed, 15 Mar 2017 13:06:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coCN8-0006oh-AP for emacs-devel@gnu.org; Wed, 15 Mar 2017 13:06:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coCN7-0001zq-9M for emacs-devel@gnu.org; Wed, 15 Mar 2017 13:06:02 -0400 Original-Received: from mail-ot0-x22a.google.com ([2607:f8b0:4003:c0f::22a]:35128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1coCN7-0001ze-2E for emacs-devel@gnu.org; Wed, 15 Mar 2017 13:06:01 -0400 Original-Received: by mail-ot0-x22a.google.com with SMTP id x37so25886934ota.2 for ; Wed, 15 Mar 2017 10:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=S/PBUKgPLf47P8QB68xKkirs1o4ImHYjs/siSfZYPkE=; b=RK2ShOTZHym0STikVm596G826WDVZq/pV5wRVUsQ2knQ4XEETqFer480Wu7dhYVZ1K q6LV1KVrtQ3ihHDS6d1zVfS73VTDQ5VMtXWf+jNL5gA1/tEmw2E2Ktw4aJnEzmpW7TYe YM4z6pXAcsWlh9I9KTqAOygJKFlye82i23/E5cRThm5OGMdd5iEUkt0rkuDNhJj7jasV GVSu4lJTS/SDdVYmqxzKSO2QaX3BTtJE7kmLwe72zHufH16UawwEAxbKLnTPA2hFOUc7 VxcOAE9Wq3ElkaFxGkNdl7Ft0leCYUaHDX5+cxr3Vl9WB6cIZmtGOIFlLr32NgGOXi4E /vgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=S/PBUKgPLf47P8QB68xKkirs1o4ImHYjs/siSfZYPkE=; b=lq0N8bUsat0q7h4bOliU6adIdxHCEiKV54LG5bjgIFjiQ9/00Bn0tNXKYDhXxFThsG vbqWSN3EqEvXRw5b4wUA84rykHKWz6jNSnT2TPDyRkWUPjEVaZvPxG/gFGlyKGO3Q5rU MDASbCLITjJAr6yTbjARdrDmxFxSNPGrJakXI80l1mPt6ue7ZcYpf9VgR1o5RurZd2Ed MbmAxT8SMoxo9eTjn5zp5oIxXU19IkMLIu3YCrn3j7AVz2+RTmUpkQlcqQPMrcYXm80k lFcMMmT2LEjdAdO3SA/I48Z1ecGDJTThb6OKnBt2eNIqa/KqS/fi6hVB5REuiik2C+ft KxQg== X-Gm-Message-State: AFeK/H3S877L7Tr5jiByaazNn+mblx2nP96swTpZFZtgQuiEGRbDP/nOorcGk4oQYacLeaD5ueMCh/IvgzGQ2A== X-Received: by 10.157.54.161 with SMTP id h30mr861844otc.30.1489597560326; Wed, 15 Mar 2017 10:06:00 -0700 (PDT) Original-Received: by 10.157.80.172 with HTTP; Wed, 15 Mar 2017 10:05:59 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: YfXoKLCfDygCzYCo39RnwkHdzmE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213043 Archived-At: On Wed, Mar 15, 2017 at 10:50 AM, Stefan Monnier wrote: >>>> Recomplexify =E2=80=98delete-trailing-whitespace=E2=80=99 by treating = \n as >>>> whitespace again >>>> Mostly reverts "Simplify =E2=80=98delete-trailing-whitespace=E2=80=99 = by not treating >>>> \n as whitespace" from 2016-07-04. Setting \n to non-whitespace >>>> causes the regex engine to backtrack a lot when searching for >>>> "\\s-+$" (Bug#26079). >>> Why do we use syntax-tables? >>> IOW why do we use \s- rather than something like [\s\t]? >> No clue. But (re-search-forward "[\s\t]+$" nil t) is also slow. > > Slower than "\\s-+$"? No, seems to be twice as fast actually (this is still horribly slow). On the test file given in Bug#26079[1] (benchmark 1 '(re-search-forward "[\s\t]+$" nil t)) ;=3D> Elapsed time: 9.9= 44000s (benchmark 1 '(save-excursion (let ((end-marker nil)) (goto-char (point-min)) (with-syntax-table (make-syntax-table (syntax-table)) (modify-syntax-entry ?\f "_") (modify-syntax-entry ?\n "_") (re-search-forward "\\s-+$" end-marker t))))) ;=3D> Elapsed time: 20.496000s [1]: https://raw.githubusercontent.com/stakemori/e8theta_degree3/master/res= ults/wt18_17_5/wt18_17_5.org