current-active-maps doesn't look at emulation-mode-map-alists, why?

current-active-maps doesn't look at emulation-mode-map-alists, why?

[Noam Postavsky]

Any reason why current-active-maps doesn't return keymaps from
emulation-mode-map-alists?

Re: current-active-maps doesn't look at emulation-mode-map-alists, why?

[Stefan Monnier]

> Any reason why current-active-maps doesn't return keymaps from
> emulation-mode-map-alists?

The most likely explanation is that this is a bug introduced when
emulation-mode-map-alists was added.

The intention was really to make all code that uses the active keymaps
(such as read-key-sequence or the computation of menubars and toolbars)
get it from current-active-maps, but this never happened, so we still
have that code duplication.


        Stefan

Re: current-active-maps doesn't look at emulation-mode-map-alists, why?

[Noam Postavsky]

On Fri, Dec 23, 2016 at 7:56 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> Any reason why current-active-maps doesn't return keymaps from
>> emulation-mode-map-alists?
>
> The most likely explanation is that this is a bug introduced when
> emulation-mode-map-alists was added.
>
> The intention was really to make all code that uses the active keymaps
> (such as read-key-sequence or the computation of menubars and toolbars)
> get it from current-active-maps, but this never happened, so we still
> have that code duplication.
>

read-key-sequence does use current-active-maps, not sure about
menubars and toolbars (what code is that?)

Fread_key_sequence
  return read_key_sequence_vs (prompt, continue_echo, dont_downcase_last,
read_key_sequence_vs
  i = read_key_sequence (keybuf, ARRAYELTS (keybuf),
read_key_sequence
  current_binding = active_maps (first_event);
active_maps
  return Fcons (Qkeymap, Fcurrent_active_maps (Qt, position));

Re: current-active-maps doesn't look at emulation-mode-map-alists, why?

[Stefan Monnier]

>>> Any reason why current-active-maps doesn't return keymaps from
>>> emulation-mode-map-alists?

What makes you think it doesn't?


        Stefan

Re: current-active-maps doesn't look at emulation-mode-map-alists, why?

[Noam Postavsky]

On Mon, Dec 26, 2016 at 8:50 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>>> Any reason why current-active-maps doesn't return keymaps from
>>>> emulation-mode-map-alists?
>
> What makes you think it doesn't?

Oops. It was a mixup on my end. I had a test where `key-binding'
wasn't returning what I expected and I missed that current_minor_maps
checks emulation-mode-map-alists. So I made a wrapping function which
overrides `this-command-keys-vector' and adds the keymaps from
emulation-mode-map-alists explicitly. But in fact, that second thing
is 100% redundant (the first is needed because I have a binding to
(menu-item ... :filter ...) where the filter uses
`this-command-keys-vector' to make its decision).

Sorry for the noise.