From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24956: 26.0.50; On Windows, setting PATH in compilation-environment has no effect Date: Mon, 21 Nov 2016 18:19:53 -0500 Message-ID: References: <87wpg383pb.fsf@telefonica.net> <83k2c1esbp.fsf@gnu.org> <83wpg1ce8b.fsf@gnu.org> <83shqoaqhy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c183b6b1f02a0541d7e475 X-Trace: blaine.gmane.org 1479770541 22630 195.159.176.226 (21 Nov 2016 23:22:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Nov 2016 23:22:21 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar?= Fuentes , 24956@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 22 00:22:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8xue-0004Xu-UA for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 00:22:13 +0100 Original-Received: from localhost ([::1]:52227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8xui-0002PK-DY for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 18:22:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8xta-0001qO-SI for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 18:21:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8xtW-00033W-4B for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 18:21:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8xtW-00033R-13 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 18:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c8xtV-0001D6-Md for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 18:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2016 23:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24956-submit@debbugs.gnu.org id=B24956.14797704014555 (code B ref 24956); Mon, 21 Nov 2016 23:21:01 +0000 Original-Received: (at 24956) by debbugs.gnu.org; 21 Nov 2016 23:20:01 +0000 Original-Received: from localhost ([127.0.0.1]:37556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8xsX-0001BL-Ab for submit@debbugs.gnu.org; Mon, 21 Nov 2016 18:20:01 -0500 Original-Received: from mail-oi0-f52.google.com ([209.85.218.52]:35175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8xsV-0001B1-QL for 24956@debbugs.gnu.org; Mon, 21 Nov 2016 18:20:00 -0500 Original-Received: by mail-oi0-f52.google.com with SMTP id b126so1011312oia.2 for <24956@debbugs.gnu.org>; Mon, 21 Nov 2016 15:19:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8wHK+2vuMiPrxmBZ/FgyOamjbqNxFUvFtTGbCdfUcVs=; b=KAjwk43ov/Eslv9x42yiH+PgKewWmS41jUjwsRFL1FzvgsU1nfC9h70zHVhQyw/kH+ MJ/+4xkB93UOo1yqtqbr1SLrnUVw8MFe2PYEYUwBrXYGmwLFxTbx+uoIEdpA487h+fP9 V6aSg1eDM0w8qTJqeuNfNzO46plIFOkhv9TMrxrTOw9wcYokU4fHjUJEkLOw3yxMhvYa RTVpyZnf7iX7p6Q55zwdQ6B8HBaRC6hg5RvvGa4TLqm9K0It2ea5VBZzs0b6LKykvSHr Ya1qeiYbyd0yOyEHylJk1lBT3SCGF72QwfV+4QaACgPmxReqXVUZiMbTkaAbR0BWTVAY NMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8wHK+2vuMiPrxmBZ/FgyOamjbqNxFUvFtTGbCdfUcVs=; b=J8GocCUqgDrn3dsxuz6VGEknvoIBqRkgy9YAesl6XrpDf9i60DdB/ZVD7vMxrIiZwl FgtS9ryswSTZ6M5JsD8zxIoqxcBT7E1Kj9uCVs9n32EKccS+UHNjhz/iRlkrcdi7mgpQ b2zSdFrfhQcJagzlyPwzRsjf+hWHfNw/N80q/3MM3EOs7BscOqDNSbfMR8C3FODTAvQ3 dVseTCFCaQbmw1WO/OlGDTnsImu2LGLmRi9iqxrJ1rh0CTAtptt+KcjKnUkRTyaA5cOS buchFlriapynu6E11M/sdf8fZHWR4IwXD3OTYh2FjwYvBs5UX9UWeUC/loV7mk8pWchl uy4w== X-Gm-Message-State: AKaTC0290zWNr63CIGmtYqpUBeY76bGkgYZeQ5Gq/BbnhyiQ/m7a8zEGqUYe2ASCWfqC4cq7Zrqe6o6qsk9o0w== X-Received: by 10.202.236.21 with SMTP id k21mr9886523oih.127.1479770394184; Mon, 21 Nov 2016 15:19:54 -0800 (PST) Original-Received: by 10.157.4.67 with HTTP; Mon, 21 Nov 2016 15:19:53 -0800 (PST) In-Reply-To: <83shqoaqhy.fsf@gnu.org> X-Google-Sender-Auth: TOHxneAyk8Qw24L2hs6ci18SaSg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125969 Archived-At: --001a11c183b6b1f02a0541d7e475 Content-Type: text/plain; charset=UTF-8 On Sat, Nov 19, 2016 at 2:16 AM, Eli Zaretskii wrote: > > . I'd rather have the WINDOWSNT-specific code separate (on w32.c), > so perhaps the for-loop you modified could be left intact, and > instead we perform an additional pass over Vprocess_environment, > after it is already copied, to replace these two variables with > their upper-case equivalents, in that special code on w32.c. Okay, here is a patch that does that. > . If you didn't already, please verify that these 2 variables in the > Emacs's own environment are also upcased, because otherwise I > think we will hit more such problems. That would be the for loop just above my additions (I increased the context so it's fully visible in the patch). --001a11c183b6b1f02a0541d7e475 Content-Type: application/octet-stream; name="v2-0001-Upcase-Path-and-ComSpec-in-process-environment.patch" Content-Disposition: attachment; filename="v2-0001-Upcase-Path-and-ComSpec-in-process-environment.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ivsp27cs0 RnJvbSAxZmU1ZTBkZmIwMWEwNDAwYTkwMDg4ZDQ0ZjJmN2ZjMmJkMjQ0YTQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBGcmksIDE4IE5vdiAyMDE2IDE2OjI2OjUzIC0wNTAwClN1YmplY3Q6IFtQQVRDSCB2Ml0g VXBjYXNlIFBhdGggYW5kIENvbVNwZWMgaW4gcHJvY2Vzcy1lbnZpcm9ubWVudAoKU2luY2UgMjAx Ni0wNy0xOCAiS2VlcCB3MzIgZW52aXJvbm1lbnQgc2V0dGluZ3MgaW50ZXJuYWwgb25seSIsIHRo ZQp1cGNhc2luZyBvZiBlbnZpcm9ubWVudCB2YXJpYWJsZXMgIlBhdGgiIGFuZCAiQ29tU3BlYyIg b2NjdXJlZCBhZnRlcgppbml0aWFsaXppbmcgcHJvY2Vzcy1lbnZpcm9ubWVudC4gIFRoaXMgbWVh bnQgdGhhdCBMaXNwIGNvZGUgdHJ5aW5nIHRvCm92ZXJyaWRlICJQQVRIIiBlbnZpcm9ubWVudCBo YWQgbm8gZWZmZWN0IChCdWcgIzI0OTU2KS4KCiogc3JjL3czMi5jIChpbml0X2Vudmlyb25tZW50 KTogVXBjYXNlIHRoZSAiUGF0aCIgYW5kICJDb21TcGVjIiBlbnRyaWVzCmluIFZwcm9jZXNzX2Vu dmlyb25tZW50LgotLS0KIHNyYy93MzIuYyB8IDE4ICsrKysrKysrKysrKysrKysrKwogMSBmaWxl IGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvdzMyLmMgYi9zcmMv dzMyLmMKaW5kZXggYWQ3ZDk0YS4uMDczOWU1MSAxMDA2NDQKLS0tIGEvc3JjL3czMi5jCisrKyBi L3NyYy93MzIuYwpAQCAtMjg2NywxMCArMjg2NywyOCBAQCBpbml0X2Vudmlyb25tZW50IChjaGFy ICoqIGFyZ3YpCiAgICAgZm9yIChlbnZwID0gZW52aXJvbjsgKmVudnA7IGVudnArKykKICAgICAg IGlmIChfc3RybmljbXAgKCplbnZwLCAiUEFUSD0iLCA1KSA9PSAwKQogCW1lbWNweSAoKmVudnAs ICJQQVRIPSIsIDUpOwogICAgICAgZWxzZSBpZiAoX3N0cm5pY21wICgqZW52cCwgIkNPTVNQRUM9 IiwgOCkgPT0gMCkKIAltZW1jcHkgKCplbnZwLCAiQ09NU1BFQz0iLCA4KTsKKworICAgIC8qIE1h a2UgdGhlIHNhbWUgbW9kaWZpY2F0aW9uIHRvIGBwcm9jZXNzLWVudmlyb25tZW50JyB3aGljaCBo YXMKKyAgICAgICBhbHJlYWR5IGJlZW4gaW5pdGlhbGl6ZWQgaW4gc2V0X2luaXRpYWxfZW52aXJv bm1lbnQuICAqLworICAgIExpc3BfT2JqZWN0IGVudiA9IFZwcm9jZXNzX2Vudmlyb25tZW50Owor ICAgIExpc3BfT2JqZWN0IHBhdGggPSBidWlsZF9zdHJpbmcgKCJQQVRIPSIpOworICAgIExpc3Bf T2JqZWN0IHBhdGhfbGVuID0gbWFrZV9udW1iZXIgKFNCWVRFUyAocGF0aCkpOworICAgIExpc3Bf T2JqZWN0IGNvbXNwZWMgPSBidWlsZF9zdHJpbmcgKCJDT01TUEVDPSIpOworICAgIExpc3BfT2Jq ZWN0IGNvbXNwZWNfbGVuID0gbWFrZV9udW1iZXIgKFNCWVRFUyAoY29tc3BlYykpOworICAgIGZv ciAoOyBDT05TUCAoZW52KTsgZW52ID0gWENEUiAoZW52KSkKKyAgICB7CisgICAgICBMaXNwX09i amVjdCBlbnRyeSA9IFhDQVIgKGVudik7CisgICAgICBpZiAoRVEgKEZjb21wYXJlX3N0cmluZ3Mg KGVudHJ5LCBRbmlsLCBwYXRoX2xlbiwgcGF0aCwgUW5pbCwgUW5pbCwgUXQpLCBRdCkpCisgICAg ICAgIGZvciAocHRyZGlmZl90IGkgPSAwOyBpIDwgU0JZVEVTIChwYXRoKTsgaSsrKQorICAgICAg ICAgIFNTRVQgKGVudHJ5LCBpLCBTUkVGIChwYXRoLCBpKSk7CisgICAgICBlbHNlIGlmIChFUSAo RmNvbXBhcmVfc3RyaW5ncyAoZW50cnksIFFuaWwsIGNvbXNwZWNfbGVuLCBjb21zcGVjLCBRbmls LCBRbmlsLCBRdCksIFF0KSkKKyAgICAgICAgZm9yIChwdHJkaWZmX3QgaSA9IDA7IGkgPCBTQllU RVMgKGNvbXNwZWMpOyBpKyspCisgICAgICAgICAgU1NFVCAoZW50cnksIGksIFNSRUYgKGNvbXNw ZWMsIGkpKTsKKyAgICB9CiAgIH0KIAogICAvKiBSZW1lbWJlciB0aGUgaW5pdGlhbCB3b3JraW5n IGRpcmVjdG9yeSBmb3IgZ2V0Y3dkLiAgKi8KICAgLyogRklYTUU6IERvIHdlIG5lZWQgdG8gcmVz b2x2ZSBwb3NzaWJsZSBzeW1saW5rcyBpbiBzdGFydHVwX2Rpcj8KICAgICAgRG9lcyBpdCBtYXR0 ZXIgYW55d2hlcmUgaW4gRW1hY3M/ICAqLwotLSAKMi42LjIud2luZG93cy4xCgo= --001a11c183b6b1f02a0541d7e475--