From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: How to block tests on hydra Date: Tue, 11 Jul 2017 07:45:27 -0400 Message-ID: References: <87y3s8wf6k.fsf@detlef> <877ezffnhv.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1499773547 22009 195.159.176.226 (11 Jul 2017 11:45:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Jul 2017 11:45:47 +0000 (UTC) Cc: Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 11 13:45:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUtbk-0004wW-FI for ged-emacs-devel@m.gmane.org; Tue, 11 Jul 2017 13:45:36 +0200 Original-Received: from localhost ([::1]:45637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUtbk-0003nB-Tk for ged-emacs-devel@m.gmane.org; Tue, 11 Jul 2017 07:45:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUtbe-0003mu-3s for emacs-devel@gnu.org; Tue, 11 Jul 2017 07:45:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUtbd-0002Vn-0r for emacs-devel@gnu.org; Tue, 11 Jul 2017 07:45:30 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:36487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUtbc-0002VX-Sv for emacs-devel@gnu.org; Tue, 11 Jul 2017 07:45:28 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id x187so99146553oig.3 for ; Tue, 11 Jul 2017 04:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uTAcBlVxZszpxNVJ8n9VOaxxREuLkvAG6yKSoK3/ZYs=; b=SIwQpq3T6KL6souzZfQijwKzrTWHmXvXPySgBddZ+1dW87I7gQT1tEOlAfS/8DST7s VC5junbAauz6hnupXtPwFVXJbDLyFWepb1MPtdKhYU1na1QeYiPdsad5wtz1CQdh0cjH pe4oa9tPL2WIIs0W7mg9091+YA9TYbSy0RJWTq/Dfo8qwCAgYNtfKNroa2Vfjw5UrHEW LUiaHJ7HWUH8d049UCc2dzNUBgk5hLCpXqDFEZy+PkCPSBzErNEcyOsNeaOsAA6wioqu pkCY0Xkdh+M+o4U68NLMqWLv3GKwiTrqHZ5nvgF8S+L15q2uXV8sUFX2DhHnlCTVv+CE Pz4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=uTAcBlVxZszpxNVJ8n9VOaxxREuLkvAG6yKSoK3/ZYs=; b=lPjYvTp5m08U6/RB55nfKN+o9nwejU155DjN3nbUJ6vvrNkBzvaR9Q1TVHUsPFAeO1 zm6FJFWOvy48l8xZnW0Bujp8/iS4uLwwhE0gs2PexCB5/2GpNPiLr954E62eqHIiI5Lj uRqMu/Plzxq4EUMHX7PE0QAwpPnCMv9EhDRgxnhRlNX06lorSq6cEbVb0RJrgy0CZ1BK ACnnAno65TT4bci1wfcFsPQMVVLv2G91ImoNY62u0xaF4ES7RGtT/PTTbJ8LW+pa9eXN m8pSNVqTp+xD0fVhM3A1IFD0s6c4a4TP+a+wFDtVtRNK63KnK6keZCgCjqmsIeKeRf3E J7xw== X-Gm-Message-State: AIVw113fr6wsS1HfweExWEcF6po7C8+ZLgcfudS0pgk/q3W5ChMTA0pB gNHrxGFcmS7NsSBY/WjUZWQLxLam7w== X-Received: by 10.202.106.79 with SMTP id f76mr12303377oic.16.1499773527979; Tue, 11 Jul 2017 04:45:27 -0700 (PDT) Original-Received: by 10.74.113.91 with HTTP; Tue, 11 Jul 2017 04:45:27 -0700 (PDT) In-Reply-To: <877ezffnhv.fsf@detlef> X-Google-Sender-Auth: 91xJ1T9fMhj1B7-qy5zH9c-MUSo X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216464 Archived-At: On Tue, Jul 11, 2017 at 3:20 AM, Michael Albinus wrote: >> >> I'm surprised it does anything at all actually, isn't the (add-to-list >> 'buffers ...) call a bug? Should be using `push' I think. >> >> - (add-to-list 'buffers (generate-new-buffer "foo"))) >> + (push (generate-new-buffer "foo") buffers)) > > Why that? `add-to-list' is as good as `push' in this case. I haven't seen a > problem with that. If you run in edebug, you'll see that `buffers' keeps > all process buffers. But you have lexical-binding:t set at the top of the file, and `buffer' is a let-bound variable, whereas `add-to-list' operates on dynamic variables. Hmm, looking at the disassembly it seems that add-to-list's compiler macro fixed up the problem, although I thought it should give a compile warning in this situation. > >> I noticed you added a with-timeout on that test, but it doesn't seem >> to be working. > > The timeout is a self-defense. And it doesn't trigger at least for me, > because (I believe) the test case is working properly now, and finishes > in time. What about this one: http://hydra.nixos.org/eval/1373949 https://nix-cache.s3.amazonaws.com/log/v7ndmrhdhjw76v9mzghjyijnsmw2npl8-emacs-coverage-unknown.drv > >> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out" >> message when running locally in an -O0 build, although it succeeds >> with an -O2 build. Maybe I just have a weak CPU. > > How does it make a difference? Is an asynchronous process to be intended > to run in another thread, on another processor? I don't know why it makes a difference.