From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21468: 24.5; When next-line (visual) crosses overlay with before-string="\n" point goes to column 0 Date: Sun, 13 Sep 2015 13:20:04 -0400 Message-ID: References: <834miybogz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1442164879 9274 80.91.229.3 (13 Sep 2015 17:21:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Sep 2015 17:21:19 +0000 (UTC) Cc: 21468-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 13 19:21:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbAxh-0005OM-JJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Sep 2015 19:21:09 +0200 Original-Received: from localhost ([::1]:36568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbAxg-0004pG-V3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Sep 2015 13:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbAxe-0004n9-7P for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2015 13:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbAxb-0005ko-4L for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2015 13:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbAxb-0005ki-0g for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2015 13:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbAxa-0000lI-Lm for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2015 13:21:02 -0400 Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2015 17:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 21468@debbugs.gnu.org, npostavs@users.sourceforge.net, npostavs@users.sourceforge.net Original-Received: via spool by 21468-done@debbugs.gnu.org id=D21468.14421648082853 (code D ref 21468); Sun, 13 Sep 2015 17:21:02 +0000 Original-Received: (at 21468-done) by debbugs.gnu.org; 13 Sep 2015 17:20:08 +0000 Original-Received: from localhost ([127.0.0.1]:59205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbAwh-0000jw-TQ for submit@debbugs.gnu.org; Sun, 13 Sep 2015 13:20:08 -0400 Original-Received: from mail-wi0-f178.google.com ([209.85.212.178]:36612) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbAwf-0000jo-II for 21468-done@debbugs.gnu.org; Sun, 13 Sep 2015 13:20:06 -0400 Original-Received: by wicgb1 with SMTP id gb1so114436075wic.1 for <21468-done@debbugs.gnu.org>; Sun, 13 Sep 2015 10:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=WY/q0LeIX8aHdIqo7aKrdTh1MTX0E9zcDIkG5CjF6xs=; b=lGAudnJp9k3ogNy+zz7yiHSWu4sbsyXxgbcfr2sSQHULo4QR7nv/cgf0R4EAhR5Cpb PqsplLXjrQ28bKVjD8q+YylNGPxVRo2sB4dzDwbqbVVTq/L2lZ3BAFR5A0/TOkhtyHAm cfE8lZSCYufXd3HsICFqJmfwz5M08KWd6y0r817ec2d6QI4vf/uHpfb7rrlwqtn7ORrB 82o3LpaPO5wfKrSnJdus2VNUnb/28st+mybOa/rlLUV403+Zyyv7yOLSLmDdFXcxB5Nf NVwnAzLnaW+J3EEpmyacBxr+DL4X+RFk+4Xklql8P0//qrB6ABgixUgeSWnOL3Bh7EQ9 wwIA== X-Received: by 10.194.21.230 with SMTP id y6mr21252429wje.132.1442164805015; Sun, 13 Sep 2015 10:20:05 -0700 (PDT) Original-Received: by 10.28.210.82 with HTTP; Sun, 13 Sep 2015 10:20:04 -0700 (PDT) In-Reply-To: <834miybogz.fsf@gnu.org> X-Google-Sender-Auth: e3jKG-fHnMOxnjSb4Z1RQviQztY X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106481 Archived-At: On Sun, Sep 13, 2015 at 6:30 AM, Eli Zaretskii wrote: > Fixed in commit 6514b30 on master. Thanks, it works. > why can't Magit simply change the buffer text to be what it wants to > display? why does it need to use an overlay string? In this particular case, the overlays are delimiting a "magit region" (consisting of whole logical lines touched by Emacs' region), having them as actual text in the buffer would interfere with point movement even more. Or at least, that's what I saw when I tried just now to do something similar with text properties: (with-current-buffer (get-buffer-create "*text property test*") (erase-buffer) (insert-file "next-line-fail.el") (let ((pos 65)) (goto-char pos) (insert (propertize (concat (propertize "\s" 'display '(space :height (1))) (propertize "\n" 'line-height t)) 'face 'highlight)) (pop-to-buffer (current-buffer))))