From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24901: Caught mistake in elec-pair.el patch Date: Thu, 17 Aug 2017 10:05:49 -0400 Message-ID: References: <871soaz810.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1502978794 9506 195.159.176.226 (17 Aug 2017 14:06:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Aug 2017 14:06:34 +0000 (UTC) Cc: 24901@debbugs.gnu.org, Reuben Thomas To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 17 16:06:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diLR6-0001PY-Gv for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Aug 2017 16:06:12 +0200 Original-Received: from localhost ([::1]:54340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diLRD-0001Zq-3J for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Aug 2017 10:06:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diLR1-0001Um-2w for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 10:06:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1diLQx-00085D-4q for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 10:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34229) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1diLQx-000852-1Q for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 10:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1diLQw-00078L-Hz for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Aug 2017 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24901-submit@debbugs.gnu.org id=B24901.150297875727410 (code B ref 24901); Thu, 17 Aug 2017 14:06:02 +0000 Original-Received: (at 24901) by debbugs.gnu.org; 17 Aug 2017 14:05:57 +0000 Original-Received: from localhost ([127.0.0.1]:42910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diLQq-000782-Vq for submit@debbugs.gnu.org; Thu, 17 Aug 2017 10:05:57 -0400 Original-Received: from mail-oi0-f49.google.com ([209.85.218.49]:36487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diLQp-00077o-El for 24901@debbugs.gnu.org; Thu, 17 Aug 2017 10:05:55 -0400 Original-Received: by mail-oi0-f49.google.com with SMTP id g131so67124390oic.3 for <24901@debbugs.gnu.org>; Thu, 17 Aug 2017 07:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=PLPm4oTqpSJPzadso47/UIMGc/GfAktvRaobYVzLx8c=; b=gzXTp+7fGJoijsjzeuaZ8nSp0Lg1SVyR58WGhqzfz4+gOLQWVOqLjZSVgp1jzRhWpq rWSmbPvYLqSSNAQIVwVejeVyDVPdYdUifK7sDYH80r+Q+1FsXaSyhFuu79cvrKkmScNL WLAIfP9TWSpogvOmCbTQvT9/C9IDj+dytkmKxOjsYP03JYdzZ6XVfAJiz+ot6VEPcJ4X gHR/BfYB8LGuVZcvQz3OuRJzkjRcdPYGiYe//idZ/ThaemJ5/DuSLI+P3XjilHc/EJwd N3rdP7yNUFJ3tmiKWM7jWQaCTPgDL1pnQapg7RiJ8zTf3rkwttQ3S7idOWH7ZpvvQPWX ucnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=PLPm4oTqpSJPzadso47/UIMGc/GfAktvRaobYVzLx8c=; b=Clze6zY8SEiyNBc4saDJshukTpAZ44o0JDpViFdiMvs/JHgYnMdCI/U3fVzzQUbnmI XHdThjIP+eWZEuLEUHW5PM1IbGjVzhdrmGnObeTwrZOHsuuR/QOobsxNwOQ6LsXr/eyb 54eovuEx6GTXLWCmXbmdaRTIXx0NMnu7I+AG8B70S6oQ3rWz+SxcUZDJ7frcR5GSiaYl N/3GqyYmn3OOnlxTWE8iul2Me5ZABUIVqedICXlgpotgJfv+wZBdHAP37seErALjnyME lgqc/lzAYp8dR3DuNaNVO7lWJHydNTWYr05SiAHogY3IrI9rCdFVACrGwhfYHVrQZRd5 kJMQ== X-Gm-Message-State: AHYfb5jDS4VAx/HDVa0YjWkFxlSm3ms3MK1Tjd00WfyN6BPDY3qVc1QC UcK9ICPv0IFJLld+HMMdCew/3Qv/gQ== X-Received: by 10.202.208.79 with SMTP id h76mr7214311oig.65.1502978749643; Thu, 17 Aug 2017 07:05:49 -0700 (PDT) Original-Received: by 10.74.18.129 with HTTP; Thu, 17 Aug 2017 07:05:49 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 0zLas0170_ili_nzvMZnN5Dx7-8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135867 Archived-At: On Thu, Aug 17, 2017 at 9:32 AM, Jo=C3=A3o T=C3=A1vora wrote: > On Thu, Aug 17, 2017 at 1:35 PM, wrote: > >> Or remove the autoload from electric-pair-text-pairs? > > Seems to be there for a reason, unfortunately. It's forward > referenced in electric.el if I'm not mistaken. The reference in electric.el is inside (and electric-pair-mode ...) which is already autoloaded so it should be fine. There is another reference in elisp-mode.el, for which, AFAICT, we can just use explicit require instead (see my patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24901#53; sorry I didn't mention it before, I forgot some mail clients don't show attachments clearly).