From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21824: 25.0.50; overlay modification-hooks called with wrong buffer Date: Sat, 7 Nov 2015 11:22:50 -0500 Message-ID: References: <83611hvl0w.fsf@gnu.org> <8337wktols.fsf@gnu.org> <83twozqhhe.fsf@gnu.org> <838u6aqklr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e013a10e4752f330523f5c54e X-Trace: ger.gmane.org 1446913402 6075 80.91.229.3 (7 Nov 2015 16:23:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Nov 2015 16:23:22 +0000 (UTC) Cc: 21824@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 07 17:23:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zv6Gk-0002hd-PM for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2015 17:23:11 +0100 Original-Received: from localhost ([::1]:44461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv6Gk-0007cf-29 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2015 11:23:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv6Gf-0007bz-Ef for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 11:23:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zv6Gc-0002h0-8E for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 11:23:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv6Gc-0002gw-47 for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 11:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zv6Gb-0005lm-Nv for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 11:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2015 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21824-submit@debbugs.gnu.org id=B21824.144691337422164 (code B ref 21824); Sat, 07 Nov 2015 16:23:01 +0000 Original-Received: (at 21824) by debbugs.gnu.org; 7 Nov 2015 16:22:54 +0000 Original-Received: from localhost ([127.0.0.1]:57016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zv6GT-0005lP-TB for submit@debbugs.gnu.org; Sat, 07 Nov 2015 11:22:54 -0500 Original-Received: from mail-ig0-f178.google.com ([209.85.213.178]:33494) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zv6GR-0005lG-1j for 21824@debbugs.gnu.org; Sat, 07 Nov 2015 11:22:51 -0500 Original-Received: by igvi2 with SMTP id i2so51583764igv.0 for <21824@debbugs.gnu.org>; Sat, 07 Nov 2015 08:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=4edTswaOlcxYFkirEVmkJcF3cox8h1hk2pt+WuB0te8=; b=k4/ZhbiSxCVzOGpvTJPTzJMDBAju4Dc2G7f2EVmghhxPCnoOyCW60zjeWNJ3IN8eGx UtIkV9JbBTX7/77VPSQIlYEW7D+RN7hb1YXLOx9OXN1yTqKDlgWQxq8qQtbBB0ft20RJ z9CA6t8MUZiIKouWZGYIDliPhQ2WkyfENyV/zFNqrOb6GmHVw7nNpjalenMYwSV9XLPV S+p5Qeat7YfEmxGBRSMxy/K1hzqIv/AmZltyzlzQuALN8NS50gC13gMr7yE31U7pimXB gXQQfUzoqpG685pb++UYRNwBvKksaPozLSjD+N3/6Uh1dKNIIxzE54TmfLFZbPn9/ElC 2tFQ== X-Received: by 10.50.117.5 with SMTP id ka5mr14859791igb.58.1446913370295; Sat, 07 Nov 2015 08:22:50 -0800 (PST) Original-Received: by 10.79.119.2 with HTTP; Sat, 7 Nov 2015 08:22:50 -0800 (PST) In-Reply-To: <838u6aqklr.fsf@gnu.org> X-Google-Sender-Auth: 6WqV7ICagHkF3xC17CZmAWQu0HI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108538 Archived-At: --089e013a10e4752f330523f5c54e Content-Type: text/plain; charset=UTF-8 On Sat, Nov 7, 2015 at 3:28 AM, Eli Zaretskii wrote: >> global-highlight-parentheses-mode puts overlays in every buffer. > > Does it really mean to do that in *Messages*? If not, perhaps we > should suggest to the developers of highlight-parentheses to exempt > *Messages* from that, as that buffer is pretty specialized anyway. In > particular, due to the way the message logging in *Messages* is > implemented, the overlay modification hooks will only ever be called > in that buffer with AFTER non-nil, and even that will only happen when > Emacs decides to delete some text from *Messages*; inserting a new > message there will never call the overlay modification hooks. Well, I suppose users may want parentheses highlighted in messages too. But note that the overlays created by highlight-parentheses-mode do *not* have any modification-hooks. It's the triggering modification-hooks of (yasnippet's) overlays in another buffer in addition to the existence of (highlight-parentheses') overlays in *Messages* that triggers the bug. > Yes, this looks good to me. How about creating a new file > buffer-tests.el (the offending code is in buffer.c)? Okay, see attached. --089e013a10e4752f330523f5c54e Content-Type: text/x-diff; charset=US-ASCII; name="0001-Add-test-for-bug-21824.patch" Content-Disposition: attachment; filename="0001-Add-test-for-bug-21824.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igpat4r70 RnJvbSA1NjVkODc0NDI3MTI5MmJjY2IzMzQ0NjBhNjJmZjY2MjgwMmU2YWYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAdXNlcnMuc291cmNl Zm9yZ2UubmV0PgpEYXRlOiBTYXQsIDcgTm92IDIwMTUgMTA6NDc6NTQgLTA1MDAKU3ViamVjdDog W1BBVENIXSBBZGQgdGVzdCBmb3IgYnVnICMyMTgyNAoKKiB0ZXN0L2F1dG9tYXRlZC9idWZmZXIt dGVzdHMuZWw6IE5ldyBmaWxlLgoob3ZlcmxheS1tb2RpZmljYXRpb24taG9va3MtbWVzc2FnZS1v dGhlci1idWYpOiBOZXcgdGVzdC4KLS0tCiB0ZXN0L2F1dG9tYXRlZC9idWZmZXItdGVzdHMuZWwg fCA0OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBj aGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9hdXRvbWF0 ZWQvYnVmZmVyLXRlc3RzLmVsCgpkaWZmIC0tZ2l0IGEvdGVzdC9hdXRvbWF0ZWQvYnVmZmVyLXRl c3RzLmVsIGIvdGVzdC9hdXRvbWF0ZWQvYnVmZmVyLXRlc3RzLmVsCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLmJiM2M5MmQKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0L2F1dG9t YXRlZC9idWZmZXItdGVzdHMuZWwKQEAgLTAsMCArMSw0OCBAQAorOzs7IGJ1ZmZlci10ZXN0cy5l bCAtLS0gdGVzdHMgZm9yIGJ1ZmZlci5jIGZ1bmN0aW9ucyAtKi0gbGV4aWNhbC1iaW5kaW5nOiB0 IC0qLQorCis7OyBDb3B5cmlnaHQgKEMpIDIwMTUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuCisKKzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05VIEVtYWNz IGlzIGZyZWUgc29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkK Kzs7IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug YXMgcHVibGlzaGVkIGJ5Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIg dmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0 ZXIgdmVyc2lvbi4KKworOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRo YXQgaXQgd2lsbCBiZSB1c2VmdWwsCis7OyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhv dXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzsgTUVSQ0hBTlRBQklMSVRZIG9yIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorOzsgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworOzsgWW91IHNob3VsZCBoYXZlIHJl Y2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKzs7IGFsb25n IHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNl cy8+LgorCis7OzsgQ29kZToKKworKHJlcXVpcmUgJ2VydCkKKworKGVydC1kZWZ0ZXN0IG92ZXJs YXktbW9kaWZpY2F0aW9uLWhvb2tzLW1lc3NhZ2Utb3RoZXItYnVmICgpCisgICJUZXN0IGZvciBi dWcjMjE4MjQuCitBZnRlciBhIG1vZGlmaWNhdGlvbi1ob29rIGhhcyBiZWVuIHJ1biBhbmQgdGhl cmUgaXMgYW4gb3ZlcmxheSBpbgordGhlICpNZXNzYWdlcyogYnVmZmVyLCB0aGUgbWVzc2FnZSBj b2FsZXNjaW5nIFsyIHRpbWVzXSB3cm9uZ2x5CitydW5zIHRoZSBtb2RpZmljYXRpb24taG9vayBv ZiB0aGUgb3ZlcmxheSBpbiB0aGUgMXN0IGJ1ZmZlciwgYnV0Cit3aXRoIHBhcmFtZXRlcnMgZnJv bSB0aGUgKk1lc3NhZ2VzKiBidWZmZXIgbW9kaWZpY2F0aW9uLiIKKyAgKGxldCAoKGJ1ZiBuaWwp CisgICAgICAgIChtc2ctb3YgbmlsKSkKKyAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgKGlu c2VydCAiMTIzIikKKyAgICAgIChvdmVybGF5LXB1dCAobWFrZS1vdmVybGF5IDEgMykKKyAgICAg ICAgICAgICAgICAgICAnbW9kaWZpY2F0aW9uLWhvb2tzCisgICAgICAgICAgICAgICAgICAgKGxp c3QgKGxhbWJkYSAoJnJlc3QgXykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGJ1 ZiAoY3VycmVudC1idWZmZXIpKSkpKQorICAgICAgKGdvdG8tY2hhciAyKQorICAgICAgKGluc2Vy dCAieCIpCisgICAgICAodW53aW5kLXByb3RlY3QKKyAgICAgICAgICAocHJvZ24KKyAgICAgICAg ICAgIChzZXRxIG1zZy1vdiAobWFrZS1vdmVybGF5IDEgMSAoZ2V0LWJ1ZmZlci1jcmVhdGUgIipN ZXNzYWdlcyoiKSkpCisgICAgICAgICAgICAobWVzc2FnZSAiYSBtZXNzYWdlIikKKyAgICAgICAg ICAgIChtZXNzYWdlICJhIG1lc3NhZ2UiKQorICAgICAgICAgICAgKHNob3VsZCAoZXEgYnVmIChj dXJyZW50LWJ1ZmZlcikpKSkKKyAgICAgICAgKHdoZW4gbXNnLW92IChkZWxldGUtb3ZlcmxheSBt c2ctb3YpKSkpKSkKKworOzs7IGJ1ZmZlci10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuNi4xCgo= --089e013a10e4752f330523f5c54e--