From: Noam Postavsky <npostavs@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 33263@debbugs.gnu.org
Subject: bug#33263: 27.0.50; Tidying up Gnus modes
Date: Tue, 6 Nov 2018 11:28:17 -0500 [thread overview]
Message-ID: <CAM-tV-92-sWeC6Hrv7=RyFBZ-fNizC8xaZVqDpCxLU4DOHaNoA@mail.gmail.com> (raw)
In-Reply-To: <87k1lqw510.fsf@ericabrahamsen.net>
On Tue, 6 Nov 2018 at 11:22, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
> >>>> +(defvar gnus-browse-mode-map (make-keymap))
> >>>>
> >>>> (unless gnus-browse-mode-map
> >>>> - (setq gnus-browse-mode-map (make-keymap))
> >>>> + (defvar gnus-browse-mode-map (make-keymap))
> Right, I got that much, I was mostly wondering why the `unless' -- it's
> unlikely these files would be loaded multiple times, and even if they
> were, that wouldn't break anything, would it?
Without the `unless', if the user had made changes to
gnus-browse-mode-map they would be lost upon reload (as you say, it's
not especially likely to happen, but I guess the original author
wanted to preserve the semantics of the single defvar form).
next prev parent reply other threads:[~2018-11-06 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 2:53 bug#33263: 27.0.50; Tidying up Gnus modes Eric Abrahamsen
2018-11-05 14:14 ` Noam Postavsky
2018-11-05 17:51 ` Eric Abrahamsen
2018-11-06 13:27 ` Noam Postavsky
2018-11-06 16:21 ` Eric Abrahamsen
2018-11-06 16:28 ` Noam Postavsky [this message]
2018-11-06 17:37 ` Eric Abrahamsen
2018-11-10 4:01 ` bug#33263: 27.0.50; Tidying up Gnus modes, [PATCH] Provide new gnus-mode, derive all gnus major modes from this Noam Postavsky
2018-11-10 4:55 ` Eric Abrahamsen
2018-11-10 20:18 ` Eric Abrahamsen
2018-11-23 17:45 ` bug#33263: 27.0.50; Tidying up Gnus modes Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-92-sWeC6Hrv7=RyFBZ-fNizC8xaZVqDpCxLU4DOHaNoA@mail.gmail.com' \
--to=npostavs@gmail.com \
--cc=33263@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.