From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18034: Bug #18034: toggle-read-only used in the code Date: Sun, 26 Jun 2016 01:40:30 -0400 Message-ID: References: <87tx6h2w43.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1466919683 24372 80.91.229.3 (26 Jun 2016 05:41:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Jun 2016 05:41:23 +0000 (UTC) To: GNU bug tracker automated control server , 18034-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 26 07:41:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bH2ok-000227-Nq for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jun 2016 07:41:14 +0200 Original-Received: from localhost ([::1]:52571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bH2oj-0002F5-OQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jun 2016 01:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bH2od-0002CR-16 for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 01:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bH2oY-0007d6-Rq for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 01:41:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bH2oY-0007cx-Oz for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 01:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bH2oY-0007B4-Ku for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 01:41:02 -0400 In-Reply-To: <87tx6h2w43.fsf@violet.siamics.net> Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2016 05:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 18034@debbugs.gnu.org, npostavs@users.sourceforge.net, ivan@siamics.net Original-Received: via spool by 18034-done@debbugs.gnu.org id=D18034.146691963727532 (code D ref 18034); Sun, 26 Jun 2016 05:41:02 +0000 Original-Received: (at 18034-done) by debbugs.gnu.org; 26 Jun 2016 05:40:37 +0000 Original-Received: from localhost ([127.0.0.1]:55979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o9-00079v-4G for submit@debbugs.gnu.org; Sun, 26 Jun 2016 01:40:37 -0400 Original-Received: from mail-oi0-f46.google.com ([209.85.218.46]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o7-00079c-V1; Sun, 26 Jun 2016 01:40:36 -0400 Original-Received: by mail-oi0-f46.google.com with SMTP id u201so164112318oie.0; Sat, 25 Jun 2016 22:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=pGWklxGOerB4sjJ+cHyNnckUqHc3XoT1MSAP4gEtDpkagGKqwzRjfHkbtS+NaO21Sn HPl8Dmiedt1/EN2lnS4fEVdZDXaDJEB7WXnA9/zgW67YvgYQ9/z3m4j6b31+VasTcTLX rzPI0qVBQL8b/kqGZDkAwVVQibe57XvYRx7lFfMAd0cJ6KFoYkDKeNkBTymxFdlOGgVF 6GsaOEBVQneeiuGx9+zuUl7ruvbmkPPov/Hg5r4ovcueXDC03FpyqEalXjgjvMsSIom9 4q7BGQR5ZGCDWiuB2uAGy42QJPFMQdo883mnVhaVqHmNyuRyRTCzyINDu3I4fPVhiNyz tLaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=bx3bmbsBkmwsYg5U5RnIH3ja6FVQvicuE8ClhNmvP24CDuXfyg0LY/Jv1illmKfzH3 R0ivFlCSiBc53nyS+llgMvWKI+Iaq/O+2DAD9Qbk5ycKnzm49o1uxT5Pv/oQWfMKRJUF BUONANapIgEqvP5a1biLzuu+gt0zDUOEivnJMptwEYL7kPgqb/0F3pBL7JePz/7F2PH4 ONbdezuLoXFXGX/hQNihRPpNK5AoFkZWKSmjRK8hyRS6pig/h4NlrmEd5oARiHPY8DQw s2bmwThdmSExmBqm6/iXttBWV+mc77nyndTw6NhTszBbVrDgLRapZ9PoNYVRIA+3ZJF5 HXZA== X-Gm-Message-State: ALyK8tI3CundH5wGIhtXwNjUfx0oVn1SsgUQh66oAoRYkZegFhUMUOKZbyzDF96OS0JinUiyCJWBHswtQd1UMA== X-Received: by 10.202.207.16 with SMTP id f16mr6491125oig.178.1466919630353; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) Original-Received: by 10.157.52.238 with HTTP; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) X-Google-Sender-Auth: RyP4tpJGeObNUm2OdclUvMp-jec X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120091 Archived-At: # I accidentally marked 18034 fixed due to typo but I meant 18039 fixed 18039 25.0.94 quit However, this bug is fixed as well. I ran the find+gawk expression against emacs-25 sources, only 3 occurences left, and they are acceptable uses kept for backwards compat reasons. I've added context to each hit: ~/src/emacs$ find emacs-25/lisp/ -type f -name \*.el -exec gawk 'FILENAME ~ /\/ { print FILENAME ":" FNR ":\t" $0; }' {} + ;; toggle-read-only is obsolete since 24.3, but since vc-t-r-o was made ;; obsolete earlier, it is ok for the latter to be an alias to the former, ;; since the latter will be removed first. We can't just make it ;; an alias for read-only-mode, since that is not 100% the same. emacs-25/lisp/vc/vc-hooks.el:573: (defalias 'vc-toggle-read-only 'toggle-read-only) (substitute-key-definition 'read-only-mode 'hide-ifdef-toggle-outside-read-only map) ;; `toggle-read-only' is obsoleted by `read-only-mode'. (substitute-key-definition emacs-25/lisp/progmodes/hideif.el:195: 'toggle-read-only 'hide-ifdef-toggle-outside-read-only map) (define-key map [remap read-only-mode] 'dired-toggle-read-only) ;; `toggle-read-only' is an obsolete alias for `read-only-mode' emacs-25/lisp/dired.el:1561: (define-key map [remap toggle-read-only] 'dired-toggle-read-only)