From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Date: Wed, 21 Feb 2018 14:26:46 -0500 Message-ID: References: <87o9kii4an.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1519241095 17822 195.159.176.226 (21 Feb 2018 19:24:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Feb 2018 19:24:55 +0000 (UTC) Cc: Emacs developers To: Robert Cochran Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 21 20:24:50 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoa0Y-0004Jb-4h for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 20:24:50 +0100 Original-Received: from localhost ([::1]:34404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoa2a-0002XZ-HL for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 14:26:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoa2T-0002XC-58 for emacs-devel@gnu.org; Wed, 21 Feb 2018 14:26:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoa2S-0005Ig-5m for emacs-devel@gnu.org; Wed, 21 Feb 2018 14:26:49 -0500 Original-Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:44103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoa2S-0005I7-0q for emacs-devel@gnu.org; Wed, 21 Feb 2018 14:26:48 -0500 Original-Received: by mail-oi0-x229.google.com with SMTP id b8so1944196oib.11 for ; Wed, 21 Feb 2018 11:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=StuPSOJ98vZflNnsMMQ0OpDgUektwRRODzrxGhLHqSw=; b=Y1XV749Skbc/3f9uBBTquYcoE5aZjp8/NZs0Rb/yI6mUseTWRAd/94ODXrfEo2da66 UYnyvxV2Azf/asluyAXhThw5xhu37Dekm1Ph/oIAcXnx9J+wSJHe5foe3MkJ8HcUrxpb uSespVFmoTTAkJv5CIKI3NB/AofEUltGExX+vuWEAXJ97xtqcsq2rZWhoLLUPy9ERLR2 V60MbluVfSmHRPTQGlgik+yvAXQ1tixWMGAiBD3rCuwz/HY3vI/8aOkJFQCcoA8S9AnY f33yJSRXmMZ+V3krCtnFPsFmAtsW0GHzUwxr5NOxJPWHtfUrXhNP+9h64KuDX7NkhnmP yteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=StuPSOJ98vZflNnsMMQ0OpDgUektwRRODzrxGhLHqSw=; b=bW2EOc40fiSaYHg/0rpXsx9uhzlPqLR1NZSCpyvpf2NoQWrhB8DoTOrr0J1sJe+fU9 qm+VCAcFUxHsyWXJFEMjjnDENDQO1ny51GN3WvzBgxJKWBZ/f5k1CvXwgBuNGFI+k5ln hqHKnKC8pLaHniLdciyF62S1ZP3sCgZwWpKuqYrUCFVWgVnMaxRXxCtuWQCiSqbCLA7D 2gcex4S/DjcNxthj3Uu2CvfwgNmOei/dFaY3MgrfXutmUEaNLAkdyWsrz2bAv6tEFGY1 oDGMz+rlYK9sczrsucky9XNMbLMb/8S4zYefh3STVbgZJ4/vTNuf46bftfVY1JZprYFW FCMg== X-Gm-Message-State: APf1xPDkHQ6hUdIfXFA2osGdrQJUzsEeLBQ8Uycc34AK1/o0wPhRiJyi OyuZ9fBc8qdjGbJdKWKgqG+NfjOtfWqqS8T/WoY= X-Google-Smtp-Source: AG47ELuJx+dL1NF7wkhbO/PwzJPeyzjQZuSEvKsdcWk+SBXDlMqiasVll8Z6ZM413Wb7IcG31eMb/C5GkLeMFEm3Egk= X-Received: by 10.202.97.2 with SMTP id v2mr2830202oib.17.1519241207179; Wed, 21 Feb 2018 11:26:47 -0800 (PST) Original-Received: by 10.74.59.65 with HTTP; Wed, 21 Feb 2018 11:26:46 -0800 (PST) In-Reply-To: <87o9kii4an.fsf@cochranmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222966 Archived-At: On Wed, Feb 21, 2018 at 1:30 PM, Robert Cochran wrote: > This patch is rather large - the email patch form is 600k. The reason > for this is that I've touched quite a number of files - over 1,000 > according to the Gitlab interface. If you instead set byte-compile-error-on-warn to t by default (e.g., on the command line) and just set it to nil in files which trigger a warning, would the patch be bigger or larger? By the way, I think it would be better to set it in the local variables list at the end of the file, rather than in the first line. For lexical-binding it's required to put it there for technical reasons, but I think those don't apply to byte-compile-error-on-warn, and that first line can get a bit crowded.